Re: [PATCHES] log_filename_prefix -- log_filename + strftime()

2004-08-31 Thread Andreas Pflug
Tom Lane wrote: Andreas Pflug [EMAIL PROTECTED] writes: I don't have the time now to review the impact, but this might make interpreting the log filename difficult or impossible, effectively corrupting pg_logdir_ls. So if you want to use that, you use a format that it can cope with. you is the

Re: [PATCHES] log_filename_prefix -- log_filename + strftime()

2004-08-31 Thread Ed L.
Should the epoch snprintf format of the int64 pg_time_t timestamp be %lld instead of %d? Ed ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] log_filename_prefix -- log_filename + strftime()

2004-08-31 Thread Ed L.
On Tuesday August 31 2004 8:45, Ed L. wrote: Should the epoch snprintf format of the int64 pg_time_t timestamp be %lld instead of %d? Ah, I see you handled it. ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister

[PATCHES] Timezones on localized windows

2004-08-31 Thread Magnus Hagander
This patch attempts to fix the issue with localized timezones on Windows. Recap: When running on a localized windows version, the timezone name returned is also localized, and therefor does not match our lookup table. Solution: The registry contains both the name of the timezone in english and

[PATCHES] Typo in tab-complete.c

2004-08-31 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Little typo I came across: src/bin/psql/tab-complete.c =~ s/CONVERSATION/CONVERSION/; - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200408311915 -BEGIN PGP SIGNATURE-

[PATCHES] psql tab-completion improvements

2004-08-31 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 NotDashEscaped: You need GnuPG to verify this message Some improvements for the tab-completion of psql. This should address all of the items in the todo list and adds some new things as well. Specifically: * Add support for ALTER SEQUENCE ... *

Re: [PATCHES] Typo in tab-complete.c

2004-08-31 Thread Bruce Momjian
Fixed. Thanks. --- Greg Sabino Mullane wrote: [ There is text before PGP section. ] [ PGP not available, raw data follows ] -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Little typo I came across:

Re: [PATCHES] cygwin 8.0.0beta1 postmaster/syslogger.c, port/dirmod.c,

2004-08-31 Thread Bruce Momjian
OK, patch attached and applied that casts _timezone to (int) on Cygwin. --- Reini Urban wrote: Bruce Momjian schrieb: Should I apply this change? #define TIMEZONE_GLOBAL ((int)_timezone) yes, please. I have

Re: [PATCHES] time_t timezone

2004-08-31 Thread Reini Urban
Now I've found time to test beta2 and came up with the attached better patch: Added configure time_t timezone check for the SUSV definition. Not only cygwin, all newlib installations without struct tm timezone. Casted to (int) timezone. (configure should really be re-created by autoconf. I patched

Re: [PATCHES] time_t timezone

2004-08-31 Thread Tom Lane
Reini Urban [EMAIL PROTECTED] writes: Added configure time_t timezone check for the SUSV definition. Kindly do not claim that this is per SUS spec. http://www.opengroup.org/onlinepubs/007908799/xsh/timezone.html regards, tom lane ---(end of