Re: [PATCHES] Quieting the copyright/startup message...

2004-10-04 Thread Neil Conway
On Mon, 2004-10-04 at 17:33, Sean Chittenden wrote: > After seeing the "Welcome to psql 8.0.0beta3, the PostgreSQL > interactive terminal." message, I finally got irritated enough at it to > try and figure out how to silence it without using the -q option to > psql(1). I think the second hunk (

Re: [PATCHES] license cleanup

2004-10-04 Thread Neil Conway
On Mon, 2004-10-04 at 02:04, Neil Conway wrote: > This patch cleans up the licensing terms on some imported BSD-licensed > files in the source tree Patch applied. -Neil ---(end of broadcast)--- TIP 2: you can get off all lists at once with the u

Re: [PATCHES] pgcrypto: make const array static

2004-10-04 Thread Neil Conway
On Mon, 2004-10-04 at 15:23, Neil Conway wrote: > This one-line patches merges a micro-opt from upstream (OpenBSD) > sources: we can make a read-only local array "static" and reduce the > size of the generated object file slightly. Patch applied. -Neil ---(end of broa

Re: [PATCHES] license cleanup

2004-10-04 Thread Neil Conway
On Tue, 2004-10-05 at 00:11, Peter Eisentraut wrote: > In my opinion, this is a completely pointless exercise in replacing > perfectly good code with code that we didn't know until today. Not > during beta please. Well, I think the chance of there being a bug in NetBSD's strtol/strtoul (that do

[PATCHES] pg_restore - added documentation

2004-10-04 Thread Harald Armin Massa
I suggest to alter the pg_restore --help output from - Usage: pg_restore [OPTION]... [FILE] General options: -d, --dbname=NAMEoutput database name -f, --file=FILENAME output file name --- to: --

Re: [PATCHES] license cleanup

2004-10-04 Thread Marc G. Fournier
On Mon, 4 Oct 2004, Peter Eisentraut wrote: Neil Conway wrote: Attached is a patch that replaces src/port/{strtol.c,strtoul.c} with versions derived from current NetBSD CVS sources, which has a 3-clause BSD license. In my opinion, this is a completely pointless exercise in replacing perfectly good

Re: [PATCHES] FW: Win32 fix for miscinit.c

2004-10-04 Thread Magnus Hagander
> >> Tom's recent patch to improve stale lockfile detection included a > >> call to getppid() which doesn't exist on Windows. > >> There is no clean way to implement one (previously discussed on > >> hackers-win32) hence the attach patch simply #ifdefs out the call. > > Done. I think this is no

Re: [PATCHES] FW: Win32 fix for miscinit.c

2004-10-04 Thread Tom Lane
"Dave Page" <[EMAIL PROTECTED]> writes: >> Tom's recent patch to improve stale lockfile detection >> included a call to getppid() which doesn't exist on Windows. >> There is no clean way to implement one (previously discussed >> on hackers-win32) hence the attach patch simply #ifdefs out the call.

Re: [PATCHES] license cleanup

2004-10-04 Thread Peter Eisentraut
Neil Conway wrote: > Attached is a patch that replaces src/port/{strtol.c,strtoul.c} with > versions derived from current NetBSD CVS sources, which has a > 3-clause BSD license. In my opinion, this is a completely pointless exercise in replacing perfectly good code with code that we didn't know u

Re: [PATCHES] FW: Win32 fix for miscinit.c

2004-10-04 Thread Andrew Dunstan
Ugh. *sigh* I wondered idly if we might be able to make a safe assumption about the staleness of the lockfile based on (possibly not very portably) comparing its mtime with the system boot time. cheers andrew Dave Page wrote: More haste, less speed... Patch attached this time! /D -Origina

[PATCHES] Make libpgport FRONTEND/no-FRONTEND library versions

2004-10-04 Thread Bruce Momjian
The attached applied patch makes libpgport be front-end only and adds libpgport_srv be a backend library that uses palloc, ereport, etc. This simplifies the makefiles for client applications. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] |

[PATCHES] FW: Win32 fix for miscinit.c

2004-10-04 Thread Dave Page
More haste, less speed... Patch attached this time! /D > -Original Message- > From: Dave Page > Sent: 04 October 2004 14:41 > To: PostgreSQL-patches > Subject: Win32 fix for miscinit.c > > Tom's recent patch to improve stale lockfile detection > included a call to getppid() which does

[PATCHES] Win32 fix for miscinit.c

2004-10-04 Thread Dave Page
Tom's recent patch to improve stale lockfile detection included a call to getppid() which doesn't exist on Windows. There is no clean way to implement one (previously discussed on hackers-win32) hence the attach patch simply #ifdefs out the call. Please apply ASAP as the win32 build is currently b

[PATCHES] contrib/spi -lpgport missing

2004-10-04 Thread Reini Urban
Attached hack fixes building under cygwin. The real analysis is in my "LDFLAGS overriding" thread, but if you live with that, this is the only remaining patch for cygwin to compile. Everything else seems to be solved. Even python and perl, now that tcl is removed. Basic plperl regression tests (

Re: [PATCHES] LDFLAGS overriding

2004-10-04 Thread Reini Urban
Tom Lane schrieb: Reini Urban <[EMAIL PROTECTED]> writes: Peter Eisentraut schrieb: Please point out where that happens so it can be corrected. Something like this (against an older cvs snap), but I don't believe that this is the best way to solve it. It just solved building under cygwin. Peter a

Re: [PATCHES] Quieting the copyright/startup message...

2004-10-04 Thread John Hansen
> There is no requirement that the program's output mention the > license terms (perhaps you are thinking of the GPL?) Yea,. I must have been... :) ... John ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http:/

Re: [PATCHES] Quieting the copyright/startup message...

2004-10-04 Thread Neil Conway
John Hansen wrote: Won't that violate the BSD licence? No; if it did, psql's "-q" option would already violate the license. The BSD license merely says: Permission to use, copy, modify, and distribute this software and its documentation for any purpose, without fee, and without a written agreem

Re: [PATCHES] Quieting the copyright/startup message...

2004-10-04 Thread Peter Eisentraut
John Hansen wrote: > Won't that violate the BSD licence? The start-up message doesn't even contain any copyright information, so no. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 9: the planner will ig

Re: [PATCHES] Quieting the copyright/startup message...

2004-10-04 Thread John Hansen
> > After seeing the "Welcome to psql 8.0.0beta3, the PostgreSQL > interactive terminal." message, I finally got irritated > enough at it to try and figure out how to silence it without > using the -q option to psql(1). The attached (trivial) patch > fixes said problem so that one can add "\s

Re: [PATCHES] license cleanup

2004-10-04 Thread Neil Conway
Tom Lane wrote: I think it is a real bad idea to unilaterally change the copyright text in files we got from somewhere else, no matter how benign our intentions. Agreed. Instead, how about adopting the NetBSD version of the functionality? If the files did indeed come from UCB originally, then NetBS

[PATCHES] Quieting the copyright/startup message...

2004-10-04 Thread Sean Chittenden
After seeing the "Welcome to psql 8.0.0beta3, the PostgreSQL interactive terminal." message, I finally got irritated enough at it to try and figure out how to silence it without using the -q option to psql(1). The attached (trivial) patch fixes said problem so that one can add "\set QUIET" to