[PATCHES] port/ build fix

2004-10-26 Thread Neil Conway
This trivial patch fixes a missing dependency in src/port/Makefile: if "make install" is run without the "all" target having been previously built, the build fails. Per report from Kris Jurka. Barring any objections I'll apply this to HEAD before the end of the day. -Neil --- src/port/Makefile +

[PATCHES] pg_autovacuum vacuum cost variables patch v2

2004-10-26 Thread Matthew T. O'Connor
Ok, here is an updated version of the patch I submitted last night. This patch now sets the appropriate vacuum cost variables for both vacuum commands and analyze commands. In addition I have added the new vacuum cost options to the win32 InstallService function. Please give it another look

Re: [PATCHES] HP-UX PA-RISC/Itanium 64-bit Patch and HP-UX 11.23 Patch

2004-10-26 Thread Ed L.
> > > Shinji Teragaito <[EMAIL PROTECTED]> writes: > > >> I made a patch to let PostgreSQL work in the LP64 data model on > > >> HP-UX PA-RISC and HP-UX Itanium platform. I see Shinji's patch changed the library suffix from .sl to .so for ia64. Is that is necessary? If so, why? Thanks, Ed --

[PATCHES] pgstat cleanup: use palloc and AllocateFile

2004-10-26 Thread Neil Conway
This patch changes pgstat.c to use palloc(), AllocateFile() and FreeFile() rather than malloc(), fopen() and fclose(), respectively. I changed more_tabstat_space() (which is invoked at various times indirectly throughout the backend) to allocate memory in its own private memory context, rather tha

Re: [PATCHES] pg_ctl -D canonicalization

2004-10-26 Thread Bruce Momjian
Magnus Hagander wrote: > It seems pg_ctl calls canonicalize_path() only on the path as being used > to access for example the pid file, and not the path that is sent along > to the postmaster. > Specifically, this causes failure on win32 when a path is passed with a > trailing backslash, when it's

Re: [PATCHES] pg_autovacuum vacuum cost variables patch

2004-10-26 Thread Tom Lane
"Michael Paesold" <[EMAIL PROTECTED]> writes: > And it seems it affects analyze much more than vacuum, at least if there is > *nothing* to vacuum... (2 seconds -> 8 seconds) Fixed. The original coding was charging a page fetch cost for each row on each page that analyze looked at :-(

Re: [PATCHES] pg_autovacuum vacuum cost variables patch

2004-10-26 Thread Matthew T. O'Connor
Michael Paesold wrote: Matthew T. O'Connor wrote: Two questions: 1) It is my understanding that these new GUC vars only effect vacuum. That is they do NOT have any effect on an analyze command right? (I ask since I'm only setting the vars before I issue a vacuum command) No, vacuum also affects an

Re: [PATCHES] pg_autovacuum vacuum cost variables patch

2004-10-26 Thread Matthew T. O'Connor
Dave Page wrote: Hi Matthew, It doesn't look like you modified the Win32 service installation code to write these options to the registry when installing the service (see szCommand in InstallService()). Oops Can you tell I didn't write that part of the code ;-) I'll take a look at this tonig

Re: [PATCHES] [HACKERS] ARC Memory Usage analysis

2004-10-26 Thread Simon Riggs
On Tue, 2004-10-26 at 09:49, Simon Riggs wrote: > On Mon, 2004-10-25 at 16:34, Jan Wieck wrote: > > The problem is, with a too small directory ARC cannot guesstimate what > > might be in the kernel buffers. Nor can it guesstimate what recently was > > in the kernel buffers and got pushed out fro

Re: [PATCHES] pg_autovacuum vacuum cost variables patch

2004-10-26 Thread Michael Paesold
Matthew T. O'Connor wrote: Two questions: 1) It is my understanding that these new GUC vars only effect vacuum. That is they do NOT have any effect on an analyze command right? (I ask since I'm only setting the vars before I issue a vacuum command) No, vacuum also affects analyze alone (cvs tip her

Re: [PATCHES] [HACKERS] ARC Memory Usage analysis

2004-10-26 Thread Simon Riggs
On Mon, 2004-10-25 at 16:34, Jan Wieck wrote: > The problem is, with a too small directory ARC cannot guesstimate what > might be in the kernel buffers. Nor can it guesstimate what recently was > in the kernel buffers and got pushed out from there. That results in a > way too small B1 list, and

Re: [PATCHES] pg_autovacuum vacuum cost variables patch

2004-10-26 Thread Dave Page
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Matthew T. O'Connor > Sent: 26 October 2004 06:40 > To: pgsql-patches > Subject: [PATCHES] pg_autovacuum vacuum cost variables patch > > Please review and if deemed accecptable, please apply to