Re: [PATCHES] [HACKERS] cygwin build failure

2004-11-07 Thread Reini Urban
Bruce Momjian schrieb: OK, Andrew found the proper flag so Cygwin and MinGW linking will find the first matching library symbol (like Unix) and not error out because of multiple definitions. I have applied the following patch and removed the pg_dump Makefile hack we had before.

[PATCHES] pgxs patch for win32 (v2)

2004-11-07 Thread Fabien COELHO
Dear patchers, please find attached a very small patch which: - install win32 headers on "make install" - install libpostgres.a library under win32 by default (MAKE_DLL=true) - fix CPPFLAGS under win32 to look for these added header under PGXS it was tested by Thomas Hallgren to build PL/Java wi

Re: [PATCHES] calling currval() before nextval() patch adding currval_isset()

2004-11-07 Thread John Hansen
> Hi list, > > attached, cvs context diff that adds currval_isset('sequence_name'); > Updated patch attached, didn't think to update the docs. Thanks oicu! Kind Regards, John Hansen Index: doc/src/sgml/func.sgml === RCS file: /pro

Re: [PATCHES] calling currval() before nextval() patch adding

2004-11-07 Thread John Hansen
> Hmmm, is mysql's last_insert_id behaviour really that much to ask > for? Come to think of it, maybe the attached last_insert_id() patch is a better option. Actually copying the behaviour of mysql's counterpart. ... John Index: doc/src/sgml/func.sgml =

Re: [PATCHES] calling currval() before nextval() patch adding

2004-11-07 Thread John Hansen
> I would argue that a program written that way is broken by definition, > and we should not encourage programmers to write broken applications. Hmmm, is mysql's last_insert_id behaviour really that much to ask for? This is basically what I'm trying to emulate, to make porting mysql applicat

Re: [PATCHES] calling currval() before nextval() patch adding

2004-11-07 Thread John Hansen
> This might do what you're looking for on 8.0. > > CREATE OR REPLACE FUNCTION currval_isset(text) RETURNS bigint AS ' > DECLARE > var integer; > BEGIN > SELECT currval($1) INTO var; > > RETURN var; > > EXCEPTION > WHENOBJECT_NOT_IN_PREREQUISITE_STATE THEN > RETURN 0; > END;

Re: [PATCHES] calling currval() before nextval() patch adding currval_isset()

2004-11-07 Thread Tom Lane
John Hansen <[EMAIL PROTECTED]> writes: > attached, cvs context diff that adds currval_isset('sequence_name'); > This avoids the warning messages you get when calling currval before > nextval in situations where the program flow does not allow you to > predetermine if the current session has calle

Re: [PATCHES] Romanian translation for 8.0: new file (psql)

2004-11-07 Thread Peter Eisentraut
Alin Vaida wrote: > As this is a new translation, please make sure that it gets added to > src/bin/psql/nls.mk Done. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 2: you can get off all lists at once w

Re: [PATCHES] calling currval() before nextval() patch adding

2004-11-07 Thread Rod Taylor
On Sun, 2004-11-07 at 17:21, John Hansen wrote: > Hi list, > > attached, cvs context diff that adds currval_isset('sequence_name'); > With this patch, I can now call currval_isset to determine if I need to > call currval. Previously, I just called currval, but with the result of > filling up the

Re: [PATCHES] Translation updates

2004-11-07 Thread Peter Eisentraut
Alvaro Herrera wrote: > Attached are translation updates for libpq, psql and pg_ctl, and a > new translation for pg_config. Installed. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 1: subscribe and unsu

Re: [PATCHES] New translation for 8.0: Romanian

2004-11-07 Thread Peter Eisentraut
Alin Vaida wrote: > As this is a new translation, please make sure that it gets added to > src/initdb/nls.mk Done. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 2: you can get off all lists at once wit

Re: [PATCHES] French translation updates for 8.0

2004-11-07 Thread Peter Eisentraut
Guillaume LELARGE wrote: > Thanks. Here is the last one. Installed. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] Translation updates for 8.0: postgres-tr

2004-11-07 Thread Peter Eisentraut
Nicolai Tufar wrote: > Attached is postgres-tr.po about 65% finished. $ msgfmt -o /dev/null -c -v postgres-tr.po postgres-tr.po:1:2: parse error msgfmt: found 1 fatal error Please correct that. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of bro

[PATCHES] Enhanced PITR doc patch

2004-11-07 Thread Simon Riggs
A range of minor enhancements, plus some stronger doc around: - warnings about overwrites - additional documentation of recovery.conf parameters To be frank, its still about 50 pages short of a full discussion of how it works, when to use it, various scenarios, best practice, integration with XA

[PATCHES] win32 cleanup

2004-11-07 Thread Andrew Dunstan
The attached patch adds a few prototypes and does a typecast, thus removing some harmless but annoying compile warnings on Win32. cheers andrew Index: src/backend/port/dynloader/win32.c === RCS file: /home/cvsmirror/pgsql/src/backend

[PATCHES] calling currval() before nextval() patch adding currval_isset()

2004-11-07 Thread John Hansen
Hi list, attached, cvs context diff that adds currval_isset('sequence_name'); This avoids the warning messages you get when calling currval before nextval in situations where the program flow does not allow you to predetermine if the current session has called nexval yet. I have for example, a g

Re: [PATCHES] GiST: memory allocation, cleanup

2004-11-07 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I'm a bit dubious about this, mainly because you did not likewise >> const-ify the other input arguments; it seems confusing to do a partial >> const-ification. > Well, "partial const-ification" is the rule rather than the exception in

[PATCHES] New translation for 8.0: Romanian

2004-11-07 Thread Alin Vaida
As this is a new translation, please make sure that it gets added to src/initdb/nls.mk Thank you, Alin Vaida initdb-ro.po Description: application/gettext ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropri

[PATCHES] regression alternative for float8/openbsd

2004-11-07 Thread Andrew Dunstan
The attached alternative regression test result should fix the regression test problem seen here on OpenBSD: http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=emu&dt=2004-11-07%2011:35:03 cheers andrew -- -- FLOAT8 -- CREATE TABLE FLOAT8_TBL(f1 float8); INSERT INTO FLOAT8_TBL(f1) VALUES ('0.

Re: [PATCHES] contrib/xml2: add function xml_encode_special_chars

2004-11-07 Thread Simon Riggs
On Sun, 2004-11-07 at 12:56, Markus Bertheau wrote: > Ð ÐÑÐ, 07.11.2004, Ð 09:33, Simon Riggs ÐÐÑÐÑ: > > On Sat, 2004-11-06 at 23:42, Markus Bertheau wrote: > > > Ð ÐÐÑ, 06.11.2004, Ð 23:13, Simon Riggs ÐÐÑÐÑ: > > > > On Sat, 2004-11-06 at 00:36, Markus Bertheau wrote: > > > > > Ð ÐÐÑ, 06.11.2004,

Re: [PATCHES] contrib/xml2: add function xml_encode_special_chars

2004-11-07 Thread Markus Bertheau
Ð ÐÑÐ, 07.11.2004, Ð 09:33, Simon Riggs ÐÐÑÐÑ: > On Sat, 2004-11-06 at 23:42, Markus Bertheau wrote: > > Ð ÐÐÑ, 06.11.2004, Ð 23:13, Simon Riggs ÐÐÑÐÑ: > > > On Sat, 2004-11-06 at 00:36, Markus Bertheau wrote: > > > > Ð ÐÐÑ, 06.11.2004, Ð 01:24, Peter Eisentraut ÐÐÑÐÑ: > > > > > Markus Bertheau wro

Re: [PATCHES] pgxs under Win32 for PL/Java

2004-11-07 Thread Magnus Hagander
>I can test cygwin too. But just out of curiosity; why would >anyone want >to use cygwin with 8.0? It runs on 9x, native requires NT. There are still a lot of ppl on 9x. I wouldn't expect a production server on 9x (indeed not a server at all), but certainly some desktops that are using it. //Ma

Re: [PATCHES] GiST: memory allocation, cleanup

2004-11-07 Thread Neil Conway
Tom Lane wrote: I think you can assume that noplace else in the backend will invoke the sk_func, period. Great, thanks for the info. - mark the array that indicates NULLs that is passed to index_formtuple() as 'const', and fix the resulting fallout I'm a bit dubious about this, mainly because you d

Re: [PATCHES] pgxs under Win32 for PL/Java

2004-11-07 Thread Thomas Hallgren
Fabien COELHO wrote: I have no mean to test that on a win32 machine. Could you do it? Sure, I'll test it sometime tomorrow or the day after. I'll get back to you. I'm wondering whether the MAKE_DLL fix should also be done under cygwin. Any opinion? I can test cygwin too. But just out of curio

[PATCHES] pgxs under Win32 for PL/Java

2004-11-07 Thread Fabien COELHO
Dear Thomas, > I'm trying to change the Makefile system for PL/Java so that it uses > PGXS instead of compiling using a complete PostgreSQL source tree. As it > turns out, the directory "include/port/win32" is not present in the > PostgreSQL binary installation. Without it, it's not possible to c

Re: [PATCHES] contrib/xml2: add function xml_encode_special_chars

2004-11-07 Thread Simon Riggs
On Sat, 2004-11-06 at 23:42, Markus Bertheau wrote: > Ð ÐÐÑ, 06.11.2004, Ð 23:13, Simon Riggs ÐÐÑÐÑ: > > On Sat, 2004-11-06 at 00:36, Markus Bertheau wrote: > > > Ð ÐÐÑ, 06.11.2004, Ð 01:24, Peter Eisentraut ÐÐÑÐÑ: > > > > Markus Bertheau wrote: > > > > > attached is a patch that adds the function

Re: [PATCHES] Add remove duplicate slashes to canonicalize_path()

2004-11-07 Thread Reini Urban
Bruce Momjian schrieb: The following applied patch removes duplicate slashes from the path in canonicalize_path(). It preserve double leading slashes on Win32. e.g. ab => /a/b snip *o make Win32 path use Unix slashes *o remove trailing quote on Win32 *