Thanks. Your changes have been merged in.
---
Gavin Sherry wrote:
Diff to the HTML version attached.
I'm assuming that you have a script to dump the text version, so I haven't
sent a diff against the text version. Note
Here's a patch containing the function SPI_iterate_query_roots(...). I'm
optimistic so it's complete with documentation :-)
I think that this function is needed so that PL/lang authors like
myself have a way to investigate the semantics of a prepared query. For
me this is essential since I
Tom Lane wrote:
We haven't got one that will work from inside arbitrary functions ---
DefineSavepoint and friends don't get it done by themselves, but
expect you to call CommitTransactionCommand/StartTransactionCommand,
and those functions tend to pull the rug out from under the executor.
(I seem
Bruce Momjian [EMAIL PROTECTED] writes:
FYI, I still see compile warnings. I assume they are just related to me
using Perl 5.0.5 and will ignore them:
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/test/regress'
gmake[1]: Leaving directory
Thomas Hallgren [EMAIL PROTECTED] writes:
What are the future plans?
I haven't got any at the moment ;-). It would make sense to think about
extending the SPI API along the lines you suggest, but I really am not
clear on the implications. Right at the moment I'm focused on trying to
push 8.0
Uh, what was the TODO here? I forgot.
---
John Hansen wrote:
I think it is *way* too late in the dev cycle to be proposing this.
Maybe it should be a TODO item - I at least don't have time even to
think about the
Bruce Momjian said:
Uh, what was the TODO here? I forgot.
John wanted us to allow use of the 'locale' and 'utf8' pragmas in trusted
code. If there's a TODO it would be to investigate the possibility, as I am
very far from certain that there is a simple way to do it safely right now.
Maybe
This is a little patch to correct the documentation on CVS. The URL for
downloading CVS at cyclic.com site is long defunct, and I changed the text
to not overtly recommend CVS 1.10, a now fairly old version.
Jon
--
Jon Jensen
End Point Corporation
http://www.endpoint.com/
Software development
Thomas Hallgren [EMAIL PROTECTED] writes:
I think that this function is needed so that PL/lang authors like
myself have a way to investigate the semantics of a prepared query.
Which you will do what with? I'm not sure I see the point of treating
_SPI_plan as an opaque type while assuming you
Tom Lane wrote:
Looks pretty rejectish to me...
regards, tom lane
Arrghh.
Forget my patch. It's not possible to set savepoints at all using SPI!
Here I was, thinking that only begin/commit/rollback was rejected (I
trusted the documentation and did not dive into the code).
A patch is
Tom Lane wrote:
You do realize that SPI_execute will reject TransactionStmt anyway?
The example is therefore not very compelling ...
It won't reject savepoint related statements and that's what the example
is for.
I want savepoints rejected unless they go through a specific method
found on
Thomas Hallgren [EMAIL PROTECTED] writes:
Tom Lane wrote:
You do realize that SPI_execute will reject TransactionStmt anyway?
The example is therefore not very compelling ...
It won't reject savepoint related statements and that's what the example
is for.
Really?
if
Tom Lane wrote:
Which you will do what with? I'm not sure I see the point of treating
_SPI_plan as an opaque type while assuming you know what to do with a
Query.
What's different in that compared to the methods that use a Snapshot?
The fact that I provided documentation? If so, ok remove the
Thomas Hallgren [EMAIL PROTECTED] writes:
So what *is* the appropriate way of starting, releasing, and rolling
back savepoints then?
We haven't got one that will work from inside arbitrary functions ---
DefineSavepoint and friends don't get it done by themselves, but
expect you to call
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Yes, that is the logic in my patch, except that I don't check errno, I
just call sigpending().
No, that's wrong: if there is a pending SIGPIPE that belongs to the
outer app, you'd clear it.
True, but I documented that in the patch.
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
No, that's wrong: if there is a pending SIGPIPE that belongs to the
outer app, you'd clear it.
True, but I documented that in the patch.
A documented bug is still a bug. The entire point of this change is to
not interfere with the
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
No, that's wrong: if there is a pending SIGPIPE that belongs to the
outer app, you'd clear it.
True, but I documented that in the patch.
A documented bug is still a bug. The entire point of this change is to
On Thu, 2004-12-02 at 00:52 +, Jon Jensen wrote:
This is a little patch to correct the documentation on CVS. The URL for
downloading CVS at cyclic.com site is long defunct, and I changed the text
to not overtly recommend CVS 1.10, a now fairly old version.
Applied. Thanks!
-Neil
18 matches
Mail list logo
