Re: [PATCHES] pg_autovacuum Win32 Service startup delay

2005-01-24 Thread Tom Lane
"Matthew T. O'Connor" writes: > In the windows service world, is there any reason pg_autovacuum should > ever give up? I was a bit worried about the scenario in which J Random Luser tries to start the server twice and ends up with two autovacuum daemons attached to the same postmaster. I'm not

Re: [PATCHES] add soundex difference function to

2005-01-24 Thread Neil Conway
On Tue, 2005-01-25 at 02:26 -0500, Kris Jurka wrote: > Yes, it should, and even more importantly strict because it crashes when > called with null inputs. I copied this off the adjacent entry without > thinking about it. So currently SELECT text_soundex(NULL); crashes the > server. Ah, good catc

Re: [PATCHES] add soundex difference function to contrib/fuzzystrmatch

2005-01-24 Thread Kris Jurka
On Tue, 25 Jan 2005, Neil Conway wrote: > On Tue, 2005-01-25 at 01:13 -0500, Kris Jurka wrote: > > The attached patch implements the soundex difference function which > > compares two strings' soundex values for similarity. > > *** 19,24 > --- 19,28 > AS 'MODULE_PATHNAME', 'soundex

Re: [PATCHES] add soundex difference function to

2005-01-24 Thread Neil Conway
On Tue, 2005-01-25 at 01:13 -0500, Kris Jurka wrote: > The attached patch implements the soundex difference function which > compares two strings' soundex values for similarity. *** 19,24 --- 19,28 AS 'MODULE_PATHNAME', 'soundex' LANGUAGE 'C'; + CREATE FUNCTION difference(text,te

Re: [PATCHES] pg_autovacuum Win32 Service startup delay

2005-01-24 Thread Michael Paesold
Tom Lane wrote: Alvaro Herrera <[EMAIL PROTECTED]> writes: On Mon, Jan 24, 2005 at 06:57:54PM -0500, Tom Lane wrote: (Five minutes at least has a defensible rationale, ie it's the default checkpoint interval and we expect we can replay the log at least as fast as it was created initially.) Hmm, I

[PATCHES] add soundex difference function to contrib/fuzzystrmatch

2005-01-24 Thread Kris Jurka
The attached patch implements the soundex difference function which compares two strings' soundex values for similarity. http://databases.about.com/od/development/l/aasoundex.htm Kris Jurka? contrib/fuzzystrmatch/.deps ? contrib/fuzzystrmatch/fuzzystrmatch.sql ? contrib/fuzzystrmatch/libfuzzyst

Re: [PATCHES] add regression test for #1433

2005-01-24 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > This patch adds a regression test for the bug with domains and ALTER > TABLE that Tom fixed a few hours ago. It might be better to make the tables TEMP tables --- there are some regression tests that depend on the set of existing tables, IIRC. Otherwise ok

Re: [PATCHES] pg_autovacuum Win32 Service startup delay

2005-01-24 Thread Matthew T. O'Connor
Dave Page wrote: When starting as a service at boot time on Windows, pg_autovacuum may fail to start because the PostgreSQL service is still starting up. This patch causes the service to attempt a second connection 30 seconds after the initial connection failure before giving up entirely. In the

Re: [PATCHES] add regression test for #1433

2005-01-24 Thread Neil Conway
On Tue, 2005-01-25 at 11:56 +1100, Neil Conway wrote: > This patch adds a regression test for the bug with domains and ALTER > TABLE that Tom fixed a few hours ago. Applied. -Neil ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ

Re: [PATCHES] add regression test for #1433

2005-01-24 Thread Neil Conway
On Mon, 2005-01-24 at 22:22 -0500, Tom Lane wrote: > It might be better to make the tables TEMP tables --- there are some > regression tests that depend on the set of existing tables, IIRC. > Otherwise ok. True, although those kind of dependencies usually cause an obvious test failure (which this

[PATCHES] add regression test for #1433

2005-01-24 Thread Neil Conway
This patch adds a regression test for the bug with domains and ALTER TABLE that Tom fixed a few hours ago. Barring any objections I'll apply this to HEAD by the end of the day. -Neil Index: src/test/regress/expected/domain.out === R

Re: [PATCHES] pg_autovacuum Win32 Service startup delay

2005-01-24 Thread Alvaro Herrera
On Mon, Jan 24, 2005 at 06:57:54PM -0500, Tom Lane wrote: > (Five minutes at least has a defensible rationale, ie it's the default > checkpoint interval and we expect we can replay the log at least as > fast as it was created initially.) Hmm, I remember Mark Wong from OSDL saying that it took to

Re: [PATCHES] pg_autovacuum Win32 Service startup delay

2005-01-24 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > On Mon, Jan 24, 2005 at 06:57:54PM -0500, Tom Lane wrote: >> (Five minutes at least has a defensible rationale, ie it's the default >> checkpoint interval and we expect we can replay the log at least as >> fast as it was created initially.) > Hmm, I rem

Re: [PATCHES] LRU

2005-01-24 Thread Neil Conway
On Mon, 2005-01-24 at 18:43 -0500, Tom Lane wrote: > Well, the thing that's bothering me is that you are undoing a number of > changes that we'll probably just have to redo later; with consequently > *two* chances to introduce bugs. I'm not sure if we should apply this patch to both HEAD and REL8_

Re: [PATCHES] LRU

2005-01-24 Thread Neil Conway
On Mon, 2005-01-24 at 17:39 -0500, Tom Lane wrote: > I'm more than slightly uncomfortable with the size of this patch. [...] > I think it would be better and safer to try to localize the changes > into freelist.c. IMHO that is basically what the patch does; the changes to other files are either co

Re: [PATCHES] LRU

2005-01-24 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > This patch replaces ARC with LRU in current sources. I'm more than slightly uncomfortable with the size of this patch. I realize that what you were trying to do was revert the code to its 7.4 state, but is that the long-run direction we want to pursue? I t

Re: [PATCHES] pg_autovacuum Win32 Service startup delay

2005-01-24 Thread Tom Lane
"Dave Page" writes: > When starting as a service at boot time on Windows, pg_autovacuum may > fail to start because the PostgreSQL service is still starting up. This > patch causes the service to attempt a second connection 30 seconds after > the initial connection failure before giving up entirel

[PATCHES] Fix for SHGetSpecialFolderPath

2005-01-24 Thread Magnus Hagander
Attached patch fixes the SHGetSpecialFolderPath issues on NT4. It does this by using SHGetFolderPath instead of SHGetSpecialFolderPath, and linking to shfolder.dll instead of shell32.dll. shfolder.dll exists as a redistributable from Microsoft in case it is needed on a system, and it's supported on

Re: [PATCHES] LRU

2005-01-24 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > In other words, you might be able to somewhat reduce the size of the > patch by, say, not renaming some exported functions in freelist.c, but I > don't see that that will have a significant effect upon the complexity > of the patch or the risk that it might

[PATCHES] pg_autovacuum Win32 Service startup delay

2005-01-24 Thread Dave Page
When starting as a service at boot time on Windows, pg_autovacuum may fail to start because the PostgreSQL service is still starting up. This patch causes the service to attempt a second connection 30 seconds after the initial connection failure before giving up entirely. Regards, Dave startup_d