[PATCHES] Clarify use of NOW() in pl/pgsql docs

2005-01-27 Thread David Fetter
Folks, This one from Ben Calvert. It uses the (imho clearer) NOW() rather than 'NOW' in a PL/PgSQL function example. Cheers, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/ phone: +1 510 893 6100 mobile: +1 415 235 3778 Remember to vote! Index: doc/src/sgml/plpgsql.sgml

Re: [PATCHES] pg_autovacuum Win32 Service startup delay

2005-01-27 Thread Dave Page
-Original Message- From: Tom Lane [mailto:[EMAIL PROTECTED] Sent: 24 January 2005 23:58 To: Dave Page Cc: pgsql-patches@postgresql.org Subject: Re: [PATCHES] pg_autovacuum Win32 Service startup delay Dave Page dpage@vale-housing.co.uk writes: When starting as a service at

Re: [PATCHES] dbsize patch

2005-01-27 Thread Andreas Pflug
Neil Conway wrote: On Tue, 2005-01-25 at 16:49 -0700, Ed L. wrote: The attached dbsize patch: + makes relation_size(relname) include toast tables; + adds aggregate_relation_size(relname) to count table data and indices; + adds indices_size(relname) to report the size of

Re: [PATCHES] dbsize patch

2005-01-27 Thread Tom Lane
Andreas Pflug [EMAIL PROTECTED] writes: Hm, these are all implementable as SQL functions, do we need these hard coded too? e.g. create function aggregate_relation_size(oid) returns int8 as $CODE$ select sum(pg_relation_size(indexrelid)) from pg_index where indrelid=$1; $CODE$ language

Re: [PATCHES] dbsize patch

2005-01-27 Thread Ed L.
On Thu, 2005-01-27 at 08:05 +0100, Michael Paesold wrote: Perhaps you could rename indices_size to indexes_size. Attached patch identical except for s/indices/indexes/g. Attached is the same patch as context diff. (prior send from unregistered email address) Ed Index:

Re: [PATCHES] Fix for SHGetSpecialFolderPath

2005-01-27 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Attached patch fixes the SHGetSpecialFolderPath issues on NT4. It does this by using SHGetFolderPath instead of SHGetSpecialFolderPath, and linking to shfolder.dll instead of shell32.dll. shfolder.dll exists as a redistributable from Microsoft in case

Re: [PATCHES] [HACKERS] WAL: O_DIRECT and multipage-writer

2005-01-27 Thread Mark Wong
Hi everyone, I gave this a try with DBT-2, but got a core dump on our ia64 system. I hope this isn't a random thing, like I ran into previously. Maybe I'll try again, but postgres dumped core. Binary and core here: http://developer.osdl.org/markw/pgsql/core/2morefiles.tar.bz2 #0

Re: [PATCHES] dbsize patch

2005-01-27 Thread Ed L.
On Thursday January 27 2005 6:59, Andreas Pflug wrote: Neil Conway wrote: On Tue, 2005-01-25 at 16:49 -0700, Ed L. wrote: The attached dbsize patch: + makes relation_size(relname) include toast tables; + adds aggregate_relation_size(relname) to count table data and indices; +

Re: [PATCHES] [HACKERS] WAL: O_DIRECT and multipage-writer

2005-01-27 Thread Mark Wong
Hmm... I don't remember specifying a datatype. I suppose whatever the default one is. :) I'll be happy to test again, just let me know. Mark On Fri, Jan 28, 2005 at 06:28:32AM +0900, ITAGAKI Takahiro wrote: Thanks for testing, Mark! I gave this a try with DBT-2, but got a core dump on our

Re: [PATCHES] [HACKERS] WAL: O_DIRECT and multipage-writer

2005-01-27 Thread ITAGAKI Takahiro
Thanks for testing, Mark! I gave this a try with DBT-2, but got a core dump on our ia64 system. I hope this isn't a random thing, like I ran into previously. Maybe I'll try again, but postgres dumped core. Sorry, this seems to be my patch's bug. Which datatype did you compile with? LP64,

Re: [PATCHES] heap_modifytuple

2005-01-27 Thread Neil Conway
On Wed, 2004-09-08 at 16:31 -0400, Alvaro Herrera wrote: Here is a simple patch that changes heap_modifytuple to require a TupleDesc instead of a Relation (driven off a comment in the same function). Patch applied to HEAD. I went to the trouble of checking the call sites of heap_modifytuple()

Re: [PATCHES] Move get_grosysid() to utils/cache/lsyscache.c

2005-01-27 Thread Neil Conway
On Wed, 2004-12-29 at 11:36 -0500, Stephen Frost wrote: Small patch to move get_grosysid() from catalog/aclchk.c to utils/cache/lsyscache.c where it can be used by other things. Also cleans up both get_usesysid() and get_grosysid() a bit. Applied to HEAD. Thanks for the patch. -Neil

Re: [PATCHES] dbsize patch

2005-01-27 Thread Ed L.
On Thursday January 27 2005 2:12, Ed L. wrote: Well, it seems quite a bit more complicated than that to me, but I'm going to rework the patch so it drops into 7.3 as well and resubmit shortly. Too much trouble for now. Neil, if the latest patch is acceptable or useful for others as-is,

Re: [PATCHES] Continue transactions after errors in psql

2005-01-27 Thread Robert Treat
On Tuesday 25 January 2005 22:07, Greg Sabino Mullane wrote: Attached is a patch that takes advantage of savepoints to enable transactions to continue even after errors in psql. The name of it is \reseterror, and it is off by default. It's backwards compatible, and allows things like this to