Re: [PATCHES] WIP: pl/pgsql cleanup

2005-02-08 Thread Tom Lane
When you apply this, please put the remaining array-overflow checks before the overflow occurs, not after. See patches I just applied in the back branches. regards, tom lane ---(end of broadcast)--- TIP 4: Don't 'kill -9' th

Re: [PATCHES] WIP: pl/pgsql cleanup

2005-02-08 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > BTW, both of our fixes suffer from the deficiency that they will > actually reject input one variable too early: we disallow a SQL > statement with 1023 variables that we strictly speaking could store. Right. I thought about putting the overflow checks in

Re: [PATCHES] WIP: pl/pgsql cleanup

2005-02-08 Thread Neil Conway
On Tue, 2005-02-08 at 13:25 -0500, Tom Lane wrote: > When you apply this, please put the remaining array-overflow checks > before the overflow occurs, not after. Actually, my original fix _does_ check for the overflow before it occurs. ISTM both fixes are essentially identical, although yours may

[PATCHES] memory leak in ALTER TABLE

2005-02-08 Thread Neil Conway
ALTER TABLE ADD COLUMN exhibits a significant memory leak when adding a column with a default expression. In that situation, we need to rewrite the heap relation. To evaluate the new default expression, we use ExecEvalExpr(); however, this can allocate memory in the current memory context, and ATRe