[PATCHES] pg_ctl reference page

2005-02-20 Thread Magnus Hagander
It seems the pg_ctl reference page is missing the documentation for register/unregister for windows services. Attached is a patch taht adds this (be sure to verify the markup before any commit, though!) //Magnus pgctlref.patch Description: pgctlref.patch ---(end of

Re: [PATCHES] [BUGS] BUG #1466: #maintenace_work_mem = 16384

2005-02-20 Thread Magnus Hagander
The proposed test on Redirect_stderr looks pretty fishy too; for one thing it will almost certainly not be the right thing inside the stderr logger subprocess itself. Could you explain further what the issue is there? Inside the logger subprocess, Redirect_stderr is guaranteed true (since

[PATCHES] Change to -f in examples with input files

2005-02-20 Thread David Fetter
Folks, Please find enclosed a patch, per Dennis Björklund, that uses -f for input files rather than . This makes error messages, c. more expressive. Cheers, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/ phone: +1 510 893 6100 mobile: +1 415 235 3778 Remember to vote! Index:

Re: [PATCHES] Change to -f in examples with input files

2005-02-20 Thread Peter Eisentraut
David Fetter wrote: Please find enclosed a patch, per Dennis Björklund, that uses -f for input files rather than . This makes error messages, c. more expressive. To be portable, options must be before non-option arguments, so you need to rearrange the command-line arguments in the examples

[PATCHES] CSV multiline final fix

2005-02-20 Thread Andrew Dunstan
Well, in response to the huge number (0) of comments on my POC patch to fix this, I prepared the attached patch, which improves on my previous effort a bit (there was one obscure failure case which is now handled). Basically, all the required logic is in a new function CopyReadLineCSV() which

Re: [PATCHES] Patch for disaster recovery

2005-02-20 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: Tom Lane wrote: Not sure where this leads to, but it's not leading to an undocumented one-line hack in tqual.c, and definitely not *that* one-line hack. Sorry, here is the proper change I just applied: /* This is to be

Re: [PATCHES] Patch for disaster recovery

2005-02-20 Thread Bruce Momjian
Bruno Wolff III wrote: On Sun, Feb 20, 2005 at 09:43:11 -0500, Bruce Momjian pgman@candle.pha.pa.us wrote: We regularly have people on IRC who delete data and then want to recover it. By having the define it makes it easier for us to help them without them having to add actual C

Re: [PATCHES] Patch for disaster recovery

2005-02-20 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: Tom Lane wrote: Not sure where this leads to, but it's not leading to an undocumented one-line hack in tqual.c, and definitely not *that* one-line hack. Sorry, here is the proper change I just applied: /* This is to be used only for disaster

Re: [PATCHES] pg_ctl reference page

2005-02-20 Thread Neil Conway
On Sun, 2005-02-20 at 19:56 +0100, Magnus Hagander wrote: It seems the pg_ctl reference page is missing the documentation for register/unregister for windows services. Attached is a patch taht adds this (be sure to verify the markup before any commit, though!) Applied to HEAD and

Re: [PATCHES] Bibliography updates

2005-02-20 Thread Neil Conway
On Sun, 2005-02-20 at 11:18 -0700, Michael Fuhr wrote: The attached patch updates three books in the Bibliography to their most recent editions. Patch applied to HEAD. Thanks. -Neil ---(end of broadcast)--- TIP 8: explain analyze is your

Re: [PATCHES] WIP: pl/pgsql cleanup

2005-02-20 Thread Neil Conway
Tom Lane wrote: Still a few bricks shy of a load I fear [...] My apologies; thanks for the code review. regression=# create or replace function foo() returns int language plpgsql as $$ regression$# begin regression$# return ; regression$# end$$; CREATE FUNCTION regression=# select foo(); server