Re: [PATCHES] indxpath.c refactoring

2005-06-10 Thread Christopher Kings-Lynne
I don't see anyone very excited about r-tree these days; have you noticed that no one has stepped up to repair the known semantic errors? I wouldn't spend any time on it in the prover. That sort of thing is always self-fulfilling. If rtrees were fast, logged and rad, then more people would use

Re: [PATCHES] ON COMMIT and foreign keys

2005-06-10 Thread Bruce Momjian
FYI, this was already applied: 2005-01-26 22:17 tgl * doc/src/sgml/ref/truncate.sgml, src/backend/catalog/heap.c, src/backend/commands/tablecmds.c, src/backend/nodes/copyfuncs.c, src/backend/nodes/equalfuncs.c, src/backend/parser/g

Re: [PATCHES] PQmakeEmptyPGresult() will return NULL if allocation

2005-06-10 Thread Neil Conway
Volkan YAZICI wrote: PQmakeEmptyPGresult() will return NULL if malloc() fails for required PGresult struct. Good catch. However, there's not much point having PQmakeEmptyPGresult() return NULL on OOM if the various call sites of the function within libpq don't check the return value and handl

Re: [PATCHES] indxpath.c refactoring

2005-06-10 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > This simple refactoring patch moves all of the code associated with > Partial Index planning into a single file. Applied with some revisions - * I put the new predtest.c file into optimizer/util, which seemed a more plausible location than /path, and ga

Re: [PATCHES] Grammer Cleanup

2005-06-10 Thread Stephen Frost
* Bruce Momjian (pgman@candle.pha.pa.us) wrote: > I am removing this patch from the queue because without the "role" > feature I don't think it makes sense to rename the grammer tokens. Sure. I've rolled this patch into my role tree so these changes will be included when the CREATE ROLE, etc is i

Re: [PATCHES] bugfix: character-code conversion of MIC -> EUC_JP.

2005-06-10 Thread Devrim GUNDUZ
Hi Tatsuo, On Sat, 11 Jun 2005, Tatsuo Ishii wrote: If you agree that it's wrong, please do back-patch (at least 8.0, and personally I'd fix it back to 7.3). I will do it later (now is 2:00 AM and I need to go to bed...) This was an easy one: http://postgresql.gunduz.org/patches/ have th

Re: [PATCHES] bugfix: character-code conversion of MIC -> EUC_JP.

2005-06-10 Thread Tatsuo Ishii
> Tatsuo Ishii <[EMAIL PROTECTED]> writes: > >> In mic_to_euc_jp(), the call of mic2sjis() is a mistake. > >> It is necessary to call mic2euc_jp() here. > > > Thanks. The bug was there since 7.3. Apparently nobody uses > > MIC->EUC_JP conversion (This is not surprising since very few people > >

Re: [PATCHES] bugfix: character-code conversion of MIC -> EUC_JP.

2005-06-10 Thread Tom Lane
Tatsuo Ishii <[EMAIL PROTECTED]> writes: >> In mic_to_euc_jp(), the call of mic2sjis() is a mistake. >> It is necessary to call mic2euc_jp() here. > Thanks. The bug was there since 7.3. Apparently nobody uses > MIC->EUC_JP conversion (This is not surprising since very few people > use Mule Inter

Re: [PATCHES] bugfix: character-code conversion of MIC -> EUC_JP.

2005-06-10 Thread Tatsuo Ishii
> I found a bug in character-code conversion of MIC -> EUC_JP. > (MIC: Mule Internal Code) > > In mic_to_euc_jp(), the call of mic2sjis() is a mistake. > It is necessary to call mic2euc_jp() here. Thanks. The bug was there since 7.3. Apparently nobody uses MIC->EUC_JP conversion (This is not s

Re: [PATCHES] final light versions of Oracle compatibility (SQLSTATE,

2005-06-10 Thread Neil Conway
Tom Lane wrote: A nonterminal that is not intended to represent any real input, ever, is just plain weird. If you say so... PL/PgSQL already uses such a beast, though: the lno nonterminal, for example. Not at all. The right way to do this, I think, is for the mid-rule action to palloc the

Re: [PATCHES] psql: customizable readline history filename

2005-06-10 Thread Bruce Momjian
Andreas Seltenreich wrote: > Bruce Momjian schrob: > > > I noticed your documentation example had a space before :DBNAME --- I > > removed the space. > > This space is necessary for proper expansion of the parameter. The > \set-Command concatenates all its arguments after expansion: > > --8<

Re: [PATCHES] psql: customizable readline history filename

2005-06-10 Thread Andreas Seltenreich
Bruce Momjian schrob: > I noticed your documentation example had a space before :DBNAME --- I > removed the space. This space is necessary for proper expansion of the parameter. The \set-Command concatenates all its arguments after expansion: --8<---cut here---start--

Re: [PATCHES] Grammer Cleanup

2005-06-10 Thread Bruce Momjian
I am removing this patch from the queue because without the "role" feature I don't think it makes sense to rename the grammer tokens. --- Stephen Frost wrote: > * Tom Lane ([EMAIL PROTECTED]) wrote: > > Stephen Frost <[EMAIL

Re: [PATCHES] bugfix: character-code conversion of MIC -> EUC_JP.

2005-06-10 Thread Alvaro Herrera
On Fri, Jun 10, 2005 at 09:17:42PM +0900, Atsushi Ogawa wrote: > > I found a bug in character-code conversion of MIC -> EUC_JP. > (MIC: Mule Internal Code) So much for the "works flawlessly" argument :-( -- Alvaro Herrera () "Pensar que el espectro que vemos es ilusorio no lo despoja de espant

Re: [PATCHES] Implementing SELECT FOR UPDATE [NOWAIT]

2005-06-10 Thread Bruce Momjian
Uh, seems the code has drifted too much and now I can't apply this. Would you redo this against current CVS? Thanks. --- Hans-Juergen Schoenig wrote: > Folks, > > We have implemented SELECT FOR UPDATE NOWAIT for PostgreSQ

Re: [PATCHES] plperl: enable UTF-8 support

2005-06-10 Thread Bruce Momjian
It seems the plperl code has changed in the areas you are modifying. Would you update your patch against current CVS? Thanks. --- David Kamholz wrote: > Hello, > > Here's a patch I added against plperl, originally against

Re: [PATCHES] psql: customizable readline history filename

2005-06-10 Thread Bruce Momjian
Andreas Seltenreich wrote: > Hi, > > the following patch makes the filename used to store the readline > history customizable through a variable named HISTFILE, analogous to > psql's already implemented HISTCONTROL and HISTSIZE variables, and > bash's HISTFILE-Variable. > > The motivation was to

Re: [PATCHES] Server instrumentation

2005-06-10 Thread Dave Page
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Tom Lane > Sent: 10 June 2005 14:52 > To: Andreas Pflug > Cc: PostgreSQL-patches > Subject: Re: [PATCHES] Server instrumentation > > > > pg_file_stat() > > pg_file_length() > > pg_file_read() > >

Re: [PATCHES] Server instrumentation

2005-06-10 Thread Andreas Pflug
Tom Lane wrote: Andreas Pflug <[EMAIL PROTECTED]> writes: pg_terminate_backend() exposing kill -SIGTERM to the client The objections to this have not changed since last year; in fact they are stronger because we have at least one report of actual trouble with retail SIGTERMs. I'm not

Re: [PATCHES] Server instrumentation

2005-06-10 Thread Tom Lane
Andreas Pflug <[EMAIL PROTECTED]> writes: > pg_terminate_backend() > exposing kill -SIGTERM to the client The objections to this have not changed since last year; in fact they are stronger because we have at least one report of actual trouble with retail SIGTERMs. > pg_file_stat() > pg_file

[PATCHES] bugfix: character-code conversion of MIC -> EUC_JP.

2005-06-10 Thread Atsushi Ogawa
I found a bug in character-code conversion of MIC -> EUC_JP. (MIC: Mule Internal Code) In mic_to_euc_jp(), the call of mic2sjis() is a mistake. It is necessary to call mic2euc_jp() here. regards, --- Atsushi Ogawa mic_to_euc_jp.patch Description: Binary data -

[PATCHES] Server instrumentation

2005-06-10 Thread Andreas Pflug
This post includes "dbsize backend integration" and "Server instrumentation: pg_terminate_backend, pg_reload_conf" Server instrumentation functions included: pg_tablespace_size() pg_database_size() pg_relation_size() pg_size_pretty() well-known from contrib/dbsize, waiting in unapplied patch

[PATCHES] PQmakeEmptyPGresult() will return NULL if allocation fails

2005-06-10 Thread Volkan YAZICI
PQmakeEmptyPGresult() will return NULL if malloc() fails for required PGresult struct. Index: doc/src/sgml/libpq.sgml === RCS file: /projects/cvsroot/pgsql/doc/src/sgml/libpq.sgml,v retrieving revision 1.184 diff -u -c -r1.184 libpq.sg