Re: [PATCHES] indxpath.c refactoring

2005-06-11 Thread Christopher Kings-Lynne
I don't see anyone very excited about r-tree these days; have you noticed that no one has stepped up to repair the known semantic errors? I wouldn't spend any time on it in the prover. That sort of thing is always self-fulfilling. If rtrees were fast, logged and rad, then more people would

Re: [PATCHES] libpq: remove unused code

2005-06-11 Thread Neil Conway
Neil Conway wrote: This patch removes some old code from libpq that implements a URI-like syntax for database connection parameters. It has been inside an #ifdef NOT_USED block since 2001 or so and is marked as broken, so I don't think it is likely to be rehabilitated any time soon. Applied.

Re: [PATCHES] PQmakeEmptyPGresult() will return NULL if allocation

2005-06-11 Thread Neil Conway
Neil Conway wrote: Attached is a patch that implements this. This adds checking for most of the call sites of strdup(), malloc(), PQmakeEmptyPGresult(), pqResultAlloc(), and pqResultStrdup() in libpq. Barring any objections, I'll apply this to HEAD tomorrow. Applied. Thanks for the report.