Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-06-28 Thread Michael Paesold
Bruce Momjian wrote: Dave Page wrote: pg_relation_size(text) - Get relation size by name/schema.name pg_relation_size(oid)- Get relation size by OID pg_tablespace_size(name) - Get tablespace size by name pg_tablespace_size(oid) - Get tablespace size by OID pg_database_size(name) - Ge

Re: [PATCHES] Fwd: Re: [PERFORM] Performance analysis of plpgsql code

2005-06-28 Thread Bruce Momjian
Patch applied. Thanks. Your documentation changes can be viewed in five minutes using links on the developer's page, http://www.postgresql.org/developer/testing. --- Karl O. Pinc wrote: > > On 06/27/2005 10:03:06 PM, Ka

Re: [PATCHES] slight changes to gist.sgml

2005-06-28 Thread Bruce Momjian
Patch applied. Thanks. --- Victor Y. Yegorov wrote: > Improved words spacing. > > > -- > > Victor Y. Yegorov [ Attachment, skipping... ] > > ---(end of broadcast)--- >

Re: [PATCHES] Dbsize backend integration

2005-06-28 Thread Bruce Momjian
Dave Page wrote: > The attached patch integrates dbsize functions into the backend, as per > discussion on -hackers. The following functions are included: > > pg_relation_size(text) - Get relation size by name/schema.name > pg_relation_size(oid)- Get relation size by OID > pg_tablespace_size

Re: [PATCHES] [HACKERS] Problem with dblink regression test - FIXED

2005-06-28 Thread Jim C. Nasby
On Tue, Jun 28, 2005 at 02:28:11PM -0400, Andrew Dunstan wrote: > > > Jim C. Nasby wrote: > > >All the logs for the most recent run against HEAD are now at > >http://stats.distributed.net/~buildfarm/ > > > > > > > > > > A quick look shows that when you use --with-libraries=/foo/bar the > gene

Re: [PATCHES] COPY FROM performance improvements

2005-06-28 Thread Bruce Momjian
Luke Lonergan wrote: > Patch to update pgindent with new symbols and fix a bug in an awk section > (extra \\ in front of a ')'). Yea, that '\' wasn't needed. I applied the following patch to use // instead of "" for patterns, and removed the unneeded backslash. I will update the typedefs in a se

Re: [PATCHES] [PATCH] pgcrypto: pgp_encrypt (v2)

2005-06-28 Thread Marko Kreen
On Mon, Jun 27, 2005 at 09:08:05PM -0400, Bruce Momjian wrote: > Your patch has been added to the PostgreSQL unapplied patches list at: > > http://momjian.postgresql.org/cgi-bin/pgpatches > > It will be applied as soon as one of the PostgreSQL committers reviews > and approves it. Please u

Re: [PATCHES] [HACKERS] Proposed TODO: --encoding option for pg_dump

2005-06-28 Thread Michael Paesold
Alvaro Herrera wrote: On Tue, Jun 28, 2005 at 10:24:19PM +0200, Magnus Hagander wrote: I *think* that's easy enough to do in time for 8.1. Trivial patch attached. I hope it's enough :-) It passed my very quick testing... (Yup, I read the mails aobut PGCLIENTENCODING, but an option to pg_dump

Re: [PATCHES] [HACKERS] Proposed TODO: --encoding option for pg_dump

2005-06-28 Thread Magnus Hagander
> >> I *think* that's easy enough to do in time for 8.1. Trivial patch > >> attached. I hope it's enough :-) It passed my very quick testing... > >> > >> (Yup, I read the mails aobut PGCLIENTENCODING, but an option to > >> pg_dump is certainly easier) > > > > You forgot to document the long optio

Re: [PATCHES] [HACKERS] Proposed TODO: --encoding option for pg_dump

2005-06-28 Thread Magnus Hagander
> > I *think* that's easy enough to do in time for 8.1. Trivial patch > > attached. I hope it's enough :-) It passed my very quick testing... > > > > (Yup, I read the mails aobut PGCLIENTENCODING, but an option to > > pg_dump is certainly easier) > > You forgot to document the long option, I th

Re: [PATCHES] [HACKERS] Proposed TODO: --encoding option for pg_dump

2005-06-28 Thread Alvaro Herrera
On Tue, Jun 28, 2005 at 10:24:19PM +0200, Magnus Hagander wrote: > I *think* that's easy enough to do in time for 8.1. Trivial patch > attached. I hope it's enough :-) It passed my very quick testing... > > (Yup, I read the mails aobut PGCLIENTENCODING, but an option to pg_dump > is certainly eas

Re: [PATCHES] [HACKERS] Proposed TODO: --encoding option for pg_dump

2005-06-28 Thread Magnus Hagander
> There's no time to do this for 8.1, but I'd like to get it on > the books for > 8.2: > > The Problem: Occassionally a DBA needs to dump a database to a new > encoding. In instances where the current encoding, (or lack of an > encoding, like SQL_ASCII) is poorly supported on the target > d

[PATCHES] Fwd: Re: [PERFORM] Performance analysis of plpgsql code [EMAIL PROTECTED]

2005-06-28 Thread Karl O. Pinc
On 06/27/2005 10:03:06 PM, Karl O. Pinc wrote: On 06/27/2005 08:34:19 PM, Michael Fuhr wrote: On Tue, Jun 28, 2005 at 01:54:08AM +, Karl O. Pinc wrote: > On 06/27/2005 06:33:03 PM, Michael Fuhr wrote: > > >See timeofday(). > > That only gives you the time at the start of the transaction, >

Re: [PATCHES] [BUGS] BUG #1707: statistics collector starts with stats_start_collector

2005-06-28 Thread Tom Lane
Bruce Momjian writes: > My issue is that we usually don't have GUC variables that can be set > automatically. Why can't we have the stats collector try to start, and > just throw a server log message if it fails. I still say the code is not broken and does not require fixing. If someone doesn't

Re: [PATCHES] regexp_replace

2005-06-28 Thread Pavel Stehule
> > pg_catalog | replace | text | text, text, text > > > > I think that regexp_replace is a good name. It is easy to understand. > > regards, I prefere this name too Regards Pavel Stehule ---(end of broadcast)--- TIP 8: explain ana

Re: [PATCHES] regexp_replace

2005-06-28 Thread Andrew Dunstan
Atsushi Ogawa wrote: I think that regexp_replace is a good name. It is easy to understand. I'll go with the flow. cheers andrew ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [PATCHES] regexp_replace

2005-06-28 Thread Atsushi Ogawa
Bruce Momjian wrote: > Andrew Dunstan wrote: > > I'm very glad to see this. But is a nicer name possible? To perl > > programmers at least, "substitute" should make sense. > > What is the matter with replace? We already have replace: > > test=> \df replace >List of funct

Re: [PATCHES] COPY FROM performance improvements

2005-06-28 Thread Andrew Dunstan
Luke, Alon OK, I'm going to apply the patch to my copy and try to get my head around it. meanwhile: . we should not be describing things as "old" or "new". The person reading the code might have no knowledge of the history, and should not need to. . we should not have "slow" and "fast" eith

[PATCHES] per user/database connections limit again

2005-06-28 Thread Petr Jelinek
Hi, I attached second try of per-database and per-user connection limit for your review. This time I am using information stored in ProcArray to get number of connections - I modified PGPROC struct to also include userid. Limits for user and database are stored in catalog tables. This apro

[PATCHES] Dbsize backend integration

2005-06-28 Thread Dave Page
The attached patch integrates dbsize functions into the backend, as per discussion on -hackers. The following functions are included: pg_relation_size(text) - Get relation size by name/schema.name pg_relation_size(oid)- Get relation size by OID pg_tablespace_size(name) - Get tablespace size

Re: [PATCHES] [BUGS] BUG #1707: statistics collector starts with stats_start_collector

2005-06-28 Thread Bruce Momjian
Tom Lane wrote: > Actually, this entire thread is based on a misconception: the "bug" > reporter was under the misimpression that the sum total of what the > collector does is described by the three suboptions, and so having > start_collector on without any of the suboptions on is a useless state.

Re: [PATCHES] Users/Groups -> Roles

2005-06-28 Thread Tom Lane
Stephen Frost <[EMAIL PROTECTED]> writes: > Attached please find files and patches associated with moving from the > User/Group system currently in place to Roles, as discussed > previously. I have cleaned this up a bit and committed it. I normally wouldn't commit an incomplete patch, but t