Re: [PATCHES] [PATCH] pgcrypto: pgp_encrypt (v2)

2005-07-04 Thread Neil Conway
Marko Kreen wrote: Please use following updated patch instead. It implements utf8 conversion, fixes couple of bugs and has many code and comment cleanups. The regression tests don't pass on my box. With the default Makefile, there are a lot of errors WRT "no strong random source". After editi

Re: [PATCHES] User's exception plpgsql

2005-07-04 Thread Neil Conway
Pavel Stehule wrote: Per small recent discussion I corrected patch user's exception. I'll review and apply this in the next day or so. Next ToDo (needs discussion): + Optional message in raise stmt for user's or system exception raise exception division_by_zero; + Possibility rethr

Re: [PATCHES] PATCH to allow concurrent VACUUMs to not lock each

2005-07-04 Thread Hannu Krosing
On P, 2005-07-03 at 12:19 -0400, Tom Lane wrote: > Hannu Krosing <[EMAIL PROTECTED]> writes: > > Ok, this is a new version of the vacuum patch with the following changes > > following some suggestions in this thread. > > The more I look at this, the uglier it looks ... and I still haven't > seen a

[PATCHES] silence GCC4 warning

2005-07-04 Thread Neil Conway
This patch silences a GCC 4.0 warning about a potentially-uninitialized variable in pl_comp.c, and makes some minor associated cleanups. Barring any objections I'll apply this to HEAD tomorrow. -Neil Index: src/pl/plpgsql/src/pl_comp.c ===

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-07-04 Thread Dave Page
> -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED] > Sent: 03 July 2005 17:10 > To: Dawid Kuroczko > Cc: Andreas Pflug; Dave Page; Bruce Momjian; > PostgreSQL-patches; PostgreSQL-development > Subject: Re: [HACKERS] [PATCHES] Dbsize backend integration > > Dawid Kuroczko

Re: [PATCHES] contrib/pgcrypto patch for OpenSSL 0.9.8

2005-07-04 Thread Marko Kreen
On Mon, Jul 04, 2005 at 12:22:03PM +1000, Neil Conway wrote: > Bruce Momjian wrote: > >Patch applied. Thanks. > > Should either or both of these patches be applied to back branches? That would be a good idea. -- marko ---(end of broadcast)--- T

Re: [PATCHES] Implement support for TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL

2005-07-04 Thread Oliver Jowett
Bruce Momjian wrote: > Is this patch being worked on? Here's an updated version. It compiles and appears to work as expected under Linux (supports TCP_KEEPIDLE etc) and Solaris 9 (no support). Main changes: - removed the tcp_keepalives GUC, SO_KEEPALIVE is now always on (as in current CVS) - {ge

Re: [PATCHES] [PATCH] pgcrypto: pgp_encrypt (v2)

2005-07-04 Thread Marko Kreen
On Mon, Jul 04, 2005 at 04:59:58PM +1000, Neil Conway wrote: > Marko Kreen wrote: > >Please use following updated patch instead. > > > >It implements utf8 conversion, fixes couple of bugs and has > >many code and comment cleanups. > > The regression tests don't pass on my box. With the default Mak

Re: [PATCHES] PATCH to allow concurrent VACUUMs to not lock each

2005-07-04 Thread Hannu Krosing
On E, 2005-07-04 at 10:24 +0300, Hannu Krosing wrote: > On P, 2005-07-03 at 12:19 -0400, Tom Lane wrote: > > Hannu Krosing <[EMAIL PROTECTED]> writes: > > > Ok, this is a new version of the vacuum patch with the following changes > > > following some suggestions in this thread. > > > > The more I

Re: [PATCHES] per user/database connections limit again

2005-07-04 Thread Petr Jelinek
Alvaro Herrera wrote: I was wondering if there was some way to defer the user check till a later time, when the pg_authid relation could be checked? Not sure if that's a good idea, but it may help reduce the impact of the change, and thus chances that it'd be rejected. Well It can, but it wo

Re: [PATCHES] [HACKERS] HEAD doesn't cope with libraries in non-default

2005-07-04 Thread Andrew Dunstan
Bruce Momjian said: > Tom Lane wrote: >> Bruce Momjian writes: >> > Tom Lane wrote: >> >> It appears that somebody has changed things so that the -L switches >> >> appear after the -l switches (ie, too late). I'm too tired to >> >> investigate now, but my money is on Autoconf 2.59 being the probl

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-07-04 Thread Tom Lane
"Dave Page" writes: > Aside from the fact that's a change to the API that we had settled on, > it doesn't solve the actual problem of needing a suitable name for a > function that returns the size of a table /or/ index. pg_relation_size() > or pg_table_size() can't be used for precisely the reason

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-07-04 Thread Bruce Momjian
Tom Lane wrote: > "Dave Page" writes: > > Aside from the fact that's a change to the API that we had settled on, > > it doesn't solve the actual problem of needing a suitable name for a > > function that returns the size of a table /or/ index. pg_relation_size() > > or pg_table_size() can't be use

Re: [PATCHES] User's exception plpgsql

2005-07-04 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Pavel Stehule wrote: >> Per small recent discussion I corrected patch user's exception. > I'll review and apply this in the next day or so. Have we got a consensus yet on the behavior? There seemed to be no meeting of the minds at all the last time I pai

Re: [PATCHES] [BUGS] BUG #1749: date_trunc('week', ...) is incorrect for some

2005-07-04 Thread Bruce Momjian
Nick Johnson wrote: > > The following bug has been logged online: > > Bug reference: 1749 > Logged by: Nick Johnson > Email address: [EMAIL PROTECTED] > PostgreSQL version: 8.0.3 > Operating system: FreeBSD > Description:date_trunc('week', ...) is incorrect for some d

Re: [PATCHES] silence GCC4 warning

2005-07-04 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > This patch silences a GCC 4.0 warning about a potentially-uninitialized > variable in pl_comp.c, AFAICT, gcc4's default behavior is to warn about int foo; somefunc(&foo); which unfortunately is a very common usage that I'm not real

Re: [PATCHES] contrib/pgcrypto patch for OpenSSL 0.9.8

2005-07-04 Thread Marko Kreen
On Mon, Jul 04, 2005 at 10:31:21AM -0400, Bruce Momjian wrote: > OK, I have applied the last two diffs for pgcrypto includes to 8.0.X, > attached. > *** contrib/pgcrypto/openssl.c12 Mar 2005 06:54:31 - 1.13.4.1 > --- contrib/pgcrypto/openssl.c4 Jul 2005 14:30:12 - > **

Re: [PATCHES] silence GCC4 warning

2005-07-04 Thread Peter Eisentraut
Tom Lane wrote: > AFAICT, gcc4's default behavior is to warn about > > int foo; > > somefunc(&foo); A simple test shows that this is not the case, even with lots of -W options. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broad

Re: [PATCHES] contrib/pgcrypto patch for OpenSSL 0.9.8

2005-07-04 Thread Bruce Momjian
Marko Kreen wrote: > On Mon, Jul 04, 2005 at 10:31:21AM -0400, Bruce Momjian wrote: > > OK, I have applied the last two diffs for pgcrypto includes to 8.0.X, > > attached. > > > *** contrib/pgcrypto/openssl.c 12 Mar 2005 06:54:31 - 1.13.4.1 > > --- contrib/pgcrypto/openssl.c 4 J

Re: [PATCHES] contrib/pgcrypto patch for OpenSSL 0.9.8

2005-07-04 Thread Bruce Momjian
Marko Kreen wrote: > On Mon, Jul 04, 2005 at 12:22:03PM +1000, Neil Conway wrote: > > Bruce Momjian wrote: > > >Patch applied. Thanks. > > > > Should either or both of these patches be applied to back branches? > > That would be a good idea. OK, I have applied the last two diffs for pgcrypto in

Re: [PATCHES] Disable page writes when fsync off, add GUC

2005-07-04 Thread Stephen Frost
* Bruce Momjian (pgman@candle.pha.pa.us) wrote: > This patch disables page writes to WAL when fsync is off, because with > no fsync guarantee, the page write recovery isn't useful. This doesn't seem quite right to me. What happens with PITR? And Postgres crashes? While many people seriously dis

Re: [PATCHES] enable/disable trigger (Re: Fwd: [HACKERS] Open items)

2005-07-04 Thread Bruce Momjian
I am not sure what to do with this patch. It is missing dump capability, there is no clause to disable all triggers on a table, and it uses a table owner check when a super user check is required (because of referential integrity). Satoshi, are you still working on it? If not does someone else

Re: [PATCHES] User's exception plpgsql

2005-07-04 Thread Pavel Stehule
On Mon, 4 Jul 2005, Tom Lane wrote: > Neil Conway <[EMAIL PROTECTED]> writes: > > Pavel Stehule wrote: > >> Per small recent discussion I corrected patch user's exception. > > > I'll review and apply this in the next day or so. > > Have we got a consensus yet on the behavior? There seemed to be

Re: [PATCHES] Disable page writes when fsync off, add GUC

2005-07-04 Thread Peter Eisentraut
Bruce Momjian wrote: > This patch disables page writes to WAL when fsync is off, because > with no fsync guarantee, the page write recovery isn't useful. > > This also adds a full_page_writes GUC to turn off page writes to WAL. > Some people might not want full_page_writes, but still might want > f

Re: [PATCHES] Disable page writes when fsync off, add GUC

2005-07-04 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian wrote: > > This patch disables page writes to WAL when fsync is off, because > > with no fsync guarantee, the page write recovery isn't useful. > > > > This also adds a full_page_writes GUC to turn off page writes to WAL. > > Some people might not want full_p

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-07-04 Thread Dave Page
> -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED] > Sent: 04 July 2005 14:54 > To: Dave Page > Cc: Dawid Kuroczko; Andreas Pflug; Bruce Momjian; > PostgreSQL-patches; PostgreSQL-development > Subject: Re: [HACKERS] [PATCHES] Dbsize backend integration > > "Dave Page" w

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-07-04 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > "Dave Page" writes: > > > Aside from the fact that's a change to the API that we had settled on, > > > it doesn't solve the actual problem of needing a suitable name for a > > > function that returns the size of a table /or/ index. pg_relation_size() > >

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-07-04 Thread Robert Treat
On Monday 04 July 2005 10:11, Dave Page wrote: > > -Original Message- > > From: Tom Lane [mailto:[EMAIL PROTECTED] > > Sent: 04 July 2005 14:54 > > To: Dave Page > > Cc: Dawid Kuroczko; Andreas Pflug; Bruce Momjian; > > PostgreSQL-patches; PostgreSQL-development > > Subject: Re: [HACKERS] [

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-07-04 Thread Bruce Momjian
Robert Treat wrote: > Actually I'd agree with Tom, pg_dbfile_size is ugly, and suggest to me I > could > use a filename as an argument. ISTM that if we think that functions like > pg_database_size and pg_tablespace_size all make sense, the natural extension > would be functions called pg_index

[PATCHES] Column-level triggers

2005-07-04 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I did not have the time nor the experience to get as far as I hoped in the "column-level triggers" item, but attached is what I have done so far. Look for XXXCT for areas that still need work. Spent a lot of time trying to get gram.y to do what I wa

[PATCHES] Fix zic compile

2005-07-04 Thread Bruce Momjian
Seems the new platform-portable zic doesn't use libpgport anymore, and the pg_fprintf() calls are causing my compile to fail because my platform uses those pgport functions. I have applied the following patch to fix this. -- Bruce Momjian| http://candle.pha.pa.us pgm

Re: [PATCHES] replace_text() improvement

2005-07-04 Thread Bruce Momjian
Patch applied. Thanks. --- Atsushi Ogawa wrote: > > I made the patch that improved the performance of replace_text(). > The content of the patch is as follows: > > (1)Create shortcut when subtext was not found. > > (2)S

Re: [PATCHES] [INTERFACES] libecpg (8.0 and CVS) hits a gcc bug on powerpc

2005-07-04 Thread Bruce Momjian
Patch applied. Thanks. --- Christof Petig wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Michael Meskes schrieb: > > Patch committed. Thanks. > > I have to admit that I got the case of the preprocessor symb

Re: [PATCHES] Python setof patch

2005-07-04 Thread Bruce Momjian
Patch applied. Thanks. --- Gerrit van Dyk wrote: > Hi, > > This patch allows the PL/Python module to do (SRF) functions. > > The patch was taken from the CVS version. > > I have modified the plpython.c file and have add

Re: [PATCHES] Bitmap index AM

2005-07-04 Thread Victor Yegorov
I've managed to fix all bugs I've met so far. Attached is an updated patch. Comments: o README should be updated to reflect the changes I've done recently; o I'm still haven't tested ammarkpos and amrestrpos functions --- planner is choosing Nested Loop all the time and my knowledge of query

Re: [PATCHES] silence GCC4 warning

2005-07-04 Thread Neil Conway
Peter Eisentraut wrote: A simple test shows that this is not the case, even with lots of -W options. Right -- AFAICS we only get the following warnings of this class with GCC 4.0 on current sources: % gcc --version gcc-4.0 (GCC) 4.0.1 20050701 (prerelease) (Debian 4.0.0-12) [...] % make -s c

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-07-04 Thread Dave Page
> -Original Message- > From: Robert Treat [mailto:[EMAIL PROTECTED] > Sent: 04 July 2005 18:21 > To: Dave Page > Cc: Tom Lane; Dawid Kuroczko; Andreas Pflug; Bruce Momjian; > PostgreSQL-patches; PostgreSQL-development > Subject: Re: [HACKERS] [PATCHES] Dbsize backend integration > >

Re: [HACKERS] [PATCHES] [PATCH] pgcrypto: pgp_encrypt v3

2005-07-04 Thread Neil Conway
Bruce Momjian wrote: Your patch has been added to the PostgreSQL unapplied patches list That is not the latest version of Marko's patch. But in any case, the patch is not yet ready for application: http://archives.postgresql.org/pgsql-patches/2005-07/msg00077.php -Neil

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-07-04 Thread Robert Treat
On Monday 04 July 2005 13:25, Bruce Momjian wrote: > Robert Treat wrote: > > Actually I'd agree with Tom, pg_dbfile_size is ugly, and suggest to me I > > could use a filename as an argument. ISTM that if we think that > > functions like pg_database_size and pg_tablespace_size all make sense, > > t

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-07-04 Thread Christopher Kings-Lynne
You are into the cycle we were in. We discussed pg_object size (too vague) and pg_index_size (needs pg_toast_size too, and maybe toast indexes; too many functions). Yeah, I read those discussions, and think you were better off then than you are now, which is why I went back to it somewhat.

Re: [PATCHES] Autovacuum integration patch

2005-07-04 Thread Matthew T. O'Connor
Alvaro Herrera wrote: On Thu, Jun 30, 2005 at 12:03:12AM -0400, Matthew T. O'Connor wrote: Alvaro Herrera wrote: Sorry, forgot to mention: - There are no docs I can help here as long as I don't have to have the docs done before July 1. You don't. Ok, so I'm not wr

Re: [PATCHES] Autovacuum integration patch

2005-07-04 Thread Matthew T. O'Connor
XID wraparound: The patch as submitted doesn't handle XID wraparound issues. The old contrib autovacuum would do an XID wraparound check as it's 1st operation upon connecting to a database. If XID wraparound was looks like it's going to be a problem soon, then the whole database would be vac

[PATCHES] INSERT ... RETURNING

2005-07-04 Thread omar
Hi there, Attached is a patch (by Gavin Sherry, fixed up to apply to 8.1 by me) that implements INSERT ... RETURNING functionality. It does work for the common case of RETURNING the value of a serial/sequence column, but gets confused when returning results out-of-order (CREATE TABLE x (a int, b

Re: [PATCHES] silence GCC4 warning

2005-07-04 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Peter Eisentraut wrote: >> A simple test shows that this is not the case, even with lots of -W >> options. > Right -- AFAICS we only get the following warnings of this class with > GCC 4.0 on current sources: Hmm ... my comments were based on experiment