Re: [PATCHES] patch: garbage error strings in libpq

2005-07-09 Thread jtv
Tom Lane wrote: That would answer the big question here, but where does it say that? I saw Neil's point that the sequence points before function calls apply for the nested calls as well as the outer one, but there is no ordering between those nested-call sequence points. It's all easy when

Re: [PATCHES] patch: garbage error strings in libpq

2005-07-09 Thread jtv
Tom Lane wrote: That would answer the big question here, but where does it say that? Also, if you really insist on an authoritative statement, try this text (from Annex D of the C99 draft standard, Formal model of sequence points): Thank you, that would answer the question. There is no

Re: [PATCHES] patch: garbage error strings in libpq

2005-07-09 Thread Neil Conway
[EMAIL PROTECTED] wrote: Thank you, that would answer the question. There is no also about it; it's exactly what I was asking all along. The conclusive answer for us would be in the C89 standard of course, where (at least in the draft that Neil quoted) I haven't been able to find anything like

Re: [PATCHES] patch: garbage error strings in libpq

2005-07-09 Thread Stephan Szabo
On Sat, 9 Jul 2005 [EMAIL PROTECTED] wrote: Tom Lane wrote: That would answer the big question here, but where does it say that? Also, if you really insist on an authoritative statement, try this text (from Annex D of the C99 draft standard, Formal model of sequence points): Thank

Re: [PATCHES] thousands comma numeric formatting in psql

2005-07-09 Thread Bruce Momjian
Eugen Nedelcu wrote: Hello, I have included my patch attached to this mail. I have made the changes to deal with locale settings from client environment. So now you can start psql like this: (export LC_ALL=ro_RO; psql -U user db) and have numeric formatting with '.' as thousands

Re: [PATCHES] [patch 2/2] Fortuna PRNG

2005-07-09 Thread Bruce Momjian
Patch applied. Thanks. --- Marko Kreen wrote: - Add Fortuna PRNG to pgcrypto. - Move openssl random provider to openssl.c and builtin provider to internal.c - Make px_random_bytes use Fortuna, instead of giving

Re: [PATCHES] [patch 1/2] Add implementation of SHA256/384/512

2005-07-09 Thread Bruce Momjian
Patch applied. Thanks. --- Marko Kreen wrote: This patch adds implementation of SHA2 to pgcrypto. New hashes: SHA256, SHA384, SHA512. Code from OpenBSD. -- Bruce Momjian|

Re: [PATCHES] pgp encrypt v4

2005-07-09 Thread Bruce Momjian
Patch applied. Thanks. --- Marko Kreen wrote: Here is v4 of PGP encrypt. This depends on previously sent Fortuna-patch, as it uses the px_add_entropy function. - New function: pgp_key_id() for finding key id's. -

Re: [PATCHES] PL/Python error checking

2005-07-09 Thread Bruce Momjian
Michael Fuhr wrote: This patch addresses the problem mentioned in the process crash when a plpython function returns unicode thread: http://archives.postgresql.org/pgsql-bugs/2005-06/msg00105.php In several places PL/Python was calling PyObject_Str() and then PyString_AsString() without

Re: [PATCHES] PL/Python error checking

2005-07-09 Thread Bruce Momjian
Patch applied. Thanks. --- Michael Fuhr wrote: This patch addresses the problem mentioned in the process crash when a plpython function returns unicode thread:

Re: [PATCHES] regexp_replace

2005-07-09 Thread Bruce Momjian
I have applied your patch, with slight adjustments in spacing and documentation. Patch applied. Thanks. --- Atsushi Ogawa wrote: I made the patch that implements regexp_replace again. The specification of this