Re: [PATCHES] User's exception plpgsql

2005-07-25 Thread Neil Conway
Tom Lane wrote: Those cases are for places where the spec defines similar cases under the error classes "SQL Routine Exception" and "External Routine Exception". You can blame me for having assumed that plpgsql didn't need to distinguish these cases. Well, in and of itself, I agree it is probab

Re: [PATCHES] User's exception plpgsql

2005-07-25 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Pavel Stehule wrote: >> can you show sample, please? > modifying_sql_data_not_permitted, null_value_not_allowed, > prohibited_sql_statement_attempted and reading_sql_data_not_permitted > are the examples I can see from scanning plerrcodes.h. If we had th

Re: [PATCHES] User's exception plpgsql

2005-07-25 Thread Neil Conway
Pavel Stehule wrote: can you show sample, please? modifying_sql_data_not_permitted, null_value_not_allowed, prohibited_sql_statement_attempted and reading_sql_data_not_permitted are the examples I can see from scanning plerrcodes.h. If we had this to do over again, I'm not sure I see the poi

Re: [PATCHES] [HACKERS] Autovacuum loose ends

2005-07-25 Thread Alvaro Herrera
On Thu, Jul 14, 2005 at 10:52:56AM -0400, Tom Lane wrote: > I've applied Alvaro's latest integrated-autovacuum patch. There are > still a number of loose ends to be dealt with before beta, though: Updated this patch: - The stat collector is modified so as to keep shared relations separate from

Re: [PATCHES] User's exception plpgsql

2005-07-25 Thread Pavel Stehule
hello, sorry, exception variables don't solve this problem too. But we can detect it in compile-time. I don't wont to complicate raise syntax. best regards Pavel ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] User's exception plpgsql

2005-07-25 Thread Pavel Stehule
On Tue, 26 Jul 2005, Neil Conway wrote: > Neil Conway wrote: > > Not at the moment. I believe we have agreed that it would be better to > > remove the concept of "exception variables" and just use strings, but I > > haven't implemented this yet. > > BTW, one minor annoyance I noticed: a builtin

Re: [PATCHES] Regression - GNUmakefile - pg_usleep

2005-07-25 Thread Tom Lane
"Rocco Altier" <[EMAIL PROTECTED]> writes: > You propose making it similar to libpq. By that do you mean breaking it > into 2 separate diretories - backend/libpq & interfaces/libpq - so that > we create the libraries pgport and pgport_srv from different directories > - possibly using the existing

[PATCHES] Interval->day docs and regression tests

2005-07-25 Thread Michael Glaesemann
Please find attached diffs for documentation and simple regression tests for the new interval->day changes. I added tests for justify_hours() and justify_days() to interval.sql, as they take interval input and produce interval output. If there's a more appropriate place for them, please let

Re: [PATCHES] User's exception plpgsql

2005-07-25 Thread Neil Conway
Neil Conway wrote: Not at the moment. I believe we have agreed that it would be better to remove the concept of "exception variables" and just use strings, but I haven't implemented this yet. BTW, one minor annoyance I noticed: a builtin condition name can actually map to multiple SQLSTATE va

Re: [HACKERS] [PATCHES] Patch to fix plpython on OS X

2005-07-25 Thread Jim C. Nasby
On Sun, Jul 24, 2005 at 10:55:08AM -0400, Tom Lane wrote: > Michael Fuhr <[EMAIL PROTECTED]> writes: > > A problem with this patch is that it assumes a version of Python > > based on the OS, which might clean up the current buildfarm but > > that isn't really correct. Is there a better way to hand

Re: [PATCHES] Regression - GNUmakefile - pg_usleep

2005-07-25 Thread Rocco Altier
I see what you are saying now. libpgport is not a shared library - because of AIX's funny linking, I had not noticed that before. You propose making it similar to libpq. By that do you mean breaking it into 2 separate diretories - backend/libpq & interfaces/libpq - so that we create the librarie

Re: [PATCHES] per user/database connections limit again

2005-07-25 Thread Bruce Momjian
Petr Jelinek wrote: > Bruce Momjian wrote: > > >The new syntax for this command is CREATE/ALTER DATABASE/USER: > > > >| MAX CONNECTIONS Iconst > > > >This adds 'max' as a keyword, though at a fairly unreserved level, I > >think. Should we use the syntax LIMIT CONNECTIONS so we don

Re: [PATCHES] per user/database connections limit again

2005-07-25 Thread Petr Jelinek
Bruce Momjian wrote: The new syntax for this command is CREATE/ALTER DATABASE/USER: | MAX CONNECTIONS Iconst This adds 'max' as a keyword, though at a fairly unreserved level, I think. Should we use the syntax LIMIT CONNECTIONS so we don't have to add MAX as a keyword at all?

Re: [PATCHES] psql patch for displaying the username when asking password

2005-07-25 Thread Bruce Momjian
Patch adjusted slightly, attached, and applied. Thanks. --- Adrian Maier wrote: > On 6/30/05, Peter Eisentraut <[EMAIL PROTECTED]> wrote: > > Am Donnerstag, 30. Juni 2005 09:34 schrieb Adrian Maier: > > > The attached patch

Re: [PATCHES] Proposed patch to remove .so pattern rules from platform Makefiles

2005-07-25 Thread Rocco Altier
The patch works on AIX with one small tweak to Makefile.shlib (attached). This is needed because of the clever trick with using % as name, and when its evaulated for the mkldexport. Also, it appears that the changes for regress/GNUmakefile are already applied. I am able to build everything and p

Re: [PATCHES] per user/database connections limit again

2005-07-25 Thread Tom Lane
Bruce Momjian writes: > The new syntax for this command is CREATE/ALTER DATABASE/USER: > | MAX CONNECTIONS Iconst > This adds 'max' as a keyword, though at a fairly unreserved level, I > think. Should we use the syntax LIMIT CONNECTIONS so we don't have to > add MAX as a keyword a

Re: [PATCHES] per user/database connections limit again

2005-07-25 Thread Bruce Momjian
The new syntax for this command is CREATE/ALTER DATABASE/USER: | MAX CONNECTIONS Iconst This adds 'max' as a keyword, though at a fairly unreserved level, I think. Should we use the syntax LIMIT CONNECTIONS so we don't have to add MAX as a keyword at all? --

Re: [PATCHES] [HACKERS] Autovacuum loose ends

2005-07-25 Thread Matthew T. O'Connor
Tom Lane wrote: "Matthew T. O'Connor" writes: I don't know either, but this brings up another question. Stats wraparound. We'll all be safely dead, for one thing ;-) At one update per nanosecond, it'd take approximately 300 years to wrap a 64-bit counter. Somehow I don't have a probl