Thanks for reviewing!
But the patch does not work on HEAD, because of the changes in BootStrapXLOG().
I send the patch with a fix for it.
Bruce Momjian wrote:
> If you are doing fsync(), I don't see how O_DIRECT
> makes any sense because O_DIRECT is writing to disk on every write, and
> then wh
Neil Conway <[EMAIL PROTECTED]> writes:
> Tom Lane wrote:
>> [ scratches head... ] Did this code change recently? It's a tad hard
>> to believe that such a thing could have gone unnoticed for long.
> Seems the problem was introduced here:
> http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bi
Tom Lane wrote:
I'd go with reverting it to using PQdb, myself.
Fair enough; reverted to using PQdb(), and applied to HEAD and
REL8_0_STABLE.
-Neil
---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster
Tom Lane wrote:
[ scratches head... ] Did this code change recently? It's a tad hard
to believe that such a thing could have gone unnoticed for long.
Seems the problem was introduced here:
http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_backup_db.c.diff?r1=1.58;r2=1.59
(
Neil Conway <[EMAIL PROTECTED]> writes:
> If pg_dump fails to connect to Postgres, it attempts to print an error
> message in ConnectDatabase():
> ...
> But if no database is explicitly specified, `dbname' is NULL, and libc
> is entitled to crash if you pass a NULL pointer to it for a %s
> forma
If pg_dump fails to connect to Postgres, it attempts to print an error
message in ConnectDatabase():
/* check to see that the backend connection was successfully made */
if (PQstatus(AH->connection) == CONNECTION_BAD)
die_horribly(AH, modulename,
"connection to database \"%s
> -Original Message-
> From: Tom Lane [mailto:[EMAIL PROTECTED]
>
> "Rocco Altier" <[EMAIL PROTECTED]> writes:
> > Please disregard this patch. I have a ton of lib%.exp and
> > similar files created currently.
>
> Yeah, that was one of the reasons I called it ugly :-(. I
> had put in
"Rocco Altier" <[EMAIL PROTECTED]> writes:
> Please disregard this patch. I have a ton of lib%.exp and similar files
> created currently.
Yeah, that was one of the reasons I called it ugly :-(. I had put in an
"rm" step to get rid of lib%.so, you could probably fix the extraneous
.exp files simi
Please disregard this patch. I have a ton of lib%.exp and similar files
created currently.
I am working on a new patch to deal with the MODULES expansion
correctly.
Thanks,
-rocco
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf Of Rocco Alti
Alvaro Herrera wrote:
Two comments still apply:
- I haven't done anything yet w.r.t. the custom vacuum_delay nor sleep
scale factor.
I don't think we need the sleep scaling factor. Before we had vacuum
delay settings, it might have been useful as a means of throttling down
the impact of
10 matches
Mail list logo
