Re: [PATCHES] [HACKERS] Patching dblink.c to avoid warning about

2005-10-08 Thread Joe Conway
Bruce Momjian wrote: There was also a problem in that if two cursors were opened, the first close would close the transaction. I have fixed that code by changing the xact variable in to a counter that keeps track of the number of opened cursors and commits only when they are all closed. Both th

Re: [PATCHES] [HACKERS] Kerberos brokenness and oops question in 8.1beta2

2005-10-08 Thread Magnus Hagander
> The point is I'm having a hard time seeing what the actual > gain is in not changing it back. If the principal name > mismatches, we're going to get rejected anyway, so it's not > really a problem there. Even though the gain in changing it > back isn't all that big either, why should we intro

Re: [PATCHES] [HACKERS] Patching dblink.c to avoid warning about open

2005-10-08 Thread Bruce Momjian
Joe Conway wrote: > Bruce Momjian wrote: > > There was also a problem in that if two cursors were opened, the first > > close would close the transaction. I have fixed that code by changing > > the xact variable in to a counter that keeps track of the number of > > opened cursors and commits only

[PATCHES] [PATCH] Using pread instead of lseek (with analysis)

2005-10-08 Thread Martijn van Oosterhout
Hi, Below is a patch that tries to determine (for linux) if the pread is emulated or not (using an autoconf test), and if so use it instead of lseek. It doesn't remove all uses of lseek. For example, PostgreSQL uses lseek to find the end of the file when extending. So in a bulk load, there is one

[PATCHES] test, please ignore

2005-10-08 Thread Bruce Momjian
test email, please ignore. -- Bruce Momjian| http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073

Re: [PATCHES] [HACKERS] Patching dblink.c to avoid warning about open

2005-10-08 Thread Bruce Momjian
[ reposted] Tom Lane wrote: > Bruce Momjian writes: > > Well, as I said in the patch email: > > > The reported problem is that dblink_open/dblink_close() (for cursor > > reads) do a BEGIN/COMMIT regardless of the transaction state of the > > remote connection. There was code in dbl

Re: [PATCHES] [BUGS] BUG #1927: incorrect timestamp returned

2005-10-08 Thread Tom Lane
Bruce Momjian writes: > Tom Lane wrote: >> I think the solution is that timestamp_out needs to decide how many >> fractional digits it wants to display, and then round off the input >> accordingly, *before* it breaks the input down into y/m/d/h/m/s fields. >> This "60.00" business is happening bec

Re: [PATCHES] [HACKERS] Kerberos brokenness and oops question in 8.1beta2

2005-10-08 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Here's a patch that fixes the big problem and reverts the behaviour of > appl_version to be compatible with 8.0. Applied with trivial stylistic cleanups. BTW, the documentation seems a bit broken: krb_server_hostname (string) Sets the hostnam

Re: [PATCHES] [HACKERS] Kerberos brokenness and oops question in 8.1beta2

2005-10-08 Thread Magnus Hagander
> > Here's a patch that fixes the big problem and reverts the > behaviour of > > appl_version to be compatible with 8.0. > > Applied with trivial stylistic cleanups. > > BTW, the documentation seems a bit broken: > > krb_server_hostname (string) > > Sets the hostname part of the service

Re: [PATCHES] [HACKERS] Kerberos brokenness and oops question in 8.1beta2

2005-10-08 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: >> I suppose one of those last two should be "krb_srvname", but which? > Yes. > It should be krb_srvname/[EMAIL PROTECTED] OK, will fix. > Now that you mention it, krb_server_hostname should probably mentioned > in chapter 19.2.3 somewhere. Yeah, i

Re: [PATCHES] [PATCH] Using pread instead of lseek (with analysis)

2005-10-08 Thread Qingqing Zhou
"Martijn van Oosterhout" wrote > > Below is a patch that tries to determine (for linux) if the pread is > emulated or not (using an autoconf test), and if so use it instead of > lseek. Just FYI, this was proposed 2 years ago: http://archives.postgresql.org/pgsql-patches/2003-02/msg00197.php Th

Re: [PATCHES] [HACKERS] Kerberos brokenness and oops question in 8.1beta2

2005-10-08 Thread Tom Lane
BTW, it appears to me that this patch has also broken the claim in the manual that If [krb_server_hostname is] not set, the default is to allow any service principal matching an entry in the keytab. The reason that was true was that we passed a NULL "server" value to krb5_recvauth

Re: [PATCHES] [PATCH] Using pread instead of lseek (with analysis)

2005-10-08 Thread Tom Lane
Martijn van Oosterhout writes: > What follows is the detailed analysis of the change. My conclusion is > that on Linux at least where the syscall overhead is so low, it's not > worth the change for performance. It is cleaner code-wise IMHO. How is it cleaner code-wise to debug and maintain two #i

Re: [PATCHES] [PATCH] Using pread instead of lseek (with analysis)

2005-10-08 Thread Martijn van Oosterhout
On Sat, Oct 08, 2005 at 05:27:11PM -0400, Tom Lane wrote: > How is it cleaner code-wise to debug and maintain two #ifdef'd code > paths instead of one? (And when I say "debug", I mean "I don't believe > FileSeek still works". One reason that the patch seems unmaintainable > to me as-is is that it