Re: [PATCHES] [HACKERS] Patching dblink.c to avoid warning about

2005-10-16 Thread Joe Conway
Tom Lane wrote: I think it would be shorter and clearer to write remoteConn *remconn = NULL; ... remconn = rconn; ... remconn->newXactForCursor = TRUE; Also, you might be able to combine this variable with the existing rconn local variable and thus simpl

Re: [PATCHES] small typo

2005-10-16 Thread Bruce Momjian
Tom Lane wrote: > Euler Taveira de Oliveira <[EMAIL PROTECTED]> writes: > > This is a small typo in guc.c. > > The *real* problem with that variable description is that it's about a > factor of 5 too long. Will we be copying the entire contents of > config.sgml next? It is the same length as zer

Re: [PATCHES] small typo

2005-10-16 Thread Bruce Momjian
Applied. Thanks. --- Euler Taveira de Oliveira wrote: > Hi, > > This is a small typo in guc.c. > > > Euler Taveira de Oliveira > euler[at]yahoo_com_br > > > > > > > > > _

Re: [PATCHES] small typo

2005-10-16 Thread Tom Lane
Euler Taveira de Oliveira <[EMAIL PROTECTED]> writes: > This is a small typo in guc.c. The *real* problem with that variable description is that it's about a factor of 5 too long. Will we be copying the entire contents of config.sgml next? regards, tom lane -

[PATCHES] small typo

2005-10-16 Thread Euler Taveira de Oliveira
Hi, This is a small typo in guc.c. Euler Taveira de Oliveira euler[at]yahoo_com_br ___ Promoção Yahoo! Acesso Grátis: a cada hora navegada você acumula cupons e concorre a mais de 500 prêmios! Participe

Re: [PATCHES] [HACKERS] Patching dblink.c to avoid warning about open transaction

2005-10-16 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > Here is my counter-proposal to Bruce's dblink patch. Any comments? Minor coding suggestion: to me it seems messy to do > + int*openCursorCount = NULL; > + bool *newXactForCursor = NULL; > ! openCursorCount = &pconn->openC

Re: [PATCHES] [HACKERS] roundoff problem in time datatype

2005-10-16 Thread Bruce Momjian
Neil Conway wrote: > On Thu, 2005-13-10 at 22:54 -0400, Bruce Momjian wrote: > > I have written the attached patch which I think does what you suggested. > > I found all the places where we disallowed 24:00:00, and make it valid, > > including nabstime.c. > > Should this be added to the regression