Re: [PATCHES] A couple of proposed pgbench changes

2005-11-30 Thread Tatsuo Ishii
> Hi Tatsuo, > > Attached is a proposed patch that deals with a couple of pgbench issues. > > The change at line 490 updates doCustom's local variable "commands" > after selecting a new file (command sequence). I think that the > existing coding will cause the thing to use the first command of t

[PATCHES] Check for integer overflow in datetime functions

2005-11-30 Thread Michael Fuhr
Check integer conversion for overflow in datetime functions. Problem reported by Christopher Kings-Lynne: http://archives.postgresql.org/pgsql-hackers/2005-11/msg01385.php In one place (line 60 in the patch) the code sets errno to 0 when it should still be 0 after similar code a few lines above

Re: [PATCHES] Add missing const qualifier in ECPG

2005-11-30 Thread Michael Meskes
I just applied most of your patch to 8.0, 8.1 and HEAD. The only thing I didn't is: diff -c -r1.7 memory.c *** ecpglib/memory.c15 Oct 2005 02:49:47 - 1.7 --- ecpglib/memory.c16 Nov 2005 00:40:57 - *** *** 11,17 void ECPGfree(void *ptr) { ! free(ptr);