Jaime Casanova [EMAIL PROTECTED] writes:
On 2/10/06, Tom Lane [EMAIL PROTECTED] wrote:
What is the point of removing it? You cannot argue that saving
one if-test per tuple is a worthwhile speedup.
to clean code?
It's not saving any noticeable amount of code, and what it is doing
is removing
Patch applied. Thanks.
---
Simon Riggs wrote:
On Wed, 2005-12-07 at 17:40 +, Simon Riggs wrote:
On Wed, 2005-12-07 at 09:55 -0500, Tom Lane wrote:
Simon Riggs [EMAIL PROTECTED] writes:
We discussed an
Bruce Momjian pgman@candle.pha.pa.us writes:
Patch applied. Thanks.
Please revert. You cannot skip scanning indexes simply because there
was no heap activity. btree for instance does post-cleanup on the
next vacuum.
regards, tom lane
---(end
Tom Lane wrote:
[EMAIL PROTECTED] (Bruce Momjian) writes:
Log Message:
---
Allow VACUUM to complete faster by avoiding scanning the indexes when no
rows were removed from the heap by the VACUUM.
I didn't see that go by, and request it be reverted. This has
consequences that I
Simon Riggs [EMAIL PROTECTED] writes:
We discussed an optimization of VACUUM here
http://archives.postgresql.org/pgsql-hackers/2005-09/msg00046.php
that would allow VACUUM to complete faster by avoiding scanning the
indexes when no rows were removed from the heap by the VACUUM.
After looking
On Sat, 2006-02-11 at 12:04 -0500, Tom Lane wrote:
Bruce Momjian pgman@candle.pha.pa.us writes:
Patch applied. Thanks.
Please revert. You cannot skip scanning indexes simply because there
was no heap activity. btree for instance does post-cleanup on the
next vacuum.
The patch skips
Simon Riggs [EMAIL PROTECTED] writes:
I believe this is safe.
I won't insult your intelligence by pointing out how I know that you
didn't even test the patch against hash or gist.
The major problem with the patch is that it's incapable of producing
correct tuple-count stats for partial indexes,
Modified patch attached and applied. Thanks.
I adjusted based on Tom's comments to use a zero byte, and to clean up
the formatting. I didn't see any extra non-readline overhead, just
calls to functions that are no-ops in non-readline cases.
Patch applied. Thanks.
---
Joachim Wieland wrote:
On Wed, Dec 07, 2005 at 09:54:44PM +, Simon Riggs wrote:
On Mon, 2005-12-05 at 10:24 +0100, Joachim Wieland wrote:
o %Allow ALTER TABLE ... ALTER
On Fri, Feb 10, 2006 at 03:21:47PM -0500, Tom Lane wrote:
I think it would be a good idea to expect this patch to cause zero
change in psql output except in the cases where there are actually
control characters in the data. Otherwise there are likely to be
complaints. (I'm already unhappy at
Here's the patch as-applied. Note one major difference from your
original: the logic about whether an indexscan can be skipped is now
entirely local to the index AMs, rather than allowing VACUUM to make
assumptions that may not be warranted for particular AMs. For the
same reason, the AM is
Martijn van Oosterhout kleptog@svana.org writes:
As to the way the code is done, I prefer seperating out the test into a
variable because fitting it all on a single line is messy. OTOH, some
people discourage the use of ?: but I prefer it to a whole if
statement.
I don't object to that, but I
Tom Lane wrote:
[EMAIL PROTECTED] (Bruce Momjian) writes:
Log Message:
---
Allow ALTER TABLE ... ALTER CONSTRAINT ... RENAME
This patch appears seriously broken, in particular every routine I
looked at contained incorrect locking assumptions. Nor do I care
for using pg_depend
Patch applied. Thanks.
---
David Fetter wrote:
Folks,
Please find enclosed a patch that lets you use \c to connect
(optionally) to a new host and port without exiting psql. This
eliminates, IMHO, a surprise in that
On Sat, 11 Feb 2006, Bruce Momjian wrote:
Modified patch attached and applied. Thanks.
I adjusted based on Tom's comments to use a zero byte, and to clean up
the formatting. I didn't see any extra non-readline overhead, just
calls to functions that are no-ops in non-readline cases.
Bruce Momjian pgman@candle.pha.pa.us writes:
Tom Lane wrote:
This patch appears seriously broken, in particular every routine I
looked at contained incorrect locking assumptions. Nor do I care
for using pg_depend for the purposes it's being used for here.
OK, how do we proceed? Revert or
Sergey E. Koposov [EMAIL PROTECTED] writes:
But concerning to your zero byte change, it currently just broke
everything (as I thought, and that's why I didn't implemented it). The
problem with using zero byte is that it breaks all the readline functions
read_history and write_history. Those
Martijn van Oosterhout kleptog@svana.org writes:
Well, the attached patch removes the padding on the last column,
irrespective of the line. It will pad all the way to the end if the
cell is empty due to one of the earlier columns being multiline.
Applied with some cosmetic changes. I've
Oh, seems like a serious problem. I don't think all our encodings
avoid bytes after the first multibyte being non-control characters.
Some of the Chinese encodings come to mind.
Here is a comment from copy.c:
* Multi-byte encodings: all supported client-side encodings encode multi-byte
*
Patch applied. Thanks.
---
Mark Kirkwood wrote:
Mark Kirkwood wrote:
Bruce Momjian wrote:
Mark Kirkwood wrote:
Simon Riggs wrote:
I like this, but not because I want to read it myself, but because I
Patch applied. Thanks.
---
Simon Riggs wrote:
On Fri, 2005-12-16 at 15:56 -0500, Tom Lane wrote:
Simon Riggs [EMAIL PROTECTED] writes:
On Fri, 2005-12-16 at 13:59 -0500, Tom Lane wrote:
Would -1 work, or just
Patch applied. Thanks.
---
Simon Riggs wrote:
On Sat, 2005-12-17 at 20:03 +0100, Peter Eisentraut wrote:
Simon Riggs wrote:
Changes as discussed. singletransaction.patch attached.
I meant to ask, why is this
Volkan YAZICI wrote:
Here's a new try. This one touches to pg_dump side too - for v3
COPY functions usage instead of deprecated ones.
I'd be so appreciated if somebody can review attached patch.
I have updated the patch to match CVS (attached), but am seeing the
following regression
David Fetter wrote:
On Sun, Jan 15, 2006 at 09:55:39PM -0800, David Fetter wrote:
On Mon, Jan 16, 2006 at 12:13:11AM -0500, Neil Conway wrote:
On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote:
ifdef USE_PGXS
The change to $PostgreSQL$ is bogus (perhaps due to the
On Sat, 11 Feb 2006, Tom Lane wrote:
Sergey E. Koposov [EMAIL PROTECTED] writes:
But concerning to your zero byte change, it currently just broke
everything (as I thought, and that's why I didn't implemented it). The
problem with using zero byte is that it breaks all the readline
Patch applied. Thanks.
---
Euler Taveira de Oliveira wrote:
--- Euler Taveira de Oliveira [EMAIL PROTECTED] escreveu:
I have a patch like this. But this was for 7.4.x. I have to take a
look
at it.
The patch is
On Sat, Feb 11, 2006 at 07:50:22PM -0500, Tom Lane wrote:
On Sat, 2006-02-11 at 11:44 -0600, Jim C. Nasby wrote:
But speaking of documentation, it doesn't actually say what the default
is. Care update that, or should I formally submit a patch?
[1]
Modified to use a macro with value 0x01. Applied.
---
Bruce Momjian wrote:
Sergey E. Koposov wrote:
On Sat, 11 Feb 2006, Tom Lane wrote:
Sergey E. Koposov [EMAIL PROTECTED] writes:
But concerning to your zero
I finally figured out what the issue was with OS X blowing away shared
memory settings from /etc/sysctl.conf. I added a note to the 8.1 docs
already, and here's a patch against -HEAD.
--
Jim C. Nasby, Sr. Engineering Consultant [EMAIL PROTECTED]
Pervasive Software http://pervasive.com
Patch applied. Thanks.
---
Pavel Stehule wrote:
Hello
I cut controvers support for assign stmt. This patch is only
enhancing fore and fors stmts.
Regards
Pavel Stehule
I looked this over and I am unsure what this does for us that isn't
already accomplished using the wal_sync_method settings. See xlog.c for
a description of O_DIRECT and when it is used.
---
ITAGAKI Takahiro wrote:
Bruce
Patch applied. Thanks.
It is hard for us to keep the MSVC scripts current, but you have helped
in the past, so I assume you can continue to make sure they work in
future releases. Thanks.
---
Hiroshi Saito wrote:
Dear
Bruce Momjian pgman@candle.pha.pa.us writes:
Patch applied. Thanks.
Hmm, I was just in the middle of reviewing this one. Nothing like
tromping on each others' toes. Sorry for the confusion ...
regards, tom lane
---(end of
I saw your cleanup but saw nothing after that so I thought you wanted me
to continue. Sorry.
---
Tom Lane wrote:
Bruce Momjian pgman@candle.pha.pa.us writes:
Patch applied. Thanks.
Hmm, I was just in the middle of
Thanks for this Jim! We'll test it and report results.
- Luke
From: [EMAIL PROTECTED] on behalf of Jim C. Nasby
Sent: Sat 2/11/2006 9:26 PM
To: pgsql-patches@postgresql.org
Subject: [PATCHES] OS X shared memory documentation
I finally figured out what the
Jim C. Nasby [EMAIL PROTECTED] writes:
+In OS X 10.3 and later, you can simply place the settings into
+filename/etc/sysctl.conf/, with one caveat: all five of these
+parameters are linked together, so you must specify all five in
+filename/etc/sysctl.conf/. If
Modified patch attached and applied.
Rather than create the lists in psql, I used UNION SELECT 'KEYWORD' to
pass the keyword to the backend to be added to the query list.
This was already being done for schema names, and was easy and efficient
to add. My addition is even simpler because it
Patch applied. Thanks.
---
Kris Jurka wrote:
When performing a parallel build (make -j N) with ./configure
--enable-depend it often tries to create the .deps directory twice and
bails out when it already exists due
38 matches
Mail list logo
