Re: [PATCHES] schema-qualified SET CONSTRAINTS

2006-04-17 Thread Bruce Momjian
Based on discussion, it seems the idea of using search path seems accepted. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---

Re: [PATCHES] pg_ctl options checking

2006-04-17 Thread Peter Eisentraut
Simon Riggs wrote: > AFAICS -l -o on stop and -m on start could be ignored Right. > Mixing options between register and non-registration commands > definitely indicates user error. That I agree on. > So does mixing up -w and -W I don't follow that. These options are perfectly good for all mo

Re: [PATCHES] pg_ctl options checking

2006-04-17 Thread Simon Riggs
On Mon, 2006-04-17 at 15:12 -0400, Tom Lane wrote: > Peter Eisentraut <[EMAIL PROTECTED]> writes: > > Bruce Momjian wrote: > >> For a command as significant as pg_ctl, I can't see how making it > >> _convenient_ is a good argument. > > > Well, loss of convenience is one argument in opposition to t

Re: [PATCHES] Documentation patch: change a name in a grammar rule

2006-04-17 Thread Nicolas Barbier
2006/4/17, Peter Eisentraut <[EMAIL PROTECTED]>: > Nicolas Barbier wrote: > >> In for example set.sgml, just "name" is used for the exact same >> concept. I changed the patch so that "varname" is used, because >> "name" was already in use by this specific grammar. Maybe the usage >> of "var" makes

Re: [PATCHES] plpython improvements

2006-04-17 Thread Sven Suursoho
Hi, Mon, 17 Apr 2006 19:20:38 +0300, Bruce Momjian : > Hannu Krosing wrote: > >> > 1) named parameters additionally to args[] >> > 2) return composite-types from plpython as dictionary >> > 3) return result-set from plpython as list, iterator or generator >> > >> > Test script attached (patch-

Re: [PATCHES] pg_ctl options checking

2006-04-17 Thread Bruce Momjian
Patch rejected due to user complaints. --- Simon Riggs wrote: > pg_ctl: Minor patch to implement option checking to prevent silently > ignoring options and continuing with defaults. > > All of the following now cause errors

Re: [PATCHES] pg_ctl options checking

2006-04-17 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Bruce Momjian wrote: >> For a command as significant as pg_ctl, I can't see how making it >> _convenient_ is a good argument. > Well, loss of convenience is one argument in opposition to this change > but I don't see any argument in _favor_ of this c

Re: [PATCHES] pg_ctl options checking

2006-04-17 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian wrote: > > Peter Eisentraut wrote: > > > Simon Riggs wrote: > > > > pg_ctl -D test -U foo start > > > > pg_ctl -D test -W start > > > > pg_ctl -D test -w stop > > > > pg_ctl -D test -l fast stop > > > > etc.. (16 possible error combinations in total now check

Re: [PATCHES] pg_ctl options checking

2006-04-17 Thread Peter Eisentraut
Bruce Momjian wrote: > Peter Eisentraut wrote: > > Simon Riggs wrote: > > > pg_ctl -D test -U foo start > > > pg_ctl -D test -W start > > > pg_ctl -D test -w stop > > > pg_ctl -D test -l fast stop > > > etc.. (16 possible error combinations in total now checked) > > > > I object to making these thr

Re: [PATCHES] pg_ctl options checking

2006-04-17 Thread Bruce Momjian
Peter Eisentraut wrote: > Simon Riggs wrote: > > pg_ctl -D test -U foo start > > pg_ctl -D test -W start > > pg_ctl -D test -w stop > > pg_ctl -D test -l fast stop > > etc.. (16 possible error combinations in total now checked) > > I object to making these throw an error. It is very convenient to

Re: [PATCHES] Documentation patch: change a name in a grammar rule

2006-04-17 Thread Peter Eisentraut
Nicolas Barbier wrote: > In for example set.sgml, just "name" is used for the exact same > concept. I changed the patch so that "varname" is used, because > "name" was already in use by this specific grammar. Maybe the usage > of "var" makes it less clear indeed, for people that know that those > t

Re: [PATCHES] pg_ctl options checking

2006-04-17 Thread Peter Eisentraut
Simon Riggs wrote: > pg_ctl -D test -U foo start > pg_ctl -D test -W start > pg_ctl -D test -w stop > pg_ctl -D test -l fast stop > etc.. (16 possible error combinations in total now checked) I object to making these throw an error. It is very convenient to be able to alter the command line from

Re: [PATCHES] plpython improvements

2006-04-17 Thread Bruce Momjian
Hannu Krosing wrote: > ?hel kenal p?eval, L, 2006-04-15 kell 17:59, kirjutas Sven Suursoho: > > 1) named parameters additionally to args[] > > 2) return composite-types from plpython as dictionary > > 3) return result-set from plpython as list, iterator or generator > > > > Test script attached (p

Re: [PATCHES] plpython improvements

2006-04-17 Thread Hannu Krosing
Ühel kenal päeval, L, 2006-04-15 kell 17:59, kirjutas Sven Suursoho: > 1) named parameters additionally to args[] > 2) return composite-types from plpython as dictionary > 3) return result-set from plpython as list, iterator or generator > > Test script attached (patch-test.sql) but not integrated

Re: [PATCHES] Patch for bug #2073 (Can't drop sequence when created

2006-04-17 Thread Dhanaraj M - Sun Microsystems
Pl. look at the following code, which is taken from alter_table.sql (regression test) = mydb=# create table anothertab (atcol1 serial8, atcol2 boolean, constraint anothertab_chk check (atcol1 <= 3)); NOTICE: CREATE TABLE