Re: [PATCHES] pgstat: delayed write of stats file

2006-04-26 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Patch applied. Thanks. > > > Magnus Hagander wrote: > >> Per some earlier discussion, here is an attempt at implementing a > >> "delayed write" of the pgstats file, to decrease the write activity on > >> that file. > > This was not ready to be applied

Re: [PATCHES] pgstat: delayed write of stats file

2006-04-26 Thread Tom Lane
Bruce Momjian writes: > Patch applied. Thanks. > Magnus Hagander wrote: >> Per some earlier discussion, here is an attempt at implementing a >> "delayed write" of the pgstats file, to decrease the write activity on >> that file. This was not ready to be applied, was it? "An attempt" doesn't so

Re: [PATCHES] INS/UPD/DEL RETURNING for 8.2

2006-04-26 Thread Bruce Momjian
Jonah, where are we on this patch? Do you have a version ready for review? --- Jonah H. Harris wrote: > On 3/2/06, Jonah H. Harris <[EMAIL PROTECTED]> wrote: > > > > On 3/2/06, Tom Lane <[EMAIL PROTECTED]> wrote: > > > > >

Re: [PATCHES] be-secure.c patch

2006-04-26 Thread Bruce Momjian
Patch adjusted and applied. Thanks. I added documentation about SSL Certificate Revocation List (CRL) files. We throw a log message of "root.crl" does exist. Perhaps we should just silently say nothing, but that seems dangerous.

Re: [PATCHES] plpython improvements

2006-04-26 Thread Bruce Momjian
Patch applied. Thanks. --- Sven Suursoho wrote: > Hi, > > > Mon, 17 Apr 2006 19:20:38 +0300, Bruce Momjian : > > >> > Hannu Krosing wrote: > >> > > >> >> > 1) named parameters additionally to args[] > >> >> > 2) return

Re: [PATCHES] [PATCH] Fix declaration of PQgetssl

2006-04-26 Thread Bruce Momjian
Patch applied. Thanks. Because this is just doing: Change libpq's PQgetssl() to return a void*, rather than SSL *, so that applications don't need the SSL headers. I don't think we have to change the libpq major version number. -

Re: [PATCHES] [PATCH] Remove useless DH param code on client side

2006-04-26 Thread Bruce Momjian
Patch applied. Thanks. --- Martijn van Oosterhout wrote: -- Start of PGP signed section. > In the SSL code in libpq it does some processing with DH parameters: > > SSL_CTX_set_tmp_dh_callback() > > This function is marke

Re: [PATCHES] schema-qualified SET CONSTRAINTS

2006-04-26 Thread Bruce Momjian
Patch applied. Thanks. I also updated our SGML documentation: The current schema search path is used to find the first matching name if no schema name is specified. --- Kris Jurka wrote: > > The attached

Re: [PATCHES] pgstat: delayed write of stats file

2006-04-26 Thread Bruce Momjian
Patch applied. Thanks. --- Magnus Hagander wrote: > Per some earlier discussion, here is an attempt at implementing a > "delayed write" of the pgstats file, to decrease the write activity on > that file. > > It changes so

Re: [PATCHES] Show tablespace for databases with psql's \l+

2006-04-26 Thread Bruce Momjian
Patch applied. Thanks. --- Philip Yarra wrote: > On Thu, 30 Mar 2006 01:13 pm, Tom Lane wrote: > > Philip Yarra <[EMAIL PROTECTED]> writes: > > > Please let me know if this patch needs any changes for acceptance. I > > > w

Re: [PATCHES] [PERFORM] WAL logging of SELECT ... INTO command

2006-04-26 Thread Bruce Momjian
Backpatched to 8.0.X and 8.1.X. --- Kris Jurka wrote: > > > On Fri, 24 Mar 2006, Jim C. Nasby wrote: > > > On Wed, Mar 22, 2006 at 02:37:28PM -0500, Kris Jurka wrote: > >> > >> On Wed, 22 Mar 2006, Jim C. Nasby wrote: > >

Re: [PATCHES] Pg_buffercache tidy

2006-04-26 Thread Bruce Momjian
Patch applied. Thanks. --- Mark Kirkwood wrote: > This patch wraps the DDL in a BEGIN...COMMIT (as suggested by Jim for > pg_freespacemap a while ago). > > In addition I have amended the example queries to correctly proje

Re: [PATCHES] [HACKERS] Enhanced containment selectivity function

2006-04-26 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Tom Lane wrote: > >> I'm willing to work on this, but it doesn't look like you reverted the > >> prior patch yet? > > > Uh, I just moved the selectivity function over to /contrib/ltree, and > > moved what I needed, so it now works. You can continue wit

Re: [PATCHES] [HACKERS] Enhanced containment selectivity function

2006-04-26 Thread Tom Lane
Bruce Momjian writes: > Tom Lane wrote: >> I'm willing to work on this, but it doesn't look like you reverted the >> prior patch yet? > Uh, I just moved the selectivity function over to /contrib/ltree, and > moved what I needed, so it now works. You can continue with the plan > above, or I can.

Re: [PATCHES] [HACKERS] pg_freespacemap question

2006-04-26 Thread Bruce Momjian
Patch applied. Thanks. --- Mark Kirkwood wrote: > Mark Kirkwood wrote: > > Tom Lane wrote: > > > >> > >> I do notice a rather serious shortcoming of pg_freespacemap in its > >> current incarnation, which is that it *only*

Re: [PATCHES] [HACKERS] pg_freespacemap question

2006-04-26 Thread Bruce Momjian
Patch applied. Thanks. --- Mark Kirkwood wrote: > Tom Lane wrote: > > Mark Kirkwood <[EMAIL PROTECTED]> writes: > > > >>>Good points! I had not noticed this test case. Probably NULL is better > > > > > >>Would setting i

Re: [PATCHES] [HACKERS] Enhanced containment selectivity function

2006-04-26 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Tom Lane wrote: > >> What really needs to happen next is to think about which bits of > >> selfuncs.c should be exposed --- what's generally useful, and do we > >> think that it has an API clean/stable enough to expose? > > > Well, the ltree routine jus

Re: [PATCHES] [HACKERS] Enhanced containment selectivity function

2006-04-26 Thread Tom Lane
Bruce Momjian writes: > Tom Lane wrote: >> What really needs to happen next is to think about which bits of >> selfuncs.c should be exposed --- what's generally useful, and do we >> think that it has an API clean/stable enough to expose? > Well, the ltree routine just needs struct VariableStatDat

Re: [PATCHES] [HACKERS] Enhanced containment selectivity function

2006-04-26 Thread Bruce Momjian
Matteo Beccati wrote: > Bruce Momjian ha scritto: > > Your patch has been added to the PostgreSQL unapplied patches list at: > > > > http://momjian.postgresql.org/cgi-bin/pgpatches > > > > It will be applied as soon as one of the PostgreSQL committers reviews > > and approves it. > > Great.

Re: [PATCHES] [HACKERS] Enhanced containment selectivity function

2006-04-26 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > OK, reverted, but I saw it using contsel() so I figured we were allowing > > it, but I see contsel() is used by our "box", so ltree was just using > > something that was already there. Let me see if I can break out the new > > selectivity function into

Re: [PATCHES] [HACKERS] Enhanced containment selectivity function

2006-04-26 Thread Tom Lane
Bruce Momjian writes: > OK, reverted, but I saw it using contsel() so I figured we were allowing > it, but I see contsel() is used by our "box", so ltree was just using > something that was already there. Let me see if I can break out the new > selectivity function into /contrib. What really nee

Re: [PATCHES] [HACKERS] Enhanced containment selectivity function

2006-04-26 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Cleaned-up patch attached and applied. > > Please revert this patch. This has not been updated to satisfy the > previous agreement about how it should work. It is completely > inappropriate to be dropping code that's specific to one contrib module > i

Re: [PATCHES] [HACKERS] Enhanced containment selectivity function

2006-04-26 Thread Tom Lane
Bruce Momjian writes: > Cleaned-up patch attached and applied. Please revert this patch. This has not been updated to satisfy the previous agreement about how it should work. It is completely inappropriate to be dropping code that's specific to one contrib module into the core selfuncs.c file.

Re: [PATCHES] [HACKERS] Enhanced containment selectivity function

2006-04-26 Thread Bruce Momjian
Cleaned-up patch attached and applied. Catalog version updated in separate patch. --- Matteo Beccati wrote: > Hi, > > >>Moving it in contrib/ltree would be more difficult to me because it > >>depends on other functions d

[PATCHES] Patch for %Allow per-database permissions to be set via GRANT

2006-04-26 Thread Gevik Babakhani
This patch implements the TODO Item: "%Allow per-database permissions to be set via GRANT" Implementation details: 1. A privilege ACL_CONNECT has been added to the ACL bits 2. The ACL_CONNECT can be recognized by character "c" in pg_database/dataacl 3. The patch implements: GRANT CONNECTION ON

[PATCHES] Patch for BUG #2073: Can't drop sequence when created via SERIAL column

2006-04-26 Thread Dhanaraj M
Hi I send the appropriate patch for bug #2073. This fix disallows to change the default sequence. I ran the regression test and passed. The bug details are given below. I am awaiting to answer for any further clarifications. ===