Re: [PATCHES] minor fix of elevel in fd.c

2006-06-12 Thread Tom Lane
"Qingqing Zhou" <[EMAIL PROTECTED]> writes: > AllocateFile() and AllocateDir() should return the control to the caller > since we might want to upgrade the elevel. That is not what we do for upgrading errors. Use a critical section in a caller that doesn't want elog(ERROR).

Re: [PATCHES] Fix for Win32 division involving INT_MIN

2006-06-12 Thread Bruce Momjian
Patch applied. Backpatch to 8.1.X. --- Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian writes: > > > With no Win32 exception detection code in sight, I propose the following > > > patch to prevent server crashes

Re: [PATCHES] Bitmap index AM

2006-06-12 Thread Bruce Momjian
Victor Yegorov wrote: > Hi again. > > Here's an updated patch, that fixes several bugs and is synced with HEAD. Are you closer to submitting this patch for application? -- Bruce Momjian http://candle.pha.pa.us EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive,

Re: [PATCHES] [BUGS] Bug in window xp

2006-06-12 Thread Bruce Momjian
Patch applied. Thanks. --- Magnus Hagander wrote: > As a sidenote, I noticed I never followed through on an old discussion > about crashing. Right now, when a postgres backend crashes it pops up a > GUI window to let the us

Re: [PATCHES] fori stmt with by keyword was:(Re: [HACKERS] for statement,

2006-06-12 Thread Bruce Momjian
Patch applied. Thanks. --- Jaime Casanova wrote: > On 5/30/06, Bruce Momjian wrote: > > > > I went to test this patch and got the attached regression failures. > > Please repair and resubmit. Thanks. > > > > did it. sor

Re: [PATCHES] Bitmap index AM

2006-06-12 Thread Luke Lonergan
Bruce, We have a bitmap index AM in Bizgres (on PG 8.1.3) that is functional and achieves very worthwhile (10x+) performance and space objectives. It is a large patch, and introduces the access method along with modifying the appropriate executor nodes. The latter part was necessary because of t

Re: [PATCHES] ADD/DROP INHERITS

2006-06-12 Thread Greg Stark
Tom Lane <[EMAIL PROTECTED]> writes: > Greg Stark <[EMAIL PROTECTED]> writes: > > So should I set up a nested scan, essentially implementing a nested loop? or > > should I gather together all the children in a list? > > I'd use the predigested form of the constraints attached to the Relation > tu

[PATCHES] ADD/DROPS inherits

2006-06-12 Thread Greg Stark
I couldn't figure out how to make use of the predigested constraints in the relcache, so I continued on the tack I was on. I just stuf the entire HeapTuple in a list and decompiled the constraint source only if I find a constraint with a matching name. Points I'm uncertain about: . I throw an el

Re: [PATCHES] Non-transactional pg_class, try 2

2006-06-12 Thread Simon Riggs
On Sun, 2006-06-11 at 17:53 -0400, Alvaro Herrera wrote: > Here I repost the patch to implement non-transactional catalogs, the > first of which is pg_ntclass, intended to hold the non-transactional > info about pg_class (reltuples, relpages). Would it be possible to get a summary of what this new

Re: [PATCHES] Bitmap index AM

2006-06-12 Thread Bruce Momjian
Luke Lonergan wrote: > Bruce, > > We have a bitmap index AM in Bizgres (on PG 8.1.3) that is functional and > achieves very worthwhile (10x+) performance and space objectives. > > It is a large patch, and introduces the access method along with modifying > the appropriate executor nodes. The lat

Re: [PATCHES] minor fix of elevel in fd.c

2006-06-12 Thread Qingqing Zhou
On Mon, 12 Jun 2006, Tom Lane wrote: > "Qingqing Zhou" <[EMAIL PROTECTED]> writes: > > AllocateFile() and AllocateDir() should return the control to the caller > > since we might want to upgrade the elevel. > > That is not what we do for upgrading errors. Use a critical section in > a caller th

Re: [PATCHES] minor fix of elevel in fd.c

2006-06-12 Thread Tom Lane
Qingqing Zhou <[EMAIL PROTECTED]> writes: > On Mon, 12 Jun 2006, Tom Lane wrote: >> That is not what we do for upgrading errors. Use a critical section in >> a caller that doesn't want elog(ERROR). > True, but current code just check the return value of AllocateABC() then > decide to upgrade elev

Re: [PATCHES] minor fix of elevel in fd.c

2006-06-12 Thread Qingqing Zhou
"Tom Lane" <[EMAIL PROTECTED]> wrote > > > True, but current code just check the return value of AllocateABC() then > > decide to upgrade elevel to FATAL. > > Where? > In ValidatePgVersion(), FindMyDatabase(), etc -- though in practice this error can hardly happen anyway. Regards, Qingqing --

Re: [PATCHES] minor fix of elevel in fd.c

2006-06-12 Thread Tom Lane
"Qingqing Zhou" <[EMAIL PROTECTED]> writes: > "Tom Lane" <[EMAIL PROTECTED]> wrote >>> True, but current code just check the return value of AllocateABC() then >>> decide to upgrade elevel to FATAL. >> >> Where? > In ValidatePgVersion(), FindMyDatabase(), etc -- though in practice this > error ca