[PATCHES] Proposed patch for contrib/cube

2006-07-17 Thread Joshua Reich
Ok. So, the cube code looks very unmaintained (not to offend anyone), but it is all in V0 and I believe make installcheck fails out of the box due to new error message formats. I'm in the process of twisting the arm of another guy here to help me clean up the code - if that is ok with the power

Re: [PATCHES] Proposed patch for contrib/cube

2006-07-17 Thread Neil Conway
On Mon, 2006-07-17 at 17:55 -0400, Joshua Reich wrote: > Ok. So, the cube code looks very unmaintained (not to offend anyone), > but it is all in V0 and I believe make installcheck fails out of the box > due to new error message formats. It passes for me with CVS HEAD. The cube regression test i

Re: [PATCHES] Proposed patch for contrib/cube

2006-07-17 Thread Tom Lane
Joshua Reich <[EMAIL PROTECTED]> writes: >> if (PG_ARGISNULL(0) || PG_ARGISNULL(1)) >> { >> ereport(ERROR, >> (errcode(ERRCODE_ARRAY_ELEMENT_ERROR), >> errmsg("Cannot work with NULL arrays"))); >> } This is useless code if the function is declared STRICT, as C functions most often are. What you *

Re: [PATCHES] pg_regress in C

2006-07-17 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Per discussion at the conference: > In order to run the regression tests on Windows without msys, pg_regress > needs to be reimplemnted in C. This has some minor portability issues (macros with ... aren't portable, for instance) but I think it's some

Re: [HACKERS] [PATCHES] pg_regress in C

2006-07-17 Thread Joachim Wieland
On July 18, 1:06 am Tom Lane <[EMAIL PROTECTED]> wrote: > "Magnus Hagander" <[EMAIL PROTECTED]> writes: > > Per discussion at the conference: > > In order to run the regression tests on Windows without msys, > > pg_regress needs to be reimplemnted in C. > > This has some minor portability issues

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-17 Thread Joe Conway
Joe Conway wrote: . multiple values clauses for INSERT The best way might be to fabricate a selectStmt equiv to "SELECT UNION ALL SELECT ...", but that still feels like a hack. Here is a patch pursuant to my earlier post. It has the advantage of being fairly simple and noninvasive. The