Re: [PATCHES] pgstattuple extension for indexes

2006-08-13 Thread Alvaro Herrera
Satoshi Nagayasu wrote: > Bruce, > > Attached patch has been cleaned up, > and modified to be able to work with CVS HEAD. I was thinking, isn't it a lot cleaner to define the functions to use OUT parameters instead of having to define a custom type for each? Also, in 8.2 there is a uninstall SQL

Re: [HACKERS] [PATCHES] Forcing current WAL file to be archived

2006-08-13 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > This issue is closed, right? > > We've agreed we need two functions, but it's not done yet. Seems pretty > trivial though ... OK, that's what I was unclear about. -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDBhttp://www

Re: [PATCHES] Forcing current WAL file to be archived

2006-08-13 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > This issue is closed, right? We've agreed we need two functions, but it's not done yet. Seems pretty trivial though ... regards, tom lane ---(end of broadcast)--- TIP 1: if postin

Re: [PATCHES] Forcing current WAL file to be archived

2006-08-13 Thread Bruce Momjian
This issue is closed, right? --- Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > Something Hannu wrote has just reminded me that > > pg_current_xlog_location() returns the current Insert pointer rather > > than

Re: [PATCHES] [HACKERS] SO_SNDBUF size is small on win32?

2006-08-13 Thread Bruce Momjian
Yoshiyuki Asaba wrote: > Hi, > > From: Bruce Momjian <[EMAIL PROTECTED]> > Subject: Re: [PATCHES] [HACKERS] SO_SNDBUF size is small on win32? > Date: Fri, 11 Aug 2006 16:44:23 -0400 (EDT) > > > Based on this patch and comments, I have applied a patch that sets the > > buffer to 32k, and adds the

Re: [PATCHES] pgstattuple extension for indexes

2006-08-13 Thread Satoshi Nagayasu
Bruce, Attached patch has been cleaned up, and modified to be able to work with CVS HEAD. Thanks. Satoshi Nagayasu wrote: > Alvaro, > > Alvaro Herrera wrote: >> Huh, I bet it works with 8.1.4, but it doesn't work on CVS HEAD: >> >> /pgsql/source/00orig/contrib/pgstattuple/pgstatindex.c: In func

Re: [PATCHES] Patch for - Change FETCH/MOVE to use int8

2006-08-13 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I'm not sure that I see the point of this at all. ISTM the entire >> reason for using a cursor is that you're going to fetch the results >> in bite-size pieces. I don't see the current Postgres source code >> surviving into the era wh

Re: [PATCHES] Patch for - Change FETCH/MOVE to use int8

2006-08-13 Thread Bruce Momjian
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > I don't think this is the right approach. Maybe it would be reasonable > > to add another arm to the %union instead, not sure. The problem is the > > amount of ugly casts you have to use below. The scanner code seems to > > think t

Re: [PATCHES] [HACKERS] SO_SNDBUF size is small on win32?

2006-08-13 Thread Yoshiyuki Asaba
Hi, From: Bruce Momjian <[EMAIL PROTECTED]> Subject: Re: [PATCHES] [HACKERS] SO_SNDBUF size is small on win32? Date: Fri, 11 Aug 2006 16:44:23 -0400 (EDT) > Based on this patch and comments, I have applied a patch that sets the > buffer to 32k, and adds the URL in a comment. Is it backported to

Re: [PATCHES] Patch for - Change FETCH/MOVE to use int8

2006-08-13 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > I don't think this is the right approach. Maybe it would be reasonable > to add another arm to the %union instead, not sure. The problem is the > amount of ugly casts you have to use below. The scanner code seems to > think that a constant larger than

Re: [PATCHES] Patch for - Change FETCH/MOVE to use int8

2006-08-13 Thread Alvaro Herrera
Dhanaraj M wrote: I had a quick look: > *** > *** 209,215 > > /* Return command status if wanted */ > if (completionTag) > ! snprintf(completionTag, COMPLETION_TAG_BUFSIZE, "%s %ld", >stmt->ismove ? "MOVE" : "FETCH", >

Re: [PATCHES] [HACKERS] Custom variable class segmentation fault

2006-08-13 Thread Bruce Momjian
Tom Lane wrote: > Michael Fuhr <[EMAIL PROTECTED]> writes: > > The latest HEAD is segfaulting on startup if I have the following > > lines in postgresql.conf: > > > custom_variable_classes = 'plperl' > > plperl.use_strict = on > > Bruce, please re-revert that GUC patch and don't put it back in un

Re: [PATCHES] better support of out parameters in plperl

2006-08-13 Thread Bruce Momjian
Based on this analysis, and problems with differing regression results on different platforms, this attached patch has been reverted. --- Andrew Dunstan wrote: > > > I wrote: > > Pavel Stehule wrote: > >> Hello, > >> > >>

Re: [PATCHES] better support of out parameters in plperl

2006-08-13 Thread Andrew Dunstan
I wrote: Pavel Stehule wrote: Hello, I send two small patches. First does conversion from perl to postgresql array in OUT parameters. Second patch allow hash form output from procedures with one OUT argument. I will try to review these in the next 2 weeks unless someone beats me to it.

[PATCHES] Patch for - Change FETCH/MOVE to use int8

2006-08-13 Thread Dhanaraj M
This patch is for the following TODO item. SQL command: -/Change LIMIT/OFFSET and FETCH/MOVE to use int8 /Since the limit/offset patch is already applied, this patch is meant for Fetch/Move query. I have tested the patch and it works for int64 values. Please verify this. Thanks Dhanaraj / / **