Re: [PATCHES] Unable to post to -patches (was: Visual C++ build files)

2006-08-21 Thread Magnus Hagander
Another take on this. Dave convinced me that I had access to svr1, which it turns out I did, so I managed to check the logs myself. And I find: Aug 21 10:51:24 postgresql postfix/smtp[52021]: 3F45C9FB2BB: to=pgsql-patches-p [EMAIL PROTECTED], orig_to=pgsql-patches@postgresql.org, relay=mai

[PATCHES] Fix linking of OpenLDAP libraries

2006-08-21 Thread Albe Laurenz
I have realized that my modifications in configure.in and src/interfaces/libpq/Makefile to link libpq against OpenLDAP are buggy. Here is a proposed patch to fix it. I write this to pgsql-hackers too because I want to share the difficulty I'm facing - maybe somebody has a better idea. To handle

Re: [PATCHES] Updatable views

2006-08-21 Thread Bernd Helmle
--On Montag, August 21, 2006 02:07:41 -0400 Alvaro Herrera [EMAIL PROTECTED] wrote: Hi, This is the patch for updatable views I've been able to come up with. A nasty bug was just discovered in the upcoming Mammoth Replicator release so I'm not sure if I'm going to have time to work more

Re: [PATCHES] Updatable views

2006-08-21 Thread Alvaro Herrera
Bernd Helmle wrote: I'll try to complete the missing comments and to make some statements cleaner. Thanks. --On Montag, August 21, 2006 02:07:41 -0400 Alvaro Herrera [EMAIL PROTECTED] wrote: The new files are src/backend/rewrite/viewUpdate.c and src/include/rewrite/viewUpdate.h. The

Re: [PATCHES] Updatable views

2006-08-21 Thread Alvaro Herrera
Bernd Helmle wrote: Comments from Bernd and Jaime are especially welcome if I've broken something that used to work on their patch :-) I see that the current patch doesn't support subqueries in the WHERE-clause anymore. You can find one example in the attached SQL-script. Is there a

Re: [PATCHES] [PATCH] Provide 8-byte transaction IDs to user level

2006-08-21 Thread Tom Lane
Marko Kreen [EMAIL PROTECTED] writes: Following patch exports 8 byte txid and snapshot to user level allowing its use in regular SQL. It is based on Slony-I xxid module. It provides special 'snapshot' type for snapshot but uses regular int8 for transaction ID's. Per discussion, I've applied

Re: [HACKERS] [PATCHES] [PATCH] Provide 8-byte transaction IDs to

2006-08-21 Thread Marko Kreen
On 8/21/06, Tom Lane [EMAIL PROTECTED] wrote: Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: (I wouldn't do it like this though --- TransactionIdAdvance itself is the place to bump the secondary counter.) Agreed. I reconsidered after trying to do it that way --- although fixing

[PATCHES] psql 'none' as a HISTFILE special case

2006-08-21 Thread Martin Atukunda
If readline is used by psql, a history file is automatically used. This patch adds the special file name 'none', which if set as the HISTFILE parameter, will cause psql not to use the history file. - Martin - psql_allow_none_as_HISTFILE.diff Description: Binary data

Re: [PATCHES] psql 'none' as a HISTFILE special case

2006-08-21 Thread Neil Conway
On Mon, 2006-08-21 at 19:27 +0300, Martin Atukunda wrote: If readline is used by psql, a history file is automatically used. This patch adds the special file name 'none', which if set as the HISTFILE parameter, will cause psql not to use the history file. I think it would be cleaner to use a

Re: [PATCHES] psql 'none' as a HISTFILE special case

2006-08-21 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: On Mon, 2006-08-21 at 19:27 +0300, Martin Atukunda wrote: If readline is used by psql, a history file is automatically used. This patch adds the special file name 'none', which if set as the HISTFILE parameter, will cause psql not to use the history file.

Re: [PATCHES] psql 'none' as a HISTFILE special case

2006-08-21 Thread Bruce Momjian
Tom Lane wrote: Neil Conway [EMAIL PROTECTED] writes: On Mon, 2006-08-21 at 19:27 +0300, Martin Atukunda wrote: If readline is used by psql, a history file is automatically used. This patch adds the special file name 'none', which if set as the HISTFILE parameter, will cause psql not to

Re: [PATCHES] [HACKERS] proposal - plpgsql: execute using into

2006-08-21 Thread Bruce Momjian
Pavel Stehule wrote: There are some problems about replacing string values in the SQL string. Doesn't the Oracle implementation already imply a solution to that? I don't know. I didn't find any detail documentation about it. I don't know what Oracle exactly do. Oracle does use USING:

Re: [PATCHES] [HACKERS] BF Failure on Bandicoot

2006-08-21 Thread Magnus Hagander
Just guessing from the function name, but does this go away if you don't configure --with-ldap? If so it's presumably a portability issue in this recent patch: 2006-03-06 12:41 momjian * configure, configure.in, src/backend/libpq/auth.c, src/backend/libpq/hba.c,

Re: [PATCHES] [HACKERS] proposal - plpgsql: execute using into

2006-08-21 Thread Pavel Stehule
Hello, This task can be better solved. There are some problems with strings, but bigger problem is impossibility to pass nonscalar variables. What is questions? Does Oracle allow variables on nonparam positions? If not, then I see more elegant solution via preprocessed statements. Best

Re: [PATCHES] [HACKERS] BF Failure on Bandicoot

2006-08-21 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Attached is a patch that fixes this issue at least in my test machine (yes, I found one 2000 machine that was broken as well) Applied. Dave, would you re-enable the LDAP option on bandicoot so we can verify this fixes it?

Re: [PATCHES] [HACKERS] BF Failure on Bandicoot

2006-08-21 Thread Dave Page
-Original Message- From: Tom Lane [mailto:[EMAIL PROTECTED] Sent: 21 August 2006 20:24 To: pgsql-hackers@postgresql.org; Magnus Hagander Cc: Dave Page; pgsql-patches@postgresql.org Subject: Re: [PATCHES] [HACKERS] BF Failure on Bandicoot Magnus Hagander [EMAIL PROTECTED]

[PATCHES] Updated concurrent-index-build patch

2006-08-21 Thread Tom Lane
Attached is an updated version of Greg Stark's CREATE INDEX ... ONLINE patch. I have not gone through the new code in any detail yet, but this version applies cleanly to CVS HEAD and is updated for the CONCURRENTLY syntax that I think we agreed on. If anyone is eager to do some testing, please

Re: [PATCHES] [HACKERS] Unable to post to -patches (was: Visual C++ build files)

2006-08-21 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: a.hub.org[200.46.208.251], delay=1, status=sent (250 2.7.1 Ok, discarded, id=258 35-09 - BANNED: P=p003,L=1,M=multipart/mixed | P=p002,L=1/2,M=application/x-gzip ,T=gz,N=vcbuild.tar.gz | P=p...) Seems -patches is rejecting any mail with attached

[PATCHES] Use of backslash in tsearch2

2006-08-21 Thread Bruce Momjian
Bruce Momjian wrote: I backed out the patch, attached, and it has fixed the regression problem. What has me confused is that is looks like it is checking for ', then putting \, which doesn't make a lot of sense, but the regression output is corrected, so I just don't get it. Here is an

Re: [PATCHES] Use of backslash in tsearch2

2006-08-21 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: As part of the move to support standard-conforming strings and treat backslash literally, I reviewed the tsearch2 code and found two place that seemed to use \' rather than '', and generated the attached patch. I thought we had decided that that code

Re: [PATCHES] Use of backslash in tsearch2

2006-08-21 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: As part of the move to support standard-conforming strings and treat backslash literally, I reviewed the tsearch2 code and found two place that seemed to use \' rather than '', and generated the attached patch. I thought we had

Re: [PATCHES] Use of backslash in tsearch2

2006-08-21 Thread Bruce Momjian
Bruce Momjian wrote: Bruce Momjian wrote: I backed out the patch, attached, and it has fixed the regression problem. What has me confused is that is looks like it is checking for ', then putting \, which doesn't make a lot of sense, but the regression output is corrected, so I just

Re: [PATCHES] Contrib module to examine client certificate

2006-08-21 Thread Bruce Momjian
This seems like a nice /contrib module. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it.

Re: [PATCHES] pgstattuple extension for indexes

2006-08-21 Thread Bruce Momjian
BTIem is no longer in CVS HEAD, though it was in 8.1.X. Please update your patch for CVS HEAD. Thanks. --- Satoshi Nagayasu wrote: Hi all, Here is a patch to add pgstatindex functions to the pgstattuple module, which

Re: [PATCHES] pgstattuple extension for indexes

2006-08-21 Thread Satoshi Nagayasu
Bruce, Bruce Momjian wrote: BTIem is no longer in CVS HEAD, though it was in 8.1.X. Please update your patch for CVS HEAD. Thanks. I've posted CVS HEAD workable version on Aug.14. Please check it out. Thanks. -- NAGAYASU Satoshi [EMAIL PROTECTED] Phone: +81-3-3523-8122

Re: [PATCHES] pgstattuple extension for indexes

2006-08-21 Thread Bruce Momjian
Satoshi Nagayasu wrote: Bruce, Bruce Momjian wrote: BTIem is no longer in CVS HEAD, though it was in 8.1.X. Please update your patch for CVS HEAD. Thanks. I've posted CVS HEAD workable version on Aug.14. Please check it out. Thanks. OK, I found it, but it has no updates to

Re: [PATCHES] pgstattuple extension for indexes

2006-08-21 Thread Satoshi Nagayasu
Sorry, I'll write README (and uninstall.sql?) by tomorrow. Bruce Momjian wrote: Satoshi Nagayasu wrote: Bruce, Bruce Momjian wrote: BTIem is no longer in CVS HEAD, though it was in 8.1.X. Please update your patch for CVS HEAD. Thanks. I've posted CVS HEAD workable version on Aug.14.

Re: [PATCHES] pgstattuple extension for indexes

2006-08-21 Thread Bruce Momjian
Satoshi Nagayasu wrote: Sorry, I'll write README (and uninstall.sql?) by tomorrow. Thanks. Yea, you need to update the uninstall too. --- Bruce Momjian wrote: Satoshi Nagayasu wrote: Bruce, Bruce Momjian

Re: [PATCHES] SQL/XML publishing function experimental patch

2006-08-21 Thread Bruce Momjian
I am still waiting for some documentation on what XML support we have, and what we need. We can't decide on this patch until we have that. --- Nikolay Samokhvalov wrote: I'll prepare some classification of differend kinds

Re: [PATCHES] COPY view

2006-08-21 Thread Bruce Momjian
Jim C. Nasby wrote: On Wed, Jun 14, 2006 at 05:19:44PM -0400, Bruce Momjian wrote: Hans-Juergen Schoenig wrote: Bruce Momjian wrote: I don't see why views should be special. Tables clearly should be because we can open them directly. Ah, I didn't think of that.

Re: [PATCHES] COPY view

2006-08-21 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---

Re: [PATCHES] COPY view

2006-08-21 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: OK, based on this feedback, I am adding COPY VIEW to the patches queue. I think we have other things that demand our attention more than a half-baked feature. regards, tom lane ---(end of