Re: [HACKERS] [PATCHES] Bad bug in fopen() wrapper code

2006-10-02 Thread Magnus Hagander
Now, I still twist my head around the lines: if ((fd = _open_osfhandle((long) h, fileFlags O_APPEND)) 0 || (fileFlags (O_TEXT | O_BINARY) (_setmode(fd, fileFlags (O_TEXT | O_BINARY)) 0))) Without having studied it closely, it might also highlight a bug on failure of the

Re: [PATCHES] [HACKERS] Incrementally Updated Backup

2006-10-02 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---

Re: [PATCHES] minor editorial of tsearch2 readme

2006-10-02 Thread Bruce Momjian
Patch applied. Thanks. --- Robert Treat wrote: just fixes up a couple of minor points, -- Robert Treat Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL [ Attachment, skipping... ]

Re: [PATCHES] [HACKERS] Incrementally Updated Backup

2006-10-02 Thread Bruce Momjian
Documentation patch applied. Thanks. Your documentation changes can be viewed in five minutes using links on the developer's page, http://www.postgresql.org/developer/testing. --- Simon Riggs wrote: On Tue,

[PATCHES] Small documentation patch

2006-10-02 Thread Guillaume Lelarge
Hi all, This patch fixes a small typo in information_schema.sgml. Regards. -- Guillaume. !-- http://abs.traduc.org/ http://lfs.traduc.org/ http://traduc.postgresqlfr.org/ -- ? information_schema.patch Index: doc/src/sgml/information_schema.sgml

Re: [PATCHES] [HACKERS] Patch: Tie stats options to autovacuum in

2006-10-02 Thread Bruce Momjian
Modified wording patch applied. Thanks. --- David Wheeler wrote: PostgreSQLers, I just ran into an issue where a client thought that autovacuum was running but it wasn't. This is because it's not fatal when

Re: [PATCHES] [HACKERS] Patch: Tie stats options to autovacuum in postgresql.conf

2006-10-02 Thread David E. Wheeler
On Oct 2, 2006, at 17:40, Bruce Momjian wrote: Modified wording patch applied. Thanks. Great, thanks Bruce. Best, David ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan

Re: [PATCHES] Small documentation patch

2006-10-02 Thread Bruce Momjian
Patch applied. Thanks. --- Guillaume Lelarge wrote: Hi all, This patch fixes a small typo in information_schema.sgml. Regards. -- Guillaume. !-- http://abs.traduc.org/ http://lfs.traduc.org/

Re: [HACKERS] [PATCHES] Bad bug in fopen() wrapper code

2006-10-02 Thread Bruce Momjian
Magnus Hagander wrote: Now, I still twist my head around the lines: if ((fd = _open_osfhandle((long) h, fileFlags O_APPEND)) 0 || (fileFlags (O_TEXT | O_BINARY) (_setmode(fd, fileFlags (O_TEXT | O_BINARY)) 0))) Without having studied it closely, it might also highlight

Re: [HACKERS] [PATCHES] Bad bug in fopen() wrapper code

2006-10-02 Thread Bruce Momjian
Bruce Momjian wrote: Magnus Hagander wrote: Now, I still twist my head around the lines: if ((fd = _open_osfhandle((long) h, fileFlags O_APPEND)) 0 || (fileFlags (O_TEXT | O_BINARY) (_setmode(fd, fileFlags (O_TEXT | O_BINARY)) 0))) Without having studied it

Re: [HACKERS] [PATCHES] Bad bug in fopen() wrapper code

2006-10-02 Thread Magnus Hagander
Without having studied it closely, it might also highlight a bug on failure of the second clause -- if the _setmode fails, shouldn't _close be called instead of CloseHandle, and -1 returned? (CloseHandle would still be called on failure of the _open_osfhandle,