Re: [HACKERS] [PATCHES] Dynamic Tracing docs

2006-12-04 Thread Zdenek Kotala
Simon Riggs napsal(a): On Sat, 2006-12-02 at 09:43 +0100, Peter Eisentraut wrote: Simon Riggs wrote: Enclose new trace.sgml file as discussed on -docs. I have a question here, regarding this: To include DTrace support in a 64-bit binary, specify --enable-dtrace and DTRACEFLAGS=-64 to

Re: [PATCHES] [HACKERS] elog(FATAL)ing non-existent roles during client

2006-12-04 Thread Gavin Sherry
On Tue, 5 Dec 2006, Gavin Sherry wrote: On Thu, 30 Nov 2006, Tom Lane wrote: Gavin Sherry [EMAIL PROTECTED] writes: I wonder if we should check if the role exists for the other authentication methods too? get_role_line() should be very cheap and it would prevent unnecessary

[PATCHES] zope connection string

2006-12-04 Thread [EMAIL PROTECTED]
In order to my mail bug #2801 I've solved this one modify the zope-psycopgda connection string: postgresql7.4.7:dbname=... user=... while postgresql7.2.1:dbname=... user=... host=... I don't know why but it works. Cordial regards Carmelo --

[PATCHES] Bundle of patches

2006-12-04 Thread Teodor Sigaev
The 1C (http://www.1c.ru/) company kindly permits to publish a set of patches we (Oleg and me) developed during our work on porting of the '1C:Enterprise' system to support the PostgreSQL database. We would like to suggest to commit they to HEAD. 1) Typmod for user-defined types

Re: [PATCHES] On-disk bitmap index implementation

2006-12-04 Thread Simon Riggs
On Tue, 2006-12-05 at 00:18 +1100, Gavin Sherry wrote: o Determine if we need to provide anything for rm_startup, rm_cleanup, rm_safe_restartpoint RmgrData function pointers. safe_restartpoint gives true/false based upon whether there are multi-record WAL states that have only been partially

Re: [PATCHES] zope connection string

2006-12-04 Thread Alvaro Herrera
[EMAIL PROTECTED] wrote: In order to my mail bug #2801 I've solved this one modify the zope-psycopgda connection string: postgresql7.4.7:dbname=... user=... while postgresql7.2.1:dbname=... user=... host=... I don't know why but it works. When you specify host it always uses a TCP socket.

[PATCHES] ECPG docs

2006-12-04 Thread Chris Browne
I noticed the following error in the chapter on ECPG... [EMAIL PROTECTED]:pgsql-HEAD/doc/src/sgml cvs diff -u ecpg.sgml Index: ecpg.sgml === RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ecpg.sgml,v retrieving revision 1.77 diff -c

Re: [PATCHES] On-disk bitmap index implementation

2006-12-04 Thread Heikki Linnakangas
Gavin Sherry wrote: Hi all, Attached is a patch implementing bitmap indexes. It includes major enhancements on the patch submitted during feature freeze for 8.2 here[1]. In particular: much better integration with the existing bitmap scan code with the internals of the bitmap streaming pushed

Re: [PATCHES] ECPG docs

2006-12-04 Thread Heikki Linnakangas
The original looks more correct to me. After the file has been run through the preprocessor, it becomes preprocessed. Chris Browne wrote: I noticed the following error in the chapter on ECPG... [EMAIL PROTECTED]:pgsql-HEAD/doc/src/sgml cvs diff -u ecpg.sgml Index: ecpg.sgml

Re: [PATCHES] ECPG docs

2006-12-04 Thread Chris Browne
[EMAIL PROTECTED] (Heikki Linnakangas) writes: The original looks more correct to me. After the file has been run through the preprocessor, it becomes preprocessed. The other option I was thinking of was postprocessed, because the .c file comes *after* processing. -- let name=cbbrowne and

Re: [PATCHES] Bundle of patches

2006-12-04 Thread Tom Lane
Teodor Sigaev [EMAIL PROTECTED] writes: 2) ORDER BY .. [ NULLS ( FIRST | LAST ) ] http://www.sigaev.ru/misc/NULLS_82-0.5.gz i haven't looked at the other patches yet, but this one is just horrid :-( Instead of creating a proper parse-tree representation of the NULLS FIRST/LAST option, you've

Re: [PATCHES] Bundle of patches

2006-12-04 Thread Tom Lane
Teodor Sigaev [EMAIL PROTECTED] writes: 3) Allow to use index for IS [NOT] NULL http://www.sigaev.ru/misc/indexnulls_82-0.6.gz Initially patch was developed by Martijn van Oosterhout kleptog@svana.org. But it's reworked and support of searching NULLS to GiST too. Patch adds new

Re: [PATCHES] Bundle of patches

2006-12-04 Thread Tom Lane
Teodor Sigaev [EMAIL PROTECTED] writes: 4) OR clauses optimizations http://www.sigaev.ru/misc/OR_82-0.6.gz This seems kinda ugly --- it looks very expensive and unlikely to find useful optimizations most of the time. Have you done any benchmarking to find out what the cost is when the

Re: [PATCHES] Bundle of patches

2006-12-04 Thread Teodor Sigaev
This has obvious semantic disdvantages (what if foo is an expensive function?); Agree. but the real problem is that there's no way for the planner to reason about ordering in this representation. This patch would guarantee that an ORDER BY with the NULLS option couldn't use an indexscan,

Re: [PATCHES] Bundle of patches

2006-12-04 Thread Tom Lane
Teodor Sigaev [EMAIL PROTECTED] writes: 1) Typmod for user-defined types http://www.sigaev.ru/misc/user_defined_typmod-0.7.gz Patch is based on ideas from http://archives.postgresql.org/pgsql-hackers/2004-06/msg00932.php

Re: [HACKERS] [PATCHES] Bundle of patches

2006-12-04 Thread Tom Lane
Teodor Sigaev [EMAIL PROTECTED] writes: but the real problem is that there's no way for the planner to reason about ordering in this representation. This patch would guarantee that an ORDER BY with the NULLS option couldn't use an indexscan, even if the index sorts nulls at the correct end.

Re: [PATCHES] Bundle of patches

2006-12-04 Thread Teodor Sigaev
This seems kinda ugly --- it looks very expensive and unlikely to find useful optimizations most of the time. Have you done any benchmarking to find out what the cost is when the optimizations don't succeed? Yep, it's a big win with order and limit specified. Let table (a,b) has index over

Re: [PATCHES] Bundle of patches

2006-12-04 Thread Teodor Sigaev
This one seems generally workable, but I really dislike the approach that's been used for passing typmod arguments to the typmod_in function. Representing them with an internal parameter means it'll be forever impossible to write typmod functions in anything but C, which seems an ugly

Re: [PATCHES] Bundle of patches

2006-12-04 Thread Teodor Sigaev
And what happens when we implement NULLS FIRST/LAST correctly? This is really a poor choice of representation. If it's just appending of indexscan's it's not a problem... One thing I find questionable about this is the assumption that indexes can support foo IS NULL and foo IS NOT NULL

Re: [HACKERS] [PATCHES] Bundle of patches

2006-12-04 Thread Martijn van Oosterhout
On Mon, Dec 04, 2006 at 01:35:21PM -0500, Tom Lane wrote: 3) Allow to use index for IS [NOT] NULL http://www.sigaev.ru/misc/indexnulls_82-0.6.gz Initially patch was developed by Martijn van Oosterhout kleptog@svana.org. But it's reworked and support of searching NULLS to GiST

Re: [HACKERS] [PATCHES] Bundle of patches

2006-12-04 Thread Martijn van Oosterhout
On Mon, Dec 04, 2006 at 02:04:26PM -0500, Tom Lane wrote: Teodor Sigaev [EMAIL PROTECTED] writes: 1) Typmod for user-defined types http://www.sigaev.ru/misc/user_defined_typmod-0.7.gz Patch is based on ideas from http://archives.postgresql.org/pgsql-hackers/2004-06/msg00932.php

Re: [PATCHES] On-disk bitmap index implementation

2006-12-04 Thread Heikki Linnakangas
Heikki Linnakangas wrote: We need to give the indexam API some further thought. As you know, I've been working on the Grouped Index Tuples stuff, which also requires changes to the API to get full benefit. There's a bunch of functionality I'd like to see: * Support for streamed bitmaps, like

Re: [PATCHES] patch of Encoding problem

2006-12-04 Thread Bruce Momjian
Sorry I missed this for 8.2.0. Applied to 8.2.X and CVS HEAD. --- Hiroshi Saito wrote: Hi. I think this problem to be complex http://archives.postgresql.org/pgsql-hackers/2006-11/msg00042.php FormatMessage of

Re: [PATCHES] win32.mak patch of pg_dump.

2006-12-04 Thread Bruce Momjian
Patch applied and backpatched for 8.2.X. Sorry it didn't make it into 8.2.0. --- Hiroshi Saito wrote: Hi. The module link is insufficient.:-( Sorry, japanese message change to xxx --- link.exe

Re: [PATCHES] On-disk bitmap index implementation

2006-12-04 Thread Gavin Sherry
On Mon, 4 Dec 2006, Simon Riggs wrote: On Tue, 2006-12-05 at 00:18 +1100, Gavin Sherry wrote: o Determine if we need to provide anything for rm_startup, rm_cleanup, rm_safe_restartpoint RmgrData function pointers. safe_restartpoint gives true/false based upon whether there are

Re: [PATCHES] On-disk bitmap index implementation

2006-12-04 Thread Gavin Sherry
On Mon, 4 Dec 2006, Heikki Linnakangas wrote: o Test WAL replay more thoroughly. I've had that problem too with a lot of things I've hacked. I've used a shell script that does the operation under test, runs a select, kills and restarts postmaster, and reruns the select. If the select after