Re: [PATCHES] [HACKERS] Recent SIGSEGV failures in buildfarm HEAD

2006-12-29 Thread Stefan Kaltenbrunner
Tom Lane wrote: > Andrew Dunstan <[EMAIL PROTECTED]> writes: >> ... And then we'd need to change the regression makefile to use >> the option, based on an environment variable a bit like MAX_CONNEXCTIONS >> maybe. > > Why wouldn't we just use it always? If a regression test dumps core, > that's

Re: [PATCHES] [HACKERS] Recent SIGSEGV failures in buildfarm HEAD

2006-12-29 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > ... And then we'd need to change the regression makefile to use > the option, based on an environment variable a bit like MAX_CONNEXCTIONS > maybe. Why wouldn't we just use it always? If a regression test dumps core, that's going to deserve investiga

Re: [PATCHES] [HACKERS] Recent SIGSEGV failures in buildfarm HEAD

2006-12-29 Thread Andrew Dunstan
Stefan Kaltenbrunner wrote: Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: I'm actually wondering if unlimiting core might not be a useful switch to provide on pg_ctl, as long as the platform has setrlimit(). Not a bad thought; that's actually one of the reasons that

[PATCHES] WIP: pg_regress updates for vc++ bulid

2006-12-29 Thread Magnus Hagander
Hello! Per some previous discussion that I can't really recall if it was on or off list, here is a WIP patch to make pg_regress run completely outside of msys on win32. The change needed is that the processing of files from input/ and output/ into sql/ and expected/ is moved from the Makefile and

[PATCHES] Small vcbuild patch

2006-12-29 Thread Magnus Hagander
Oneliner that adds the capability to deal with defines that set string values - " needs to be quoted in XML. //Magnus Index: src/tools/msvc/Project.pm === RCS file: c:/prog/cvsrepo/pgsql/pgsql/src/tools/msvc/Project.pm,v retrieving re

Re: [HACKERS] [PATCHES] [BUGS] BUG #2846: inconsistent and confusing

2006-12-29 Thread Roman Kononov
On 12/29/2006 11:27 AM, Tom Lane wrote: Doesn't even compile here (no ). Where do you compile? Roman ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [PATCHES] Fwd: I would like to alter the COPY command

2006-12-29 Thread Andrew Dunstan
Mason wrote: What I have is data with two different characters for "start quote" and "end quote". In my case it's '[' and ']', but it could be anything from "smart quotes", to parentheses, to brackets, braces, ^/$ in regexps, etc. I think this isn't too unreasonable a feature to have to make co

Re: [HACKERS] [PATCHES] [BUGS] BUG #2846: inconsistent and confusing

2006-12-29 Thread Tom Lane
Roman Kononov <[EMAIL PROTECTED]> writes: > Think about this idea please. This has no INF, NaN or range > checks and detects all "bad" cases with any floating point > math. Doesn't even compile here (no ). regards, tom lane ---(end of broadcast)---

Re: [HACKERS] [PATCHES] Bundle of patches

2006-12-29 Thread Tom Lane
Teodor Sigaev <[EMAIL PROTECTED]> writes: > Just a freshing for clean applying.. > http://www.sigaev.ru/misc/user_defined_typmod-0.11.gz > Is any objections to commit? There's still a lot I don't particularly care for here (lack of documentation being the biggest), but I'll make a pass at cleaning

Re: [PATCHES] [BUGS] BUG #2846: inconsistent and confusing handling of underflows,

2006-12-29 Thread Roman Kononov
On 12/27/2006 12:44 PM, Bruce Momjian wrote: The only unsolved issue is the one with underflow checks. I have added comments explaining the problem in case someone ever figures out how to address it. This will behave better for float4: Datum float4pl(PG_FUNCTION_ARGS) { ---float4 a

Re: [HACKERS] [PATCHES] [BUGS] BUG #2846: inconsistent and confusing

2006-12-29 Thread Roman Kononov
On 12/29/2006 12:23 AM, Bruce Momjian wrote: Well, then show me what direction you think is better. Think about this idea please. This has no INF, NaN or range checks and detects all "bad" cases with any floating point math. The only issue is that a bad case is detected only once. You need to

[PATCHES] Fwd: I would like to alter the COPY command

2006-12-29 Thread Mason
What I have is data with two different characters for "start quote" and "end quote". In my case it's '[' and ']', but it could be anything from "smart quotes", to parentheses, to brackets, braces, ^/$ in regexps, etc. I think this isn't too unreasonable a feature to have to make copy more functi

Re: [PATCHES] XML support in MSVC build

2006-12-29 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > Attached patch adds support for the recent XML-in-backend stuff to the > MSVC build. Most config stuff was already present for contrib/xml2, but > needed to add the includes and defines to the backend build as well. Applied, thanks.

Re: [HACKERS] [PATCHES] [BUGS] BUG #2846: inconsistent and

2006-12-29 Thread Florian G. Pflug
Tom Lane wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: OK, are you saying that there is a signal we are ignoring for overflow/underflow, or that we should just silently overflow/underflow and not throw an error? Silent underflow is fine with me; it's the norm in most all float implementatio

Re: [HACKERS] [PATCHES] [BUGS] BUG #2846: inconsistent and

2006-12-29 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > OK, are you saying that there is a signal we are ignoring for > overflow/underflow, or that we should just silently overflow/underflow > and not throw an error? Silent underflow is fine with me; it's the norm in most all float implementations and won't s

Re: [HACKERS] [PATCHES] [BUGS] BUG #2846: inconsistent and

2006-12-29 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> This is *not* going in the right direction :-( > > > Well, then show me what direction you think is better. > > Fewer restrictions, not more. The thrust of what I've been saying > (and I think Roman too) is to t

[PATCHES] XML support in MSVC build

2006-12-29 Thread Magnus Hagander
Attached patch adds support for the recent XML-in-backend stuff to the MSVC build. Most config stuff was already present for contrib/xml2, but needed to add the includes and defines to the backend build as well. //Magnus Index: src/tools/msvc/Solution.pm ==

Re: [PATCHES] Bundle of patches

2006-12-29 Thread Teodor Sigaev
This is not responding to my concern. What you presented was an > Sorry, I see your point now. Is that test enough? Or I should make more? -- Teodor Sigaev E-mail: [EMAIL PROTECTED] WWW: http://www.sigaev.ru/

Re: [HACKERS] [PATCHES] Bundle of patches

2006-12-29 Thread Teodor Sigaev
Just a freshing for clean applying.. http://www.sigaev.ru/misc/user_defined_typmod-0.11.gz Is any objections to commit? -- Teodor Sigaev E-mail: [EMAIL PROTECTED] WWW: http://www.sigaev.ru/ -

Re: [HACKERS] [PATCHES] [BUGS] BUG #2846: inconsistent and

2006-12-29 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> This is *not* going in the right direction :-( > Well, then show me what direction you think is better. Fewer restrictions, not more. The thrust of what I've been saying (and I think Roman too) is to trust in the hardware float-arith