Re: [PATCHES] CREATE TABLE LIKE INCLUDING INDEXES support

2007-05-02 Thread Tom Lane
NikhilS <[EMAIL PROTECTED]> writes: > But this patch is not for the "INCLUDING INDEXES" case. Pardon me for being misled by the thread title :-( regards, tom lane ---(end of broadcast)--- TIP 3: Have you checked our extensiv

[PATCHES] [WIP] GUC for temp_tablespaces

2007-05-02 Thread Jaime Casanova
On 3/17/07, Tom Lane <[EMAIL PROTECTED]> wrote: "Jaime Casanova" <[EMAIL PROTECTED]> writes: > On 3/5/07, Tom Lane <[EMAIL PROTECTED]> wrote: >> In the second place, it's a serious violation of what little modularity >> and layering we have for fd.c to be calling into commands/tablespace.c. >> Th

Re: [PATCHES] CREATE TABLE LIKE INCLUDING INDEXES support

2007-05-02 Thread NikhilS
Hi, On 5/3/07, Tom Lane <[EMAIL PROTECTED]> wrote: NikhilS <[EMAIL PROTECTED]> writes: > Hi Neil, >> * the patch is broken for expressional indexes, and silently omits >> copying the predicate that may be associated with an index. > Since this patch is only supposed to copy unique/primary inde

Re: [PATCHES] CREATE TABLE LIKE INCLUDING INDEXES support

2007-05-02 Thread Neil Conway
On Wed, 2007-02-05 at 17:09 +0530, NikhilS wrote: > Since this patch is only supposed to copy unique/primary indexes, I > dont think we will ever have predicates associated to such indexes? Nope: neilc=# create table t1 (a int, b int); CREATE TABLE neilc=# create unique index t1_a_idx on t1 ((a +

Re: [PATCHES] CREATE TABLE LIKE INCLUDING INDEXES support

2007-05-02 Thread Tom Lane
NikhilS <[EMAIL PROTECTED]> writes: > Hi Neil, >> * the patch is broken for expressional indexes, and silently omits >> copying the predicate that may be associated with an index. > Since this patch is only supposed to copy unique/primary indexes, I dont > think we will ever have predicates associ

Re: [PATCHES] Updated bitmap index patch

2007-05-02 Thread Mark Kirkwood
Gavin Sherry wrote: Hi all, Attached is an updated bitmap index patch. It contains bug fixes, API changes, binary changes (page identifier to distinguish it from other indexes) and has been brought up to HEAD. I have applied this to todays HEAD performed some quick tests - looks good! I have

Re: [PATCHES] Clear up strxfrm() in UTF-8 with locale on Windows

2007-05-02 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > Given this, perhaps the proper approach should instead be to just check > the return value, and go from there? Should be a simple enough patch, > something like the attached. > Tom, can you comment? Testing against INT_MAX seems like a type pun, or so

Re: [PATCHES] Clear up strxfrm() in UTF-8 with locale on Windows

2007-05-02 Thread Magnus Hagander
ITAGAKI Takahiro wrote: > The attached patch clears up the usage of strxfrm() on Windows. If the > server encoding is UTF-8 and the locale is not C, we should use wcsxfrm() > instead of strxfrm() because UTF-8 locale are not supported on Windows. > We've already have a special version of strcoll()

Re: [PATCHES] [HACKERS] autovacuum does not start in HEAD

2007-05-02 Thread Alvaro Herrera
ITAGAKI Takahiro wrote: > I wrote: > > I found that autovacuum launcher does not launch any workers in HEAD. > > The attached autovacuum-fix.patch could fix the problem. I changed > to use 'greater or equal' instead of 'greater' at the decision of > next autovacuum target. I have committed a patc

Re: [PATCHES] [GENERAL] dropping role w/dependent objects

2007-05-02 Thread Alvaro Herrera
Tom Lane wrote: > "Ed L." <[EMAIL PROTECTED]> writes: > > [ enlarge MAX_REPORTED_DEPS to 2000 ] > > I was about to apply this, but stopped to reflect that it is probably > not such a hot idea. My concern is that enormously long error message > detail fields are likely to break client software, pa

Re: [PATCHES] CREATE TABLE LIKE INCLUDING INDEXES support

2007-05-02 Thread NikhilS
Hi Neil, * the patch is broken for expressional indexes, and silently omits copying the predicate that may be associated with an index. It also doesn't copy the index's amoptions (WITH clause), or the NULLS FIRST/etc. options that may be associated with any of the index's columns. Since this

Re: [PATCHES] non-recursive WITH clause support

2007-05-02 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Gregory Stark wrote: > > Here's an updated patch that fixes the bug I had. This is now functional basic > non-recurs

[PATCHES] Diagnostic functions

2007-05-02 Thread Heikki Linnakangas
Here's an update of Simon's Heap Page Diagnostic Functions. I now consider it ready to commit. The new functions are all under new contrib module, contrib/pgdiagnostics. I also moved bt_metap, bt_page_items and bt_page_stats from pgstattuple to the new module. I copied the bt_* functions alm