Re: [PATCHES] CREATE TABLE LIKE INCLUDING INDEXES support

2007-06-02 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Attached is a revised version of this patch. This still seems to fundamentally misunderstand the difference between an index and a constraint. IMHO it should not be examining pg_index (or specifically, the index Relations) at all.

Re: [PATCHES] CREATE TABLE LIKE INCLUDING INDEXES support

2007-06-02 Thread Neil Conway
On Mon, 2007-21-05 at 12:23 +0530, NikhilS wrote: > I had spent some time on this earlier so decided to complete and send > the patch to you for review. This patch supports copying of > expressions, predicates, opclass, amorder, reloptions etc. The test > case also contains some more additions with

Re: [PATCHES] Seq scans status update

2007-06-02 Thread Tom Lane
Luke Lonergan <[EMAIL PROTECTED]> writes: > The mailing list archives contain the ample evidence of: > - it's definitely an L2 cache effect > - on fast I/O hardware tests show large benefits of keeping the ring in L2 Please provide some specific pointers, because I don't remember that.

Re: [PATCHES] Seq scans status update

2007-06-02 Thread Luke Lonergan
Hi All, On 5/31/07 12:40 AM, "Heikki Linnakangas" <[EMAIL PROTECTED]> wrote: > BTW, we've been talking about the "L2 cache effect" but we don't really > know for sure if the effect has anything to do with the L2 cache. But > whatever it is, it's real. The mailing list archives contain the ample

Re: [PATCHES] Bug in date.c

2007-06-02 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > There's a bug in datetime.c when it handles errors converting text into > various date formats. It tries to avoid palloc'ing a cstring copy of the in= > put > by storing it in a stack variable instead but that means it can't handle > inputs over MAXDATELE

[PATCHES] Bug in date.c

2007-06-02 Thread Gregory Stark
There's a bug in datetime.c when it handles errors converting text into various date formats. It tries to avoid palloc'ing a cstring copy of the input by storing it in a stack variable instead but that means it can't handle inputs over MAXDATELEN. So it throws an error but passes the varlena strin