Re: [PATCHES] Synchronized scans

2007-06-07 Thread Tom Lane
Jeff Davis <[EMAIL PROTECTED]> writes: > Just to be sure: a backwards-started scan is currently unreachable code, > correct? [ yawn... ] I think so, but I wouldn't swear to it right at the moment. In any case it doesn't seem like a path that we need to optimize. regards,

Re: [PATCHES] Synchronized scans

2007-06-07 Thread Jeff Davis
On Thu, 2007-06-07 at 22:52 -0400, Tom Lane wrote: > Heikki Linnakangas <[EMAIL PROTECTED]> writes: > > I fixed a little off-by-one in "backward scan, not inited" branch, but I > > was unable to test it. It seems that code is actually never used because > > that case is optimized to a rewind in t

Re: [PATCHES] Synchronized scans

2007-06-07 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > I fixed a little off-by-one in "backward scan, not inited" branch, but I > was unable to test it. It seems that code is actually never used because > that case is optimized to a rewind in the executor. I marked those > seemingly unreachable places

Re: [HACKERS] [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit

2007-06-07 Thread Alvaro Herrera
Matthew T. O'Connor wrote: > Alvaro Herrera wrote: > >Tom Lane wrote: > >>Alvaro Herrera <[EMAIL PROTECTED]> writes: > >>>But this is misleading (started postmaster with good value, then edited > >>>postgresql.conf and entered "-2"): > >>>17903 LOG: received SIGHUP, reloading configuration files >

Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit

2007-06-07 Thread Matthew T. O'Connor
Alvaro Herrera wrote: Tom Lane wrote: Alvaro Herrera <[EMAIL PROTECTED]> writes: But this is misleading (started postmaster with good value, then edited postgresql.conf and entered "-2"): 17903 LOG: received SIGHUP, reloading configuration files 17903 LOG: -2 is outside the valid range for pa

Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit

2007-06-07 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > But this is misleading (started postmaster with good value, then edited > > postgresql.conf and entered "-2"): > > > 17903 LOG: received SIGHUP, reloading configuration files > > 17903 LOG: -2 is outside the valid range for paramet

Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit

2007-06-07 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > But this is misleading (started postmaster with good value, then edited > postgresql.conf and entered "-2"): > 17903 LOG: received SIGHUP, reloading configuration files > 17903 LOG: -2 is outside the valid range for parameter > "autovacuum_vacuum_cos

Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit

2007-06-07 Thread Alvaro Herrera
Galy Lee wrote: Hi, I'll deal with each issue separately. > * Bug-1: Invalid lower bound of autovacuum_cost_limit > > autovacuum_vacuum_cost_limit should be the following value: > autovacuum_vacuum_cost_limit = -1, or [1, 1] > (0 should be prohibited. ) > > But 0 can also be accepted

Re: [PATCHES] contrib/pgstattuple Japanese documentation fix

2007-06-07 Thread ITAGAKI Takahiro
Heikki Linnakangas <[EMAIL PROTECTED]> wrote: > Would you like to add corresponding Japanese documentation to > pageinspect, or is it not worthwhile? No, I think such *deep* users who want to use pageinspect would be satisfied with English documentation :) Regards, --- ITAGAKI Takahiro NTT Ope

Re: [PATCHES] contrib/pgstattuple Japanese documentation fix

2007-06-07 Thread Magnus Hagander
On Thu, Jun 07, 2007 at 11:41:24AM +0900, ITAGAKI Takahiro wrote: > The functions bt_metap, bt_page_stats and bt_page_items had moved > from contrib/pgstattuple to pageinspect. We've already fixed English > documentation, but Japanese version does not catch up. The attached > patch just removes tho

Re: [PATCHES] contrib/pgstattuple Japanese documentation fix

2007-06-07 Thread Heikki Linnakangas
ITAGAKI Takahiro wrote: The functions bt_metap, bt_page_stats and bt_page_items had moved from contrib/pgstattuple to pageinspect. We've already fixed English documentation, but Japanese version does not catch up. The attached patch just removes those descriptions from README.ja in pgstattuple.