[PATCHES] pg_restore loops forever past EOF for corrupt custom archive files

2007-08-04 Thread Chad Wagner
This patch modifies the ReadStr function in pg_backup_archiver.c to validate the result of *AH->ReadBufPtr matches the value of l. The resulting error is: pg_restore: [archiver] expected 410 bytes, only got 275 bytes pg_restore.diff Description: Binary data ---(end of b

Re: [PATCHES] Repair cosmetic damage (done by pg_indent?)

2007-08-04 Thread Gregory Stark
"daveg" <[EMAIL PROTECTED]> writes: > I have a table of (id serial primary key, url text unique) with a few > hundred million urls that average about 120 bytes each. The url index is > only used when a possibly new url is to be inserted, but between the data > and the index this table occupies a l

Re: [PATCHES] Repair cosmetic damage (done by pg_indent?)

2007-08-04 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > I think these are some more comments which were misaligned by pg_indent a > couple of releases ago. I recall Bruce fixed a bug in pg_indent which was > causing it and the damage looked something like this. > I also reduced the indentation so the comment

Re: [PATCHES] Repair cosmetic damage (done by pg_indent?)

2007-08-04 Thread daveg
On Sat, Aug 04, 2007 at 09:04:33PM +0100, Gregory Stark wrote: > "Tom Lane" <[EMAIL PROTECTED]> writes: > > > Gregory Stark <[EMAIL PROTECTED]> writes: > >> The scenario I was describing was having, for example, 20 fields each > >> of which are char(100) and store 'x' (which are padded with 99 > >

Re: [PATCHES] Repair cosmetic damage (done by pg_indent?)

2007-08-04 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: >> The scenario I was describing was having, for example, 20 fields each >> of which are char(100) and store 'x' (which are padded with 99 >> spaces). So the row is 2k but the fields are highly compressible, but >>

Re: [PATCHES] Repair cosmetic damage (done by pg_indent?)

2007-08-04 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > The scenario I was describing was having, for example, 20 fields each > of which are char(100) and store 'x' (which are padded with 99 > spaces). So the row is 2k but the fields are highly compressible, but > shorter than the 256 byte minimum. To be blun

Re: [PATCHES] Repair cosmetic damage (done by pg_indent?)

2007-08-04 Thread Gregory Stark
"Decibel!" <[EMAIL PROTECTED]> writes: > On Sun, Jul 29, 2007 at 12:06:50PM +0100, Gregory Stark wrote: >> You would have to recompile with the value at line 214 of >> src/backend/utils/adt/pg_lzcompress.c set to a lower value. > > Doesn't seem to be working for me, even in the case of a table wit

Re: [PATCHES] Repair cosmetic damage (done by pg_indent?)

2007-08-04 Thread Decibel!
On Sun, Jul 29, 2007 at 12:06:50PM +0100, Gregory Stark wrote: > You would have to recompile with the value at line 214 of > src/backend/utils/adt/pg_lzcompress.c set to a lower value. Doesn't seem to be working for me, even in the case of a table with a bunch of rows containing nothing but 213 'x

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-04 Thread Hiroshi Saito
Hi Tom-san. My it looks very great.!!! I was operating in the seen last night patch. Naturally, your thing is more great. Thank you very much!:-) Regards, Hiroshi Saito From: "Tom Lane" <[EMAIL PROTECTED]> Andrew Dunstan <[EMAIL PROTECTED]> writes: Tom's idea of a log_timezone seems to