Re: [PATCHES] pg_restore loops forever past EOF for corrupt custom archive files

2007-08-05 Thread Tom Lane
"Chad Wagner" <[EMAIL PROTECTED]> writes: > On 8/5/07, Tom Lane <[EMAIL PROTECTED]> wrote: >> If we're trying to defend against premature EOF, this hardly seems like >> a sufficient patch. > I agree, but it is better than nothing. If you have some suggestions or > other areas of the pg_restore co

Re: [PATCHES] pg_restore loops forever past EOF for corrupt custom archive files

2007-08-05 Thread Chad Wagner
On 8/5/07, Tom Lane <[EMAIL PROTECTED]> wrote: > > "Chad Wagner" <[EMAIL PROTECTED]> writes: > > This patch modifies the ReadStr function in pg_backup_archiver.c to > validate > > the result of *AH->ReadBufPtr matches the value of l. > > If we're trying to defend against premature EOF, this hardly

Re: [PATCHES] pg_restore loops forever past EOF for corrupt custom archive files

2007-08-05 Thread Tom Lane
"Chad Wagner" <[EMAIL PROTECTED]> writes: > This patch modifies the ReadStr function in pg_backup_archiver.c to validate > the result of *AH->ReadBufPtr matches the value of l. If we're trying to defend against premature EOF, this hardly seems like a sufficient patch. rega