Re: [PATCHES] Bunch of tsearch fixes and cleanup

2007-08-23 Thread Heikki Linnakangas
Tom Lane wrote: > Something that was annoying me yesterday was that it was not clear > whether we had fixed every single place that uses a tsearch config file > to assume that the file is in UTF8 and should be converted to database > encoding. So I was thinking of hardwiring the "recode" part into

Re: [PATCHES] Bunch of tsearch fixes and cleanup

2007-08-23 Thread Oleg Bartunov
On Thu, 23 Aug 2007, Tom Lane wrote: "Heikki Linnakangas" <[EMAIL PROTECTED]> writes: - readstopwords calls recode_and_lowerstr directly, instead of using the "wordop" function pointer in StopList struct. All callers used recode_and_lowerstr anyway, so this simplifies the code a little bit. Is

Re: [PATCHES] [BUGS] BUG #3571: call to decrypt causes segfault

2007-08-23 Thread Tom Lane
"Marko Kreen" <[EMAIL PROTECTED]> writes: > The fix should be in combo_decrypt() because other code > should not need to guess whether zero-length input is > allowed or not. > Patch attached. Thanks -- applied in all branches back to 7.3. regards, tom lane --

Re: [PATCHES] Bunch of tsearch fixes and cleanup

2007-08-23 Thread Heikki Linnakangas
Tom Lane wrote: > "Heikki Linnakangas" <[EMAIL PROTECTED]> writes: >> - readstopwords calls recode_and_lowerstr directly, instead of using the >> "wordop" function pointer in StopList struct. All callers used >> recode_and_lowerstr anyway, so this simplifies the code a little bit. Is >> there any

Re: [PATCHES] Bunch of tsearch fixes and cleanup

2007-08-23 Thread Tom Lane
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > - readstopwords calls recode_and_lowerstr directly, instead of using the > "wordop" function pointer in StopList struct. All callers used > recode_and_lowerstr anyway, so this simplifies the code a little bit. Is > there any external dictionary im

[PATCHES] Bunch of tsearch fixes and cleanup

2007-08-23 Thread Heikki Linnakangas
Fixes the following bugs: - ispell initialization crashed on empty dictionary file - ispell initialization crashed on affix file with prefixes but no suffixes - stop words file was ran through pg_verify_mbstr, with database encoding, but it's later interpreted as being UTF-8. Now verifies that it's

Re: [PATCHES] [BUGS] BUG #3571: call to decrypt causes segfault

2007-08-23 Thread Marko Kreen
On 8/23/07, Tom Lane <[EMAIL PROTECTED]> wrote: > "Ken Colson" <[EMAIL PROTECTED]> writes: > > this statement: > > select decrypt(''::bytea,'password','bf') > > causes the postgresql backend to crash: > > This seems to be a 64bit problem. > > Reproduced here in HEAD. The problem is here: > 293