Re: [PATCHES] Bunch of tsearch fixes and cleanup

2007-08-24 Thread Tom Lane
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > Ok, here's an updated version of the patch. Applied, with a few trivial additional cleanups I noticed while reading the patch. I included your HeadlineText de-duplication too. regards, tom lane --

Re: [PATCHES] Optimizer hook

2007-08-24 Thread Julius Stroffek
I rewrote a patch a bit. I made function make_one_rel_by_joins also non-static, so that the optimizer in plugin can reuse the dynamic optimizer. I also reorganized the code and put all the changes to paths.h and allpaths.c files only. It seems to me more appropriate that the hook should belong t

Re: [PATCHES] Bunch of tsearch fixes and cleanup

2007-08-24 Thread Tom Lane
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > Ok, here's an updated version of the patch. I haven't actually read this patch yet, but the description all sounds like the Right Thing now. Will review and commit today. Also, I believe there's consensus to rename the standard Snowball dictiona

[PATCHES] HeadlineParsedText vs HeadlineText

2007-08-24 Thread Heikki Linnakangas
Two identical structs are defined and used interchangeably in tsearch: HeadlineParsedText and HeadlineText, along with corresponding HeadlineWord and HeadlineWordEntry sub-structs. In the contrib version this struct only appeared once, and was called HLPRSTEXT, so apparently that was accidentally m

Re: [PATCHES] Bunch of tsearch fixes and cleanup

2007-08-24 Thread Heikki Linnakangas
And here's the attachment I forgot. Heikki Linnakangas wrote: > Heikki Linnakangas wrote: >> Tom Lane wrote: >>> Something that was annoying me yesterday was that it was not clear >>> whether we had fixed every single place that uses a tsearch config file >>> to assume that the file is in UTF8 and

Re: [PATCHES] Bunch of tsearch fixes and cleanup

2007-08-24 Thread Heikki Linnakangas
Heikki Linnakangas wrote: > Tom Lane wrote: >> Something that was annoying me yesterday was that it was not clear >> whether we had fixed every single place that uses a tsearch config file >> to assume that the file is in UTF8 and should be converted to database >> encoding. So I was thinking of h