Re: [PATCHES] Lazy xid assignment V4

2007-09-04 Thread Tom Lane
"Florian G. Pflug" <[EMAIL PROTECTED]> writes: > Here is an updated patch, following the discussion. > The patch can be found at: http://soc.phlo.org/lazyxidassign.v4.patch I've been working through this, and found a couple items that seem like judgment calls: * Is there a good reason for formatt

Re: [PATCHES] HOT documentation README

2007-09-04 Thread Gregory Stark
"Pavan Deolasee" <[EMAIL PROTECTED]> writes: > It would be worth mentioning that columns appearing in predicates > of partial indexes and expressions of expression indexes are also > checked. If any of these columns are changed, HOT update is not done. In discussion a question arose. I don't thi

Re: [PATCHES] Lazy xid assignment V4

2007-09-04 Thread Florian G. Pflug
Chris Browne wrote: Similarly, does it seem likely that Slony-I users would need to worry about this? No.. it should have zero negative effects for Slony-I. In fact, it will be an advantage in some cases I think. I remember something about troubles with Slony-I if the in-use xids on a intermedia

Re: [PATCHES] Lazy xid assignment V4

2007-09-04 Thread Chris Browne
[EMAIL PROTECTED] ("Florian G. Pflug") writes: > Pavan Deolasee wrote: >> On 9/4/07, Florian G. Pflug <[EMAIL PROTECTED]> wrote: >>> Hi >>> >>> Here is an updated patch, following the discussion. >>> The patch can be found at: http://soc.phlo.org/lazyxidassign.v4.patch >>> (I seems I still can't ge

Re: [PATCHES] HOT documentation README

2007-09-04 Thread Bruce Momjian
Pavan Deolasee wrote: > It would be worth mentioning that columns appearing in predicates > of partial indexes and expressions of expression indexes are also > checked. If any of these columns are changed, HOT update is not done. Added now: Tuples are checked against expression and

Re: [PATCHES] HOT documentation README

2007-09-04 Thread Bruce Momjian
Gregory Stark wrote: > > "Bruce Momjian" <[EMAIL PROTECTED]> writes: > > > I have taken this, and Pavan's documentation about CREATE INDEX, and > > worked up an updated README. Comments? Corrections? > > Oh, you I think the CREATE INDEX documentation you refer to was actually the > one I sugge

Re: [PATCHES] HOT documentation README

2007-09-04 Thread Pavan Deolasee
On 9/4/07, Bruce Momjian <[EMAIL PROTECTED]> wrote: > > > I have taken this, and Pavan's documentation about CREATE INDEX, and > worked up an updated README. Comments? Corrections? Thanks Bruce, Heikki, Greg for helping me with the documentation. > The requirements for doing a HOT update is

Re: [PATCHES] HOT documentation README

2007-09-04 Thread Pavan Deolasee
On 9/4/07, Gregory Stark <[EMAIL PROTECTED]> wrote: > > > NOTE: This is something likely to change. Current discussions are leading > towards handling DELETE_IN_PROGRESS and INSERT_IN_PROGRESS from other > transactions. We would do this by waiting until the transactions owning > those > tuples exi

Re: [PATCHES] Lazy xid assignment V4

2007-09-04 Thread Pavan Deolasee
On 9/4/07, Florian G. Pflug <[EMAIL PROTECTED]> wrote: > > > I don't think so. The interactions should be pretty minimal. Thats good news! Thanks, Pavan -- Pavan Deolasee EnterpriseDB http://www.enterprisedb.com

Re: [PATCHES] Lazy xid assignment V4

2007-09-04 Thread Florian G. Pflug
Pavan Deolasee wrote: On 9/4/07, Florian G. Pflug <[EMAIL PROTECTED]> wrote: Hi Here is an updated patch, following the discussion. The patch can be found at: http://soc.phlo.org/lazyxidassign.v4.patch (I seems I still can't get attachments through to this list) I haven't been able to follow

Re: [PATCHES] Lazy xid assignment V4

2007-09-04 Thread Tom Lane
"Pavan Deolasee" <[EMAIL PROTECTED]> writes: > On 9/4/07, Florian G. Pflug <[EMAIL PROTECTED]> wrote: >> Here is an updated patch, following the discussion. >> The patch can be found at: http://soc.phlo.org/lazyxidassign.v4.patch >> (I seems I still can't get attachments through to this list) >> >

Re: [PATCHES] Lazy xid assignment V4

2007-09-04 Thread Pavan Deolasee
On 9/4/07, Florian G. Pflug <[EMAIL PROTECTED]> wrote: > > Hi > > Here is an updated patch, following the discussion. > The patch can be found at: http://soc.phlo.org/lazyxidassign.v4.patch > (I seems I still can't get attachments through to this list) > > I haven't been able to follow the discussi

[PATCHES] Lazy xid assignment V4

2007-09-04 Thread Florian G. Pflug
Hi Here is an updated patch, following the discussion. The patch can be found at: http://soc.phlo.org/lazyxidassign.v4.patch (I seems I still can't get attachments through to this list) Most changes are just small fixes and tweaks. Those are .) Introduced %v for log_line_prefix .) I missed a few

Re: [PATCHES] [HACKERS] enum types and binary queries

2007-09-04 Thread Andrew Dunstan
Merlin Moncure wrote: On 8/31/07, Tom Lane <[EMAIL PROTECTED]> wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: Here's a patch (minus catalog bump) which I think does that. Looks sane in a very quick once-over, but I didn't test it. works fine (here was my test). thank

Re: [PATCHES] HOT documentation README

2007-09-04 Thread Gregory Stark
"Bruce Momjian" <[EMAIL PROTECTED]> writes: > I have taken this, and Pavan's documentation about CREATE INDEX, and > worked up an updated README. Comments? Corrections? Oh, you I think the CREATE INDEX documentation you refer to was actually the one I suggested. A few tweaks: > (If we find a

Re: [PATCHES] HOT documentation README

2007-09-04 Thread Heikki Linnakangas
Bruce Momjian wrote: > Heikki Linnakangas wrote: >> Tom Lane wrote: >>> "Pavan Deolasee" <[EMAIL PROTECTED]> writes: Please see the version 14 of HOT patch attached. >>> I expected to find either a large new README, or some pretty substantial >>> additions to existing README files, to document

Re: [PATCHES] HOT documentation README

2007-09-04 Thread Gregory Stark
"Bruce Momjian" <[EMAIL PROTECTED]> writes: > Heikki Linnakangas wrote: > >> Here's an updated version of the README I posted earlier. It now >> reflects the changes to how pruning works. > > I have taken this, and Pavan's documentation about CREATE INDEX, and > worked up an updated README. Comme