Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > In fact, we can accept options like: > initdb -E UTF8 --locale=Japanese_Japan.932 -- CP932 is SJIS in nature Hmm, but does that really work safely? I think varstr_cmp() does work, because it forces our data into wchar format and then calls wcscoll(

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread Hiroshi Saito
Hi. Um, I thinks the examination material of 8.4 by the reason for changing the feature. Of course, your proposal can be considered to obtain one solution. Then, discussion is required more. I feel that it is dangerous for 8.3 Regards, Hiroshi Saito I wrote: I'll suggest to use UTF8

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread ITAGAKI Takahiro
I wrote: > I'll suggest to use UTF8 if the encoding is UTF-8 or NOT specified and > we don't support the locale encoding on Windows, i.e. locale is always > enabled on regression tests. Here is a patch to do it on Windows. 1. Use UTF-8 if the locale encoding is not available for server. 2. Al

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread ITAGAKI Takahiro
"Hiroshi Saito" <[EMAIL PROTECTED]> wrote: > regression test surely goes wrong.! This fix does nothing against the regression failure. It is probably reasonable to choose UTF-8 as a server encoding when we cannot support the encoding of the current locale. A remaining issue is which we should u

Re: [PATCHES] [HACKERS] Use of "postmaster"

2007-10-03 Thread Brendan Jurd
On 10/4/07, Tom Lane <[EMAIL PROTECTED]> wrote: > "Brendan Jurd" <[EMAIL PROTECTED]> writes: > > Now that we've renamed the server binary to "postgres", what is the > > status on use of the name "postmaster"? Is it now deprecated? And if > > not, is there any point in keeping it around? > > We sh

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread Hiroshi Saito
Oops, patch of pg_regress.c should be disregarded. Sorry, I think this is desirable. Hi. regression test surely goes wrong.! hedule --multibyte=SQL_ASCII --load-language=plpgsql == creating temporary installation== == initializing database system

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread Hiroshi Saito
Hi. regression test surely goes wrong.! hedule --multibyte=SQL_ASCII --load-language=plpgsql == creating temporary installation== == initializing database system == pg_regress: initdb failed Examine ./log/initdb.log for the reaso

Re: [PATCHES] OpenSSL Applink

2007-10-03 Thread Magnus Hagander
Tom Lane wrote: > Heikki Linnakangas <[EMAIL PROTECTED]> writes: >> I guess you guys already found a solution that works, but there's yet >> another function, "BIO *BIO_new_mem_buf(void *data, int len)", that we >> could use. We could open and read the file all by ourselves into memory, >> then cal

Re: [PATCHES] OpenSSL Applink

2007-10-03 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > I guess you guys already found a solution that works, but there's yet > another function, "BIO *BIO_new_mem_buf(void *data, int len)", that we > could use. We could open and read the file all by ourselves into memory, > then call BIO_new_mem_buf and

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > Your patch looks useful to prevent mismatch of encoding and locale on Windows, > but I found there is a limitation that user will not able to specify locale. > I added an alternative of nl_langinfo(CODESET) for Win32. Applied with small correction ---

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread Hiroshi Saito
Hi. - Original Message - From: "ITAGAKI Takahiro" <[EMAIL PROTECTED]> "Hiroshi Saito" <[EMAIL PROTECTED]> wrote: Ah Ok, Please check it. Your patch looks useful to prevent mismatch of encoding and locale on Windows, but I found there is a limitation that user will not able to speci

Re: [PATCHES] OpenSSL Applink

2007-10-03 Thread Heikki Linnakangas
Magnus Hagander wrote: > Tom Lane wrote: >> Magnus Hagander <[EMAIL PROTECTED]> writes: >>> On Mon, Oct 01, 2007 at 10:51:01AM -0400, Tom Lane wrote: I'd vote for backpatching, but only as far as 8.2, seeing that we're abandoning the older branches on Windows. >>> Should we backpatch a ve

Re: [PATCHES] Doc update: ALTER SEQUENCE name RENAME TO can be rolled back

2007-10-03 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > those changes take effect immediately and are not reversible. However, > !the OWNED BY and SET SCHEMA clauses are ordinary > catalog updates and can be rolled back. > those changes take effect immediately and are not reversible

Re: [PATCHES] ecpg DllMain fix

2007-10-03 Thread Magnus Hagander
On Wed, Oct 03, 2007 at 03:22:12PM +0200, Michael Meskes wrote: > On Wed, Oct 03, 2007 at 02:27:20PM +0200, Magnus Hagander wrote: > > However, shouldn't we be doing it for other ECPG libraries as well? > > Done. Added to MSVC build. //Magnus ---(end of broadcast)-

Re: [PATCHES] ecpg DllMain fix

2007-10-03 Thread Michael Meskes
On Wed, Oct 03, 2007 at 02:27:20PM +0200, Magnus Hagander wrote: > However, shouldn't we be doing it for other ECPG libraries as well? Done. Michael -- Michael Meskes Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [

Re: [PATCHES] ecpg DllMain fix

2007-10-03 Thread Magnus Hagander
On Wed, Oct 03, 2007 at 01:13:58PM +0200, Michael Meskes wrote: > Just committed. I also renamed the functions that are not exported to > make this job easier. Should there be a problem with this it should only > be a missed rename. However the new sources successfully run through the > regression

Re: [PATCHES] ecpg DllMain fix

2007-10-03 Thread Magnus Hagander
On Wed, Oct 03, 2007 at 01:13:58PM +0200, Michael Meskes wrote: > On Wed, Oct 03, 2007 at 12:22:41PM +0200, Magnus Hagander wrote: > > It passes compile. Rebuilding my full tree now to try to work on making the > > regression tests actually be able to test it. > > Sounds good. :-) At least we're

Re: [PATCHES] ecpg DllMain fix

2007-10-03 Thread Michael Meskes
On Wed, Oct 03, 2007 at 12:22:41PM +0200, Magnus Hagander wrote: > It passes compile. Rebuilding my full tree now to try to work on making the > regression tests actually be able to test it. Sounds good. :-) > > I'm working on an export list atm. > > Good. I think we want that regardless of thin

Re: [PATCHES] ecpg DllMain fix

2007-10-03 Thread Magnus Hagander
On Wed, Oct 03, 2007 at 12:19:14PM +0200, Michael Meskes wrote: > On Wed, Oct 03, 2007 at 11:13:27AM +0200, Magnus Hagander wrote: > > Heh, I was about to review that. I'll try to get to it right after lunch. > > Thanks and sorry for jumping the gun. If it doesn't work we can remove > it easily.

Re: [PATCHES] ecpg DllMain fix

2007-10-03 Thread Michael Meskes
On Wed, Oct 03, 2007 at 11:13:27AM +0200, Magnus Hagander wrote: > Heh, I was about to review that. I'll try to get to it right after lunch. Thanks and sorry for jumping the gun. If it doesn't work we can remove it easily. I'm working on an export list atm. Michael -- Michael Meskes Email: Mich

[PATCHES] Doc update: ALTER SEQUENCE name RENAME TO can be rolled back

2007-10-03 Thread Heikki Linnakangas
-- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com Index: doc/src/sgml/ref/alter_sequence.sgml === RCS file: /home/hlinnaka/pgcvsrepository/pgsql/doc/src/sgml/ref/alter_sequence.sgml,v retrieving revision 1.17 diff

Re: [PATCHES] ecpg DllMain fix

2007-10-03 Thread Magnus Hagander
On Wed, Oct 03, 2007 at 10:58:18AM +0200, Michael Meskes wrote: > On Wed, Oct 03, 2007 at 11:54:44AM +0900, ITAGAKI Takahiro wrote: > > Here is a patch to remove DllMain from libecpg on Win32 build. > > I brought the initialization routine from libpq and implemented > > pthread_once() using a lock

Re: [PATCHES] ecpg thread-safe descriptor

2007-10-03 Thread Michael Meskes
On Tue, Oct 02, 2007 at 04:07:06PM -0400, Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: > > Michael Meskes wrote: > >> So, does an explicit export list help? If so I'm all for it. There is no > >> need to export all symbols. I always tried to keep the number of symbols > >> that get

Re: [PATCHES] ecpg DllMain fix

2007-10-03 Thread Michael Meskes
On Wed, Oct 03, 2007 at 11:54:44AM +0900, ITAGAKI Takahiro wrote: > Here is a patch to remove DllMain from libecpg on Win32 build. > I brought the initialization routine from libpq and implemented > pthread_once() using a lock that serializes all pthread_once calls. > I don't have msvc build enviro

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread ITAGAKI Takahiro
"Hiroshi Saito" <[EMAIL PROTECTED]> wrote: > Ah Ok, Please check it. Your patch looks useful to prevent mismatch of encoding and locale on Windows, but I found there is a limitation that user will not able to specify locale. I added an alternative of nl_langinfo(CODESET) for Win32. Please check