Re: [PATCHES] Miscalculation in IsCheckpointOnSchedule()

2007-11-13 Thread ITAGAKI Takahiro
Tom Lane <[EMAIL PROTECTED]> wrote: > ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > > -((double) (int32) (recptr.xrecoff - > > ckpt_start_recptr.xrecoff)) / XLogSegSize) / > > +((double) recptr.xrecoff - (double) ckpt_start_recptr.xrecoff) > > / XLogSegSize) / > > Sure

Re: [PATCHES] Miscalculation in IsCheckpointOnSchedule()

2007-11-13 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > - ((double) (int32) (recptr.xrecoff - > ckpt_start_recptr.xrecoff)) / XLogSegSize) / > + ((double) recptr.xrecoff - (double) ckpt_start_recptr.xrecoff) > / XLogSegSize) / Surely this makes matters worse, not better. What h

[PATCHES] Miscalculation in IsCheckpointOnSchedule()

2007-11-13 Thread ITAGAKI Takahiro
I run long DBT-2 with 8.3beta2 and saw checkpoint spikes periodically. The progress against WAL segments consumption *jumped up* in such cases. It seems to be a miscalculation in IsCheckpointOnSchedule(). xrecoff is uint32, therefore the difference of two xrecoffs could be between -4G and +4G. We

Re: [PATCHES] Better default_statistics_target

2007-11-13 Thread Tom Lane
Greg Sabino Mullane <[EMAIL PROTECTED]> writes: > Per a recent bug in which the planner can behave very differently at < > 100, and accounting for the fact that analyze is still plenty fast on > today's systems even at a tenfold increase, attached is a patch to > change default_statistics_target fr

[PATCHES] Better default_statistics_target

2007-11-13 Thread Greg Sabino Mullane
Per a recent bug in which the planner can behave very differently at < 100, and accounting for the fact that analyze is still plenty fast on today's systems even at a tenfold increase, attached is a patch to change default_statistics_target from 10 to 100. Index: doc/src/sgml/config.sgml =

Re: [PATCHES] a tsearch2 (8.2.4) dictionary that only filters out stopwords

2007-11-13 Thread Tom Lane
> + defstring = defGetString(defel); > + if (pg_strcasecmp(defstring, "True") == 0) > + d->acceptAll = true; > + else if (pg_strcasecmp(defstring, "False") == 0) > + d->acceptAll = fa

Re: [PATCHES] Contrib docs v1

2007-11-13 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > So I assume we were only missing the dict_*/README additions. You are entirely mistaken. There are missing updates in at least README.pg_standby, README.pageinspect, README.intarray, README.pgbench; and README.pgrowlocks is sufficiently confused that it

Re: [PATCHES] Contrib docs v1

2007-11-13 Thread Albert Cervera i Areny
I started importing the files when I notified the list, can't remember exactly when and I've iteratively improved all the files so there can be differences though I thought that contrib READMES where very stable. Anyway, I'll try to take a look at the diffs from then and add those changes. A Di

Re: [PATCHES] Contrib docs v1

2007-11-13 Thread Bruce Momjian
Tom Lane wrote: > Albert Cervera i Areny <[EMAIL PROTECTED]> writes: > > [ contrib sgml docs ] > > I am distressed to discover that these seem to have been generated from > a snapshot taken some time in June, as they are missing the last five > months' worth of changes to the now-deleted README fi

Re: [PATCHES] Contrib docs v1

2007-11-13 Thread Andrew Dunstan
Tom Lane wrote: Albert Cervera i Areny <[EMAIL PROTECTED]> writes: [ contrib sgml docs ] I am distressed to discover that these seem to have been generated from a snapshot taken some time in June, as they are missing the last five months' worth of changes to the now-deleted README fi

Re: [PATCHES] Contrib docs v1

2007-11-13 Thread Tom Lane
Albert Cervera i Areny <[EMAIL PROTECTED]> writes: > [ contrib sgml docs ] I am distressed to discover that these seem to have been generated from a snapshot taken some time in June, as they are missing the last five months' worth of changes to the now-deleted README files.

Re: [PATCHES] tsearch2api .. wrapper for integrated fultext

2007-11-13 Thread Pavel Stehule
On 13/11/2007, Tom Lane <[EMAIL PROTECTED]> wrote: > I wrote: > > I've modified Pavel's version into something that seems to support this > > approach --- at least I can load the 8.2 tsearch regression test > > database into 8.3 after loading this. Still needs some polishing > > probably, and some

Re: [PATCHES] tsearch2api .. wrapper for integrated fultext

2007-11-13 Thread Tom Lane
I wrote: > I've modified Pavel's version into something that seems to support this > approach --- at least I can load the 8.2 tsearch regression test > database into 8.3 after loading this. Still needs some polishing > probably, and some more testing. Comments? I've committed this, replacing the

Re: [PATCHES] Hibernate Dialects for PostgreSQL

2007-11-13 Thread Peter Eisentraut
Am Montag, 12. November 2007 schrieb Simon Riggs: > On Mon, 2007-11-12 at 14:28 +0100, Peter Eisentraut wrote: > > Simon Riggs wrote: > > > I enclose 3 Dialects for PostgreSQL, as discussed on -hackers. > > > > There is no such thing as PostgreSQL 8. Please don't do that; it would > > confuse user