Re: [PATCHES] Fix pg_dump dependency on postgres.h

2007-11-20 Thread Bruce Momjian
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Huh, I think the point is to be able to build 8.3 at all on certain > > Solaris releases. I think it qualifies as a portability fix. > > (a) it wasn't "to build at all", it was to allow "inline" to be enabled > on Sun Studio's compi

Re: [PATCHES] Fix pg_dump dependency on postgres.h

2007-11-20 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Huh, I think the point is to be able to build 8.3 at all on certain > Solaris releases. I think it qualifies as a portability fix. (a) it wasn't "to build at all", it was to allow "inline" to be enabled on Sun Studio's compiler, which apparently is too

Re: [PATCHES] Fix pg_dump dependency on postgres.h

2007-11-20 Thread Bruce Momjian
Alvaro Herrera wrote: > Bruce Momjian wrote: > > > > This has been saved for the 8.4 release: > > > > http://momjian.postgresql.org/cgi-bin/pgpatches_hold > > Huh, I think the point is to be able to build 8.3 at all on certain > Solaris releases. I think it qualifies as a portability fix.

Re: [PATCHES] Fix pg_dump dependency on postgres.h

2007-11-20 Thread Alvaro Herrera
Bruce Momjian wrote: > > This has been saved for the 8.4 release: > > http://momjian.postgresql.org/cgi-bin/pgpatches_hold Huh, I think the point is to be able to build 8.3 at all on certain Solaris releases. I think it qualifies as a portability fix. > -

Re: [PATCHES] Fix pg_dump dependency on postgres.h

2007-11-20 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Zdenek Kotala wrote: > Tom Lane wrote: > > > > > > AFAICT, therefore, the proposed patch should only define YYSTYP

Re: [PATCHES] [HACKERS] pg_ctl -t N register ??

2007-11-20 Thread Bruce Momjian
Alvaro Herrera wrote: > Bruce Momjian wrote: > > Alvaro Herrera wrote: > > > Hi, > > > > > > I just noticed that the "pg_ctl register" synopsis was updated to have a > > > -t parameter. This does not seem to make sense to me. Is it correct? > > > Does it do anything? > > > > > > My thinking is