[PATCHES] reference problem of manifest.(win32.mak of libpq.dll)

2008-01-08 Thread Hiroshi Saito
Hi Magnus, and Dave. It seems that it is different in nmake although the initial value of VisualStudio is embedding. Then, It sees a reference problem by the dll independent. Therefore, embedding considers like an ideal. Please take this into consideration. Regards, Hiroshi Saito win32mak

Re: [PATCHES] win32.mak patch

2008-01-08 Thread Hiroshi Saito
Hi Magnus. From: "Magnus Hagander" <[EMAIL PROTECTED]> I see the problem now. In my dev kit, there is no error for using _USE_32BIT_TIME_T on Win64. That's why I got caught up in your patch being wrong. Umm,... It is very strange.?_? C:\Program Files\Microsoft Visual Studio 8\VC\include\crtd

Re: [PATCHES] Fix for _outAgg()

2008-01-08 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Attached is a patch which fixes an oversight in _outAgg(): the > "grpColIdx" and "grpOperators" fields of the Agg struct were not emitted > by _outAgg(). I don't see any good reason to omit this information. Hmm, I think that must be my fault, but I'm not

[PATCHES] Fix for _outAgg()

2008-01-08 Thread Neil Conway
Attached is a patch which fixes an oversight in _outAgg(): the "grpColIdx" and "grpOperators" fields of the Agg struct were not emitted by _outAgg(). I don't see any good reason to omit this information. Note that while the "grpOperators" field was added during the 8.3 devel cycle, the "grpColIdx"

Re: [PATCHES] [HACKERS] OUTER JOIN performance regression remains in 8.3beta4

2008-01-08 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Would it be a good idea to keep removing redundant clauses and rethink > the preference for clauseful joins, going forward? No --- it would create an exponential growth in planning time for large join problems, while not actually buying anything in the

Re: [PATCHES] [HACKERS] OUTER JOIN performance regression remains in 8.3beta4

2008-01-08 Thread Alvaro Herrera
Tom Lane wrote: > Comparing the behavior of this to my patch for HEAD, I am coming to the > conclusion that this is actually a *better* planning method than > removing the redundant join conditions, even when they're truly > rendundant! The reason emerges as soon as you look at cases involving >

Re: [PATCHES] [HACKERS] OUTER JOIN performance regression remains in 8.3beta4

2008-01-08 Thread Tom Lane
I wrote: > Haven't looked closely at how to fix 8.2, yet. After some study it seems that the simplest, most reliable fix for 8.2 is to dike out the code that removes "redundant" outer join conditions after propagating a constant across them. This gives the right answer in the cases of concern (wh

Re: [PATCHES] win32.mak patch

2008-01-08 Thread Magnus Hagander
On Thu, Dec 20, 2007 at 10:02:24AM +0900, Hiroshi Saito wrote: > Hi. > > - Original Message - > From: "Magnus Hagander" <[EMAIL PROTECTED]> > > > >On Wed, Dec 19, 2007 at 11:19:54AM +0900, Hiroshi Saito wrote: > >>Ummm, Sorry...former patch to be disregarded. > >>Although 64bit mak is