[PATCHES] create language ... if not exists

2008-03-28 Thread Andreas 'ads' Scherbaum
Hello all, yesterday i ran into a small problem: http://andreas.scherbaum.la/blog/archives/346-create-language-if-not-exist.html and was bugged to create a patch for PostgreSQL. So here is a first version, still missing some things like documentation. The attached patch for HEAD extends the CREA

Re: [PATCHES] [HACKERS] Text <-> C string

2008-03-28 Thread Brendan Jurd
On 29/03/2008, Tom Lane <[EMAIL PROTECTED]> wrote: > I intentionally didn't touch xml.c, nor anyplace that is not dealing > in text, even if it happens to be binary-compatible with text. > Hmm, okay. My original submission did include a few such changes; for example, in xml_in and xml_out_intern

Re: [PATCHES] [HACKERS] Text <-> C string

2008-03-28 Thread Tom Lane
"Brendan Jurd" <[EMAIL PROTECTED]> writes: > On 26/03/2008, Tom Lane <[EMAIL PROTECTED]> wrote: >> There are no textout/textin calls left, but I may have missed some >> places that were doing it the hard way with direct palloc/memcpy >> manipulations. It might be worth trolling all the VARDATA() r

Re: [PATCHES] [HACKERS] Text <-> C string

2008-03-28 Thread Brendan Jurd
On 26/03/2008, Tom Lane <[EMAIL PROTECTED]> wrote: > There are no textout/textin calls left, but I may have missed some > places that were doing it the hard way with direct palloc/memcpy > manipulations. It might be worth trolling all the VARDATA() references > to see if any more are easily re

Re: [PATCHES] [BUGS] Incomplete docs for restore_command for hotstandby

2008-03-28 Thread Bruce Momjian
Heikki Linnakangas wrote: > Simon Riggs wrote: > > On Mon, 2008-02-25 at 17:56 +0600, Markus Bertheau wrote: > >> The FIXME of course needs replacement by someone in the know. > > > > Doc patch edited to include all of Markus' points, tidy up some related > > text and fix typos. > > > > Good to a

Re: [PATCHES] [WIP] Keeping track of snapshots

2008-03-28 Thread Alvaro Herrera
Gregory Stark wrote: > "Alvaro Herrera" <[EMAIL PROTECTED]> writes: > > > The other question is about CommitTransactionCommand. Currently my > > EOXact routine barfs for every snapshot not unregistered on main > > transaction commit -- a leak. I see this as a good thing, however it > > forced me

Re: [PATCHES] [BUGS] Incomplete docs for restore_command for hotstandby

2008-03-28 Thread Heikki Linnakangas
Simon Riggs wrote: On Mon, 2008-02-25 at 17:56 +0600, Markus Bertheau wrote: The FIXME of course needs replacement by someone in the know. Doc patch edited to include all of Markus' points, tidy up some related text and fix typos. Good to apply to HEAD. Committed to HEAD with minor fixes.

Re: [PATCHES] [WIP] Keeping track of snapshots

2008-03-28 Thread Gregory Stark
"Alvaro Herrera" <[EMAIL PROTECTED]> writes: > The other question is about CommitTransactionCommand. Currently my > EOXact routine barfs for every snapshot not unregistered on main > transaction commit -- a leak. I see this as a good thing, however it > forced me to be more meticulous about not

[PATCHES] [WIP] Keeping track of snapshots

2008-03-28 Thread Alvaro Herrera
This is the patch I am currently playing with, to keep track of the live snapshots within a transaction. There are some obvious bugs left, and it open certain questions. The most obvious bug is that it is not tracking SerializableSnapshot in a serializable transaction. The main question I curren

Re: [PATCHES] [BUGS] Incomplete docs for restore_command for hot standby

2008-03-28 Thread Simon Riggs
On Mon, 2008-02-25 at 17:56 +0600, Markus Bertheau wrote: > 2008/2/22, Simon Riggs <[EMAIL PROTECTED]>: > > If you have some suggested changes, I'd be happy to hear them. > > > > Probably additions are better than just changes though. > > What about this: > > *** a/doc/src/sgml/backup.sgml > --