Re: [PATCHES] Auto-explain patch

2008-03-29 Thread Dean Rasheed
> On Mon, 2008-01-28 at 09:21 +, Dean Rasheed wrote: >> This is the patch allows logging of the explain plan for each query run, as >> described here: >> >> http://archives.postgresql.org/pgsql-performance/2008-01/msg00245.php >> >> I hope this is useful. > > This looks very good, though I do

Re: [PATCHES] Auto-explain patch

2008-03-29 Thread Simon Riggs
On Sat, 2008-03-29 at 08:47 +, Dean Rasheed wrote: > > I also think we should only log the EXPLAIN if we have logged the SQL > > statement. It's not much use on its own anyway. This then allows this > > feature to work neatly with log_statement and > > log_min_duration_statement. > > > > Woul

Re: [PATCHES] create language ... if not exists

2008-03-29 Thread Heikki Linnakangas
Andreas 'ads' Scherbaum wrote: The attached patch for HEAD extends the CREATE LANGUAGE statement by an IF NOT EXISTS option which in effect changes the raised error into a notice. Before i continue working on this patch i would like to know if this extension has a chance to go into PG and what o

Re: [HACKERS] [PATCHES] Avahi support for Postgresql

2008-03-29 Thread tomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sat, Feb 23, 2008 at 01:13:38PM +0100, Mathias Hasselmann wrote: [...] > Avahi/Bonjour/DNS-SD support[1] is very important, for integrating > Postgresql with modern desktop environments like OSX, GNOME, KDE: It's > very convenient to choose active

Re: [PATCHES] create language ... if not exists

2008-03-29 Thread Andrew Dunstan
Heikki Linnakangas wrote: Andreas 'ads' Scherbaum wrote: The attached patch for HEAD extends the CREATE LANGUAGE statement by an IF NOT EXISTS option which in effect changes the raised error into a notice. Before i continue working on this patch i would like to know if this extension has a ch

Re: [PATCHES] create language ... if not exists

2008-03-29 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Heikki Linnakangas wrote: >> The way we've solved this problem for other CREATE commands is to add >> "OR REPLACE" option, instead of "IF NOT EXISTS". We should do the same >> here. > My recollection is that we only do that where we need to for reason

Re: [PATCHES] create language ... if not exists

2008-03-29 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > The way we've solved this problem for other CREATE commands is to add > "OR REPLACE" option, instead of "IF NOT EXISTS". We should do the same here. If we're willing to consider a solution that is specific to CREATE LANGUAGE (as opposed to implemen

Re: [PATCHES] create language ... if not exists

2008-03-29 Thread Heikki Linnakangas
Tom Lane wrote: Heikki Linnakangas <[EMAIL PROTECTED]> writes: The way we've solved this problem for other CREATE commands is to add "OR REPLACE" option, instead of "IF NOT EXISTS". We should do the same here. If we're willing to consider a solution that is specific to CREATE LANGUAGE (as oppo

Re: [PATCHES] Better psql tab-completion support for schemas and tables

2008-03-29 Thread Tom Lane
Greg Sabino Mullane <[EMAIL PROTECTED]> writes: > Full support for all schema and table name combinations when > getting a list of attributes. All of the following will now work: > select * from information_schema.columns where > select * from foo where > select * from "user" where > select *

Re: [PATCHES] create language ... if not exists

2008-03-29 Thread Magnus Hagander
Heikki Linnakangas wrote: > Tom Lane wrote: > > Heikki Linnakangas <[EMAIL PROTECTED]> writes: > >> The way we've solved this problem for other CREATE commands is to > >> add "OR REPLACE" option, instead of "IF NOT EXISTS". We should do > >> the same here. > > > > If we're willing to consider a so

Re: [PATCHES] create language ... if not exists

2008-03-29 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > If we're implementing IF NOT EXISTS across the board, let's do that for > languages at the same time as for others. Yeah, if we were going to do it at all it should be handled across-the-board, the way DROP IF EXISTS was. However, I seem to recall tha

Re: [PATCHES] create language ... if not exists

2008-03-29 Thread Magnus Hagander
Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: > > If we're implementing IF NOT EXISTS across the board, let's do that > > for languages at the same time as for others. > > Yeah, if we were going to do it at all it should be handled > across-the-board, the way DROP IF EXISTS was. H

Re: [PATCHES] create language ... if not exists

2008-03-29 Thread Tom Lane
I wrote: > ... However, I seem to recall > that in the discussions leading up to implementing DROP IF EXISTS, > we considered and specifically rejected CREATE IF NOT EXISTS. Don't > have time right now to troll the archives for the reasoning. [ back from dinner party... ] Here's the thread I was

Re: [PATCHES] Integer datetime by default

2008-03-29 Thread Neil Conway
On Tue, 2008-03-25 at 12:54 -0700, Neil Conway wrote: > Barring any objections, I'll apply this to HEAD tomorrow. Applied to HEAD. -Neil -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches