Re: [PATCHES] Refactoring xlogutils.c

2008-06-10 Thread Heikki Linnakangas
Tom Lane wrote: "Heikki Linnakangas" <[EMAIL PROTECTED]> writes: Attached is an updated version of my patch to refactor the XLogOpenRelation/XLogReadBuffer interface, in preparation for the relation forks patch, and subsequently the FSM rewrite patch. The code motion in md.c looks fairly bogu

Re: [PATCHES] Refactoring xlogutils.c

2008-06-10 Thread Heikki Linnakangas
Teodor Sigaev wrote: - For the routines that need a fake, or lightweight, Relation struct anyway, there's a new function called XLogFakeRelcacheEntry(RelFileNode), that returns a palloc'd Relation struct. Is that fake structure applicable for ReadBuffer()? Yes. -- Heikki Linnakangas En

Re: [PATCHES] Refactoring xlogutils.c

2008-06-10 Thread Teodor Sigaev
- For the routines that need a fake, or lightweight, Relation struct anyway, there's a new function called XLogFakeRelcacheEntry(RelFileNode), that returns a palloc'd Relation struct. Is that fake structure applicable for ReadBuffer()? ginContinueSplit() calls findParents() with a fake Relatio

Re: [PATCHES] Minor pedantry for "help" text

2008-06-10 Thread Neil Conway
On Mon, 2008-06-09 at 00:25 -0700, Neil Conway wrote: > Attached is a patch that makes some minor changes to the text emitted by > the new "help" command. Applied to HEAD. -Neil -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://

Re: [PATCHES] Refactoring xlogutils.c

2008-06-10 Thread Tom Lane
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > Attached is an updated version of my patch to refactor the > XLogOpenRelation/XLogReadBuffer interface, in preparation for the > relation forks patch, and subsequently the FSM rewrite patch. The code motion in md.c looks fairly bogus; was that a

Re: [PATCHES] \timing on/off

2008-06-10 Thread Heikki Linnakangas
Tom Lane wrote: "Heikki Linnakangas" <[EMAIL PROTECTED]> writes: Here's a patch, based on David's patch, that turns timing into a \pset variable, and makes \timing an alias for \pset timing. This makes \timing behave the same as \x. This seems a bit random to me. AFAIR all of the \pset prope

Re: [PATCHES] SQL: table function support

2008-06-10 Thread Alvaro Herrera
Tom Lane escribió: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Tom Lane escribi�: > >> (It's also worth asking where the import is coming from. Who implements > >> the spec syntax anyway? DB2 maybe, but when was the last time we heard > >> from anyone trying to migrate from DB2 to PG?) > >

Re: [PATCHES] SQL: table function support

2008-06-10 Thread Tom Lane
"Pavel Stehule" <[EMAIL PROTECTED]> writes: > what is more logical and consistent? They're both utterly arbitrary, but the "setof" syntax has been in Postgres since forever, and applies to more things than just "record". The other one doesn't fit in with anything else --- it's just a syntactic war

Re: [PATCHES] \timing on/off

2008-06-10 Thread Tom Lane
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: >> I gather that the conclusion of the thread "Making sure \timing is on", >> starting at: >> http://archives.postgresql.org/pgsql-general/2008-05/msg00324.php >> >> was that we should leave \H and \a alone for now, because it's not clear >> what

Re: [PATCHES] Tentative patch for making DROP put dependency info in DETAIL

2008-06-10 Thread Alvaro Herrera
Tom Lane wrote: > One particular case of interest is in truncate.out, where the > table-at-a-time implementation of DROP TABLE is clearly exposed > by the fact that you get multiple NOTICEs. I wonder if it would > be worth refactoring the code so that a multiple-object DROP is > implemented via p

Re: [PATCHES] GIN improvements

2008-06-10 Thread Teodor Sigaev
Right now this is not a problem because there is no insert_cleanup function for btree, but I wonder if we should clean it up. Look at gistbulkdelete and gistvacuumcleanup, first function wants to send a bool flag to second one and they use GiSTBulkDelete structure instead of usual IndexBulkDelet

Re: [PATCHES] GIN improvements

2008-06-10 Thread Teodor Sigaev
Perhaps we could make the fixed-size buffer be of size X, and trigger autovac on X/3 or some such, to give it enough slack so that it would be very unlikely to be processed by user processes. Do you mean that GIN sends a "smoke signal" to the autovacuum launcher process to ask about vacuum? Curr

Re: [PATCHES] SQL: table function support

2008-06-10 Thread Pavel Stehule
2008/6/10 Neil Conway <[EMAIL PROTECTED]>: > On Tue, 2008-06-10 at 06:42 +0200, Pavel Stehule wrote: >> internally is table functions implemenation identical with SRF. > > It's not the internals that I'm concerned about. > >> Semantically is far - user's doesn't specify return type (what is from >>

Re: [PATCHES] \timing on/off

2008-06-10 Thread Heikki Linnakangas
And here is the patch I forgot to attach. Heikki Linnakangas wrote: I started to look at David Fetter's patch to enable "\timing on/off", in addition to toggling the mod with just "\timing". I gather that the conclusion of the thread "Making sure \timing is on", starting at: http://archives.

[PATCHES] \timing on/off

2008-06-10 Thread Heikki Linnakangas
I started to look at David Fetter's patch to enable "\timing on/off", in addition to toggling the mod with just "\timing". I gather that the conclusion of the thread "Making sure \timing is on", starting at: http://archives.postgresql.org/pgsql-general/2008-05/msg00324.php was that we should

Re: [PATCHES] minor ts_type.h comment fix

2008-06-10 Thread Heikki Linnakangas
Jan Urbański wrote: These should read TSQuery, not TSVector, no? Yep. Applied. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pg