Re: [PATCHES] [HACKERS] SSL configure patch

2008-06-14 Thread Tom Lane
[EMAIL PROTECTED] writes: > Here is the SSL patch we discussed previously for 8.3.1. This appears to change user-facing behavior, which makes the lack of documentation updates unacceptable. Also, it would be helpful to reviewers if you provided a link to that previous discussion.

Re: [PATCHES] relscan.h split

2008-06-14 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Also, it seemed like some of those .c files had no business poking into >> the scan structs anyway; particularly contrib. Did you check whether >> the inclusions could be avoided? > Not really, unless we were to provide something a r

Re: [PATCHES] relscan.h split

2008-06-14 Thread Alvaro Herrera
Tom Lane wrote: > Perhaps a better idea would be to put the opaque-pointer typedefs into > heapam.h and genam.h respectively, and then see where you could remove > inclusions of relscan.h. Hmm, this seems to be closely equivalent. Patch attached. I also moved SysScanDescData from genam.h to rel

Re: [PATCHES] Simplify formatting.c

2008-06-14 Thread Alvaro Herrera
Bruce Momjian wrote: > I moved str_initcap() over into oracle_compat.c and then had initcap() > convert to/from TEXT to call it. The code is a little weird because > str_initcap() needs to convert to text to use texttowcs(), so in > multibyte encodings initcap converts the string to text, then to

Re: [PATCHES] Tentative patch for making DROP put dependency info in DETAIL

2008-06-14 Thread Andrew Dunstan
Tom Lane wrote: multi-object DROP IF NOT EXISTS would fail to perform as expected. Surely this would be a noop :-) cheers andrew -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.or

Re: [PATCHES] Tentative patch for making DROP put dependency info in DETAIL

2008-06-14 Thread Tom Lane
"Alex Hunsaker" <[EMAIL PROTECTED]> writes: > Ok Here it is: > -Moves CheckDropPermissions and friends from utility.c to aclchk.c > (pg_drop_permission_check) > -Makes all the Remove* functions take a DropStmt *, they each do their > own foreach() loop and permission checks Applied with revisions.