Re: [PATCHES] Relation forks & FSM rewrite patches

2008-07-03 Thread Mark Kirkwood
Heikki Linnakangas wrote: Here's an updated version of the "relation forks" patch, and an incremental FSM rewrite patch on top of that. The relation forks patch is ready for review. The FSM implementation is more work-in-progress still, but I'd like to get some review on that as well, with the

Re: [PATCHES] Removal of the patches email list

2008-07-03 Thread Russell Smith
Bruce Momjian wrote: > We have come to agreement that there is no longer a need for a separate > 'patches' email list --- the size of patches isn't a significant issue > anymore, and tracking threads between the patches and hackers lists is > confusing. > > I propose we close the patches list and t

Re: [PATCHES] Exposing keywords to clients

2008-07-03 Thread Tom Lane
Nikhils <[EMAIL PROTECTED]> writes: >>> Attached is an updated patch, giving the following output. Applied with minor revisions. > Here are some comments from me: > a) Changed "localised" to "localized" to be consistent with the references > elsewhere in the same file. What I didn't like about

[PATCHES] Re: [HACKERS] Solaris ident authentication using unix domain sockets

2008-07-03 Thread Garick Hamlin
On Thu, Jul 03, 2008 at 02:01:22PM -0400, Tom Lane wrote: > Garick Hamlin <[EMAIL PROTECTED]> writes: > > I have a patch that I have been using to support postgresql's > > notion of ident authentication when using unix domain sockets on > > Solaris. This patch basically just adds support for

Re: [PATCHES] [HACKERS] Solaris ident authentication using unix domain sockets

2008-07-03 Thread Tom Lane
Garick Hamlin <[EMAIL PROTECTED]> writes: > I have a patch that I have been using to support postgresql's > notion of ident authentication when using unix domain sockets on > Solaris. This patch basically just adds support for using > getupeercred() on Solaris so unix sockets and ident auth

[PATCHES] Solaris ident authentication using unix domain sockets

2008-07-03 Thread Garick Hamlin
Hi, I have a patch that I have been using to support postgresql's notion of ident authentication when using unix domain sockets on Solaris. This patch basically just adds support for using getupeercred() on Solaris so unix sockets and ident auth works just like it does on Linux and elsewh

Re: [PATCHES] pg_dump lock timeout

2008-07-03 Thread Tom Lane
daveg <[EMAIL PROTECTED]> writes: > On Thu, Jul 03, 2008 at 11:15:10AM +0300, Marko Kreen wrote: >> - The statement_timeout is set back with "statement_timeout = default" >> Maybe it would be better to do "= 0" here? Although such decision >> would go outside the scope of the patch, I see no sense

Re: [PATCHES] page macros cleanup

2008-07-03 Thread Heikki Linnakangas
Just one quick note: Zdenek Kotala wrote: *** pgsql.orig.da8c485e0e2a/src/backend/access/gist/gistutil.c pá črn 13 18:00:35 2008 --- pgsql.orig/src/backend/access/gist/gistutil.c pá črn 13 18:00:35 2008 *** *** 592,598 /* * Additionally check that t

Re: [PATCHES] EXPLAIN progress info

2008-07-03 Thread Heikki Linnakangas
I like this idea in general. I'm envisioning a cool explain display in pgAdmin that's updated live, as the query is executed, showing how many tuples a seq scan in the bottom, and an aggregate above it, has processed. Drool. Currently the interface is that you open a new connection, and signal

Re: [PATCHES] pg_dump lock timeout

2008-07-03 Thread daveg
On Thu, Jul 03, 2008 at 11:15:10AM +0300, Marko Kreen wrote: > On 5/11/08, daveg <[EMAIL PROTECTED]> wrote: > > Attached is a patch to add a commandline option to pg_dump to limit how > > long > > pg_dump will wait for locks during startup. > > My quick review: > > - It does not seem important

Re: [PATCHES] page macros cleanup

2008-07-03 Thread Pavan Deolasee
On Fri, Jun 13, 2008 at 9:38 PM, Zdenek Kotala <[EMAIL PROTECTED]> wrote: > I attached code cleanup which is related to in-place upgrade. I replace > direct access to PageHeader structure with already existing macros and I > removed also unnecessary retyping. A quick review comment: One thing I n

Re: [PATCHES] Regression test database name

2008-07-03 Thread Markus Wanner
Hi, Peter Eisentraut wrote: For some experiments I wanted to run the regression tests using a different database (possibly using pg_regress --dbname=), but the name "regression" is hardcoded in a few places. It's trivial to fix, see attached patch. Quick explanation: The fact that psql's \z

Re: [PATCHES] pg_dump lock timeout

2008-07-03 Thread Marko Kreen
On 5/11/08, daveg <[EMAIL PROTECTED]> wrote: > Attached is a patch to add a commandline option to pg_dump to limit how long > pg_dump will wait for locks during startup. My quick review: - It does not seem important enough to waste a short option on. Having only long option should be enough.