Re: [PATCHES] still alive?

2008-09-17 Thread Bernd Helmle
--On Donnerstag, September 11, 2008 15:39:01 +0300 Peter Eisentraut [EMAIL PROTECTED] wrote: Hmm, let's try this: Anyone who thinks the patches list should remain as separate from hackers, shout now (with rationale)! Seems i've missed something, what's then supposed to hold patches now?

Re: [PATCHES] still alive?

2008-09-17 Thread Bernd Helmle
--On Mittwoch, September 17, 2008 22:37:29 +0300 Heikki Linnakangas [EMAIL PROTECTED] wrote: Just send them to pgsql-hackers. Oh, that's fine, since discussions are already moved from -patches and are continued there. The only disadvantage i see is that -hackers is a little more frequented

[PATCHES] Add missing descriptions for aggregates, functions and conversions

2008-07-08 Thread Bernd Helmle
Please find attached a patch that adds some missing descriptions for aggregates, functions and conversions. This will add COMMENTs to the conversion sql script as well. Most of the descriptions are taken from the documentation (especially for the statistic functions). I didn't bother with

Re: [PATCHES] Updatable views

2008-05-08 Thread Bernd Helmle
--On Mittwoch, Mai 07, 2008 20:38:59 +0100 Simon Riggs [EMAIL PROTECTED] wrote: Where are we on this feature? Any update, Bernd? I've merged the patch into current -HEAD and updated some parts. My current *working* state can be reviewed at

Re: [PATCHES] Updatable views

2008-05-08 Thread Bernd Helmle
--On Donnerstag, Mai 08, 2008 13:28:14 +0100 Simon Riggs [EMAIL PROTECTED] wrote: On Thu, 2008-05-08 at 13:48 +0200, Bernd Helmle wrote: --On Mittwoch, Mai 07, 2008 20:38:59 +0100 Simon Riggs [EMAIL PROTECTED] wrote: Where are we on this feature? Any update, Bernd? I've merged the patch

Re: [PATCHES] Updatable views

2008-05-08 Thread Bernd Helmle
--On Donnerstag, Mai 08, 2008 14:42:50 +0100 Simon Riggs [EMAIL PROTECTED] wrote: That makes sense. I can't see how we would make LOCAL CHECK CONSTRAINTs work with rules anyhow. One of the idea's that came up through the discussion was to make the rewriter responsible for collecting check

Re: [PATCHES] Updatable views

2008-05-08 Thread Bernd Helmle
--On Donnerstag, Mai 08, 2008 16:34:39 +0100 Simon Riggs [EMAIL PROTECTED] wrote: Are you planning to work on this? Yes, i do. But i have to finish other things first until i can get back full attention to it, hopefully very soon. -- Sent via pgsql-patches mailing list

Re: [PATCHES] psql command aliases support

2008-04-03 Thread Bernd Helmle
--On Donnerstag, April 03, 2008 03:13:47 +0100 Gregory Stark [EMAIL PROTECTED] wrote: I think you're crazy to think shells are more likely to have conflicts. Shells require a whole token match, not just the first letter. In other words, any alias *starting with* the letters c, d, e, f, g, h,

Re: [PATCHES] psql command aliases support

2008-04-03 Thread Bernd Helmle
--On Freitag, April 04, 2008 01:11:51 +1100 Brendan Jurd [EMAIL PROTECTED] wrote: What is the virtue of allowing such a syntax in the first place? I can't think of any other context where it's okay to issue a command together with arguments without some kind of delimiter, for the obvious

Re: [PATCHES] psql command aliases support

2008-04-03 Thread Bernd Helmle
--On Donnerstag, April 03, 2008 14:36:59 +0100 Gregory Stark [EMAIL PROTECTED] wrote: \o foo instead of \i foo -- check your keyboard layout The point is here you've typed a different command entirely. Unsurprisingly it's going to do something different. Uh well, you surely don't know that

[PATCHES] psql command aliases support

2008-04-01 Thread Bernd Helmle
Folks, please find attached a patch which implements psql command aliases. They work the same way as on bash, zsh and others, for example: #= \alias d \dt+ #= \d List of relations Schema | Name | Type | Owner | Description +--+---+---+- public |

Re: [PATCHES] psql command aliases support

2008-04-01 Thread Bernd Helmle
--On Dienstag, April 01, 2008 11:39:59 -0400 Tom Lane [EMAIL PROTECTED] wrote: Do we really want such a thing? Well, i use aliases everytime and everywhere they got implemented and i found it quite useful to _extend_ existing behavior (integrating additional functionality in an easy way)

[PATCHES] Show login privilege in psql \du command

2007-09-18 Thread Bernd Helmle
Please find attached a tiny patch which adds a Login field to the \du command, displaying wether a role has the LOGIN privilege granted or not. I found this useful, since you have to query the system catalog directly to find out which role is permitted to login. -- Thanks

[PATCHES] Bug in WAL backup documentation

2006-11-03 Thread Bernd Helmle
Our WAL backup documentation says in some parts of it: ...%p is replaced by the absolute path of the file to archive... [1] I think this is (at least for 8.1 and upcoming 8.2 releases) wrong, since the archiver replaces this with pg_xlog/LOGFILENAME only, so that the archive command is

Re: [PATCHES] Updatable views

2006-08-31 Thread Bernd Helmle
--On Mittwoch, August 30, 2006 12:01:25 -0400 Tom Lane [EMAIL PROTECTED] wrote: Bernd Helmle [EMAIL PROTECTED] writes: [ latest views patch ] This is the first time I've actually looked at this patch, and I am dismayed. viewUpdate.c looks like nothing so much as a large program

Re: [PATCHES] Updatable views

2006-08-24 Thread Bernd Helmle
--On Montag, August 21, 2006 02:07:41 -0400 Alvaro Herrera [EMAIL PROTECTED] wrote: So, I'll appreciate if somebody else takes the responsability to fix the remaining issues. I've put a lot of XXX's and some FIXME's. Some functions are in need of some comments as well. While working on

Re: [HACKERS] [PATCHES] Updatable views

2006-08-24 Thread Bernd Helmle
--On Donnerstag, August 24, 2006 11:02:43 -0500 Jaime Casanova [EMAIL PROTECTED] wrote: Actually the code delete implicit rules based on a field added to pg_rewrite but that catalog has a unique index on ev_class, rulename: pg_rewrite_rel_rulename_index UNIQUE, btree (ev_class, rulename) i

Re: [HACKERS] [PATCHES] COPY view

2006-08-23 Thread Bernd Helmle
--On Dienstag, August 22, 2006 23:12:21 -0400 Tom Lane [EMAIL PROTECTED] wrote: At the moment, with the online-index and updatable-views patches both pretty seriously broken, and no sign that the bitmap-index people are awake at all, I might take it on myself to fix this one instead of

Re: [HACKERS] [PATCHES] COPY view

2006-08-23 Thread Bernd Helmle
--On Mittwoch, August 23, 2006 08:24:55 -0400 Tom Lane [EMAIL PROTECTED] wrote: What are these open issues for the updatable views patch you are seeing exactly? Didn't Alvaro list a bunch of issues when he put the patch back up for comment? I have not looked at it myself yet. Indeed he

Re: [PATCHES] Updatable views

2006-08-21 Thread Bernd Helmle
--On Montag, August 21, 2006 02:07:41 -0400 Alvaro Herrera [EMAIL PROTECTED] wrote: Hi, This is the patch for updatable views I've been able to come up with. A nasty bug was just discovered in the upcoming Mammoth Replicator release so I'm not sure if I'm going to have time to work more

Re: [PATCHES] Patch for updatable views

2006-07-26 Thread Bernd Helmle
--On Dienstag, Juli 25, 2006 18:29:39 -0500 Jaime Casanova [EMAIL PROTECTED] wrote: On 7/25/06, Bernd Helmle [EMAIL PROTECTED] wrote: Hi folks, please find attached an implementation for updatable views. Included are support for pg_dump and information_schema, regression test

[PATCHES] Patch for updatable views

2006-07-25 Thread Bernd Helmle
Hi folks, please find attached an implementation for updatable views. Included are support for pg_dump and information_schema, regression test and documentation are missing. Also, there's currently no upgrade path for older PostgreSQL versions and user defined rules on views. I have some code

Re: [PATCHES] Schema move for opclasses, operator and conversions

2006-06-02 Thread Bernd Helmle
--On Donnerstag, Juni 01, 2006 23:03:39 -0400 Tom Lane [EMAIL PROTECTED] wrote: Not to be unkind, Don't worry ;) but is this feature actually worth the code space? I can barely see a use case for relocating operators, and as for the other two, who's ever going to use them? Well, i

[PATCHES] Schema move for opclasses, operator and conversions

2006-06-01 Thread Bernd Helmle
Please find attached a patch that allows operator classes, operator and conversions to be moved between schemas. Regression and documentation patch included. [ sorry if that occurs twice, but my first attempt used the wrong identity :( ] -- Thanks Bernd

[PATCHES] Schema move for opclasses, operator and conversions

2006-06-01 Thread Bernd Helmle
Please find attached a patch that allows operator classes, operator and conversions to be moved between schemas. Regression and documentation patch included. -- Bernd alter_schema.patch Description: Binary data ---(end of broadcast)--- TIP 3:

[PATCHES] Add namespace dependency for conversions

2006-05-19 Thread Bernd Helmle
Currently we don't record any dependencies between namespaces and conversions. This looks inconsistent to me, since we have dependencies on all other objects that live within namespaces. Please find attached a small patch that fixes this issue. -- Thanks BerndIndex:

Re: [PATCHES] ALTER OBJECT SET SCHEMA

2005-08-01 Thread Bernd Helmle
--On Donnerstag, Juli 28, 2005 23:12:37 -0400 Bruce Momjian pgman@candle.pha.pa.us wrote: Here is an updated version of your patch. Would you supply SGML documentation updates to match the code changes? Thanks. Here's my first shot on this. Let me know if there's somenthing missing or

Re: [PATCHES] ALTER OBJECT SET SCHEMA

2005-07-29 Thread Bernd Helmle
--On Donnerstag, Juli 28, 2005 23:12:37 -0400 Bruce Momjian pgman@candle.pha.pa.us wrote: Here is an updated version of your patch. Would you supply SGML documentation updates to match the code changes? Thanks. Bruce, is there any requirement to add some regression tests, too? -- Bernd

[PATCHES] ALTER OBJECT SET SCHEMA

2005-07-03 Thread Bernd Helmle
Here's my current patch for ALTER OBJECT SET SCHEMA: the attached patch file implements schema move for FUNCTION, SEQUENCE, TYPE, DOMAIN and TABLE with all improvements discussed on -hackers recently. Altering OPERATOR, OPERATOR CLASS, AGGREGATE and CONVERSION are currently not implemented