Re: [PATCHES] pg_restore loops forever past EOF for corrupt custom archive files

2007-08-05 Thread Chad Wagner
On 8/5/07, Tom Lane <[EMAIL PROTECTED]> wrote: > > "Chad Wagner" <[EMAIL PROTECTED]> writes: > > This patch modifies the ReadStr function in pg_backup_archiver.c to > validate > > the result of *AH->ReadBufPtr matches the value of l. > > If we&#x

[PATCHES] pg_restore loops forever past EOF for corrupt custom archive files

2007-08-04 Thread Chad Wagner
This patch modifies the ReadStr function in pg_backup_archiver.c to validate the result of *AH->ReadBufPtr matches the value of l. The resulting error is: pg_restore: [archiver] expected 410 bytes, only got 275 bytes pg_restore.diff Description: Binary data ---(end of b

[PATCHES] Allow \pset to parse "on or off" for boolean values

2007-02-18 Thread Chad Wagner
This is a TODO item: o Allow psql \pset boolean variables to set to fixed values, rather than toggle Basically allows for: test=# \pset expanded on Expanded display is on. test=# \pset footer off Default footer is off. test=# \pset footer Default footer is on. test=# \pset foote

Re: [PATCHES] \prompt for psql

2007-02-17 Thread Chad Wagner
On 2/17/07, Tom Lane <[EMAIL PROTECTED]> wrote: "Chad Wagner" <[EMAIL PROTECTED]> writes: > Would it make sense to say: > 1. if pset.notty is set and '-f' switch is not set then use simple_prompt > 2. else then use gets_fromFile(stdin) Actually, ther

Re: [PATCHES] \prompt for psql

2007-02-17 Thread Chad Wagner
On 2/17/07, Tom Lane <[EMAIL PROTECTED]> wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: > stdin makes it impossible to read a script from stdin and still prompt > the user, but I think that is of limited usefulness. You can always get around that by reading the script with -f instead. On bala

Re: [PATCHES] \prompt for psql

2007-02-17 Thread Chad Wagner
On 2/17/07, Peter Eisentraut <[EMAIL PROTECTED]> wrote: Bruce Momjian wrote: > Seems the consensus was this was a good idea, and not feature-creep. I wonder whether we want this to read from the console, like the password prompts, or from stdin. Not sure which is more useful. Good point, I

Re: [PATCHES] \prompt for psql

2007-02-08 Thread Chad Wagner
Anyways, here is the patch again with the pager output changed from 67 to 69. Feel free to use it or ignore it, I still think it is a useful patch and doesn't necessary imply that users will want looping next (although, I would like to do anonymous PL/pgSQL chunks ;). I just understand how usefu

Re: [PATCHES] \prompt for psql

2007-02-08 Thread Chad Wagner
On 2/8/07, Gurjeet Singh <[EMAIL PROTECTED]> wrote: In help.c:slashUsage(), the comment says: /* if you add/remove a line here, change the row count above */ So I guess, the patch should also include a change to the line: output = PageOutput(67, pager); => output = PageOutput(68, pager);

Re: [PATCHES] \prompt for psql

2007-02-08 Thread Chad Wagner
On 2/8/07, Peter Eisentraut <[EMAIL PROTECTED]> wrote: You can do this already approximately so: \echo -n 'Enter value: ' \set x `read && echo $REPLY` Maybe one command is better, though. Yep, in fact that is more or less something similar that I suggested on pgsql-sql yesterday. The only

[PATCHES] \prompt for psql

2007-02-07 Thread Chad Wagner
This adds the ability to "prompt" for internal variable input, below are examples: test=# \prompt x Enter value for "x": 3 test=# select * from foo where x = :x; x --- 3 (1 row) test=# \prompt x Enter x: Enter x: 4 test=# select * from foo where x = :x; x --- 4 (1 row) The input is limi