Re: [PATCHES] mcxt.c

licitly test for > null? We could bloat the code a great deal that way, and slow it down, > without gaining anything at all in debuggability (IMHO anyway). Of course I'm not suggesting this, what I'm suggesting is put an assert( ) if the test can slow down the perform

Re: [PATCHES] mcxt.c

"Neil Conway" <[EMAIL PROTECTED]> wrote: > On Mon, 2003-09-08 at 11:09, Gaetano Mendola wrote: > > "Tom Lane" <[EMAIL PROTECTED]> wrote: > > > I see no value at all in an assert. The code will dump core just fine > > > with or wi

Re: [PATCHES] mcxt.c

"Tom Lane" <[EMAIL PROTECTED]> wrote: > "Gaetano Mendola" <[EMAIL PROTECTED]> writes: > > "Tom Lane" <[EMAIL PROTECTED]> wrote: > >> This seems inappropriate to me. Are you going to suggest that every > >> routine that

[PATCHES] Waiting the patch applied

Hi, one question just to know the right action to take: After having submitted a patch in order to work on a new patch shall I open another fresh CVS snapshot or shall I work on top of my old patch not yet applied ( or refused )? Regards Gaetano Mendola ---(end of broadcast

Re: [PATCHES] Waiting the patch applied

Peter Eisentraut wrote: Gaetano Mendola writes: one question just to know the right action to take: After having submitted a patch in order to work on a new patch shall I open another fresh CVS snapshot or shall I work on top of my old patch not yet applied ( or refused )? Since applying the

Re: [PATCHES] psql italian translation

a una tabella Sinstassi: DROP TABLE nome [, ...] [ CASCADE | RESTRICT ] Please see my post ( I choose the wron address) on hackers, there are some typos on the traslation. Regards Gaetano Mendola ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [PATCHES] minor HISTORY improvement

ble in this way: my_variable ALIAS FOR$1 (note the space missing between FOR and $1). Regards Gaetano Mendola ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]

Re: [PATCHES] minor HISTORY improvement

Bruce Momjian wrote: Gaetano Mendola wrote: Bruce Momjian wrote: Thanks. I have applied this to the SGML docs. The HISTORY file will be updated automatically now. I didn't see in the notes about the "Migration to version 7.4" the fact that now inside a plpgsql function

[PATCHES] pg_autovacuum README patch

--- README.good 2003-10-21 02:40:19.0 +0200 +++ README 2003-10-21 02:37:43.0 +0200 @@ -1,3 +1,3 @@ -PG_autovacuum README +pg_autovacuum README @@ -148,8 +148,8 @@ vacuum analyze is performed. -AnalyzeThreshold is equal to: +deleteThreshold is equa

Re: [PATCHES] pg_autovacuum README patch

Gaetano Mendola wrote: --- README.good 2003-10-21 02:40:19.0 +0200 +++ README 2003-10-21 02:37:43.0 +0200 @@ -1,3 +1,3 @@ -PG_autovacuum README +pg_autovacuum README @@ -148,8 +148,8

Re: [PATCHES] equal() perf tweak

Neil Conway wrote: Ok, I've attached new versions of list.c and pg_list.h -- this is just a *rough sketch* of the new List code -- it definitely won't compile, the intent is just to concretely specify the new List design. Also, I've only updated the important list functions: I stopped at nth(). (I'

Re: [PATCHES] equal() perf tweak

Neil Conway wrote: Gaetano Mendola <[EMAIL PROTECTED]> writes: Why instead of reinvent the whell not use, or at least do a "C" port of stl::list ? Because (a) implementing a linked list is pretty trivial (b) the only difficult part is getting the semantics / API right. I d

Re: [PATCHES] equal() perf tweak

Tom Lane wrote: Gaetano Mendola <[EMAIL PROTECTED]> writes: [ use list with master node and circular linking ] now is very late here ( 04:17 AM ) so I wrote the wrong code ( not checked ) but show the idea of avoid "if". This saves an "if" during addition of a

Re: [PATCHES] equal() perf tweak

Tom Lane wrote: Gaetano Mendola <[EMAIL PROTECTED]> writes: [ use list with master node and circular linking ] now is very late here ( 04:17 AM ) so I wrote the wrong code ( not checked ) but show the idea of avoid "if". This saves an "if" during addition of a

Re: [PATCHES] SIGPIPE handling, take two.

conn->do_sigaction = false; if ( err == 0 ) sigaction(SIGPIPE, &oact, NULL); } #endif /* !HAVE_POSIX_SIGNALS */ Regards Gaetano Mendola ---(end of broadcast)

Re: [PATCHES] SIGPIPE handling, take two.

Gaetano Mendola wrote: Bruce Momjian wrote: I think this is the patch I like. It does the auto-detect handling as I hoped. I will just do the doc updates to mention it. My only issue is that this is per-connection, while I think you have to create a global variable that defaults to false, and

Re: [PATCHES] equal() perf tweak

Bruce Momjian wrote: Is there a TODO here? I'm just evaluating the performances of two version the one proposed by Neil and the one in a "stl::list" fashion. Tom suggested also to see if is the case to implement the function size() constant time or not. Regards

[PATCHES] New List

ser 0m3.980s sys0m1.090s So at the end I think that the best solution is the Neil classical proposal and mantain the length function constant time. Regards Gaetano Mendola ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [PATCHES] New List

Neil Conway wrote: Gaetano Mendola <[EMAIL PROTECTED]> writes: 10E6 INSERT => real 0m5.161s user 0m4.010s sys0m1.150s What operation is this benchmarking? Only linked-list appends, or something else? Only the head append.

Re: [PATCHES] pg_generate_sequence and info_schema patch (Was: SELECT

the result set is empty IMHO this is the more natural behavior. my 2 cents. Regards Gaetano Mendola -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.3 (MingW32) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFAIYxo7UpzwH2SGd4RAnr9AJ4//4AO9VaIQmweneB0BJe8Dv

Re: [PATCHES] updated list rewrite

Neil Conway wrote: I've attached a new version of the list rewrite patch (gzip'ed). Changes since the last patch: I never dig on postgresql code in order to see how and where lists are used, I'm wondering if also a "rope" could be usefull somewhere

Re: [PATCHES] pg_ctl.c

Each undeclared identifier is reported only once pg_ctl.c:219: error: for each function it appears in.) however below the result of my quich review: 1) exit(1) => exit(EXIT_FAILURE) 2) xstrdup protected by duplicate NULL string I seen also that you don't use always the _ macro for error d

Re: [PATCHES] pg_ctl.c

Andrew Dunstan wrote: Gaetano Mendola wrote: Bruce Momjian wrote: however below the result of my quich review: 1) exit(1) => exit(EXIT_FAILURE) If we used a number of different error codes I might agree. But it seems pointless here, and the style is widely used in our code base (I just coun

Re: [PATCHES] pg_ctl.c

Andrew Dunstan wrote: Gaetano Mendola wrote: Andrew Dunstan wrote: Gaetano Mendola wrote: Bruce Momjian wrote: however below the result of my quich review: 1) exit(1) => exit(EXIT_FAILURE) If we used a number of different error codes I might agree. But it seems pointless here, and the style

Re: [PATCHES] pg_ctl.c

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruce Momjian wrote: | Gaetano Mendola wrote: | |>Bruce Momjian wrote: |> |> |>>Here is the C version of pg_ctl.c written by Andrew Dunstan and updated |>>by me. |>> |>>You can use it by creating a src/bin/pg_ctl_test d

Re: [PATCHES] psql - missing tab-completion support for tablespaces

was not able to retrieve the "active" savepoints, is it really impossible to hack that part ? Regards Gaetano Mendola ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html

Re: [PATCHES] [HACKERS] 8.0 libpq: missing get_home_path()

Bruce Momjian wrote: OK, patch attached and applied. I also updated the docs. Just a note for the docs: "%USERPROFILE%/.pgpass" shall be not "%USERPROFILE%\.pgpass" ? Regards Gaetano Mendola ---(end of broadcast)--- TIP 1: subsc

Re: [PATCHES] psql tab-completion improvements

t low impact. Is there a "low impact" concept that override the "feature freeze" ? Regards Gaetano Mendola ---(end of broadcast)--- TIP 8: explain analyze is your friend

[PATCHES] error report on slru.c

Hi all, here a patch that 1) Rise the information about the file missing on pg_clog from detail to error 2) Insert the offset information also for a missing file I did it with the 8.0beta2 sources Regards Gaetano Mendola --- slru.c.orig 2004-10-02 10:56:01.0 +0200 +++ slru.c

Re: [PATCHES] error report on slru.c

Tom Lane wrote: Gaetano Mendola <[EMAIL PROTECTED]> writes: here a patch that 1) Rise the information about the file missing on pg_clog from detail to error This violates the message style guidelines, IMHO. Tom, your opinion is not humble but is is really appreciated, however I think

Re: [PATCHES] error report on slru.c

ow the file and the offset a transaction belong to ? Regards Gaetano Mendola ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html

Re: [PATCHES] additional GCC warning flags

_startup_cost' may be used uninitialized in this function orindxpath.c:262: warning: 'best_total_cost' may be used uninitialized in this function = createplan.c: In function `create_plan': createplan.c:1244: warning: 'opclass' may be used unin

Re: [PATCHES] CVS should die

ver effort. The effort is not so big: http://cvs2svn.tigris.org Do not rename or move around a file because your SCM limits, is insane. Regards Gaetano Mendola ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister comman

Re: [PATCHES] psql \! WIN32 cleanup

just do "/windows/system32/cmd.exe" and leave off the C:? The previous default was "/bin/sh" and that certainly will not work on Win32. I think another path to try if COMSPEC is not defined is: %SystemRoot%/system32/cmd.exe Regards Gaetano Mendola ---(end