FYI, this is a great example of valuable patch review.
It would have been better if the TODO entry would have
been rigth :-)
---(end of broadcast)---
TIP 7: You can help support the PostgreSQL project by donating at
We still need to document the old syntax, especially if we don't change
the example as well.
I agree that the example should be re-written. But I'm not sure if I need
to have a paragraph about the old syntax. There are two reasons:
- I haven't seen any other SQL command where an old syntax
SGML ref text (swapped parameter list, changed example text)
Also, I noticed that the text of the example spoke about a
table employees, but the example used the table emp. I
fixed this inconsistency.
Index: src/doc/src/sgml/ref/cluster.sgml
+1 ... AFAIR there was 0 discussion of the exact syntax before,
so I don't feel wedded to ORDER BY.
A changed patch comes with the next e-mail.
I can not create a patch for CLUSTER table USING col1,col2,col3,
because I'm not yet deep into postgresql and don't have the time
for that. I just
Huh?
You're right. I should have done a quilt refresh -c before re-posting the
patch.
---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do
Index: src/doc/src/sgml/ref/cluster.sgml
===
*** src.orig/doc/src/sgml/ref/cluster.sgml 2007-03-28 23:02:12.0
+0200
--- src/doc/src/sgml/ref/cluster.sgml 2007-03-28 23:03:14.0 +0200
***
*** 20,27
The following table add's a new variant of the CLUSTER command. The old
variants are preserved, as suggested in the TODO entry.
Things I changed:
* The grammar
* psql help text
* psql tab-completion, it favours now CLUSTER table ORDER BY index
* two uses of CLUSTER in the regression, so that
